Angels with Scaly Wings

Angels with Scaly Wings

View Stats:
Soky 13 Jan, 2018 @ 5:04am
mp.time and mp.type can be overwritten, 2 other variables use inconsistent types
Inside adine3.rpy it's possible to overwrite value set to mp.time (set in adine2.rpy) with a value that should be written to mp.tan.

One of the options in the menu sets mp.tan to "easy". The remaining two set mp.time to "normal" or "hard" respectively.


Inside adine2.rpy it's possible to overwrite value set to mp.type (set in chapter1.rpy) because of variable name conflict.


(Not sure if it's going to cause issues, I haven't tested how Ren'Py/Python treats this situation.) Variable mp.teetotaler uses inconsistent types. It's set to boolean type of false inside anna1.rpy, bryce1.rpy, bryce2.rpy and bryce4.rpy. It's set to string value "no" inside remy4.rpy.


(Not sure if it's going to cause issues, I haven't tested how Ren'Py/Python treats this situation.) Variable mp.adineloss uses inconsistent types. Inside chapter4.rpy it's set to boolean value of true or string value of "yes".


None of these cause any immediate issues because those values are not used, but this might cause some issues in potential updates or sequels.
Last edited by Soky; 16 Jan, 2018 @ 7:16am
< >
Showing 1-2 of 2 comments
JeffMakesGames 16 Jan, 2018 @ 1:56am 
Oh.... good catch. I notice that too in the code.

mp.tan is set to easy on one choice. mp.time is set to normal or hard with the other two.

Saunders might need to go back and change that.

...

Actually, what is the purpose of this variable, as well as others? They don't seem like they do anything, (Especially one involving Anna and mp.exercise.)

I can only assume a future update to the game would make use of these in some matter, that or some kind of sequel/remaster of the game?
Last edited by JeffMakesGames; 16 Jan, 2018 @ 1:59am
Soky 16 Jan, 2018 @ 5:52am 
Originally posted by |MG| JeffMakesGames:
Actually, what is the purpose of this variable, as well as others? They don't seem like they do anything, (Especially one involving Anna and mp.exercise.)

I can only assume a future update to the game would make use of these in some matter, that or some kind of sequel/remaster of the game?

They aren't just a normal variables. In the code you can find:

mp = MultiPersistent("awsw")

this code sets multipersistent storage with key having value of "awsw". Multipersistent data can be used in other Ren'Py games (using the same code). After setting a variable with 'mp' you also need to call
mp.save()
to save that variable (which is not a case with any other variables).

So yes, this is almost definitely for a future sequel or update (although they might not be used and are here just in case). I believe you could also use those variables if you wanted to make a fan game.



Edit: I've just updated my original post including more potential issues I found (I've decided against creating separate thread for them and those issues feel related). I encountered the originally mentioned issue by accident and decided to reuse some of code I wrote for this, and made a list of all variables with a list all values that can be set to them, so it was really quick looking for potential issues with them.
Last edited by Soky; 16 Jan, 2018 @ 7:21am
< >
Showing 1-2 of 2 comments
Per page: 1530 50