Custom logo position bug when opening a game page for the first time after client launch

STEAM GROUP

Steam Client Beta SteamBeta

Join Group

STEAM GROUP

Steam Client Beta SteamBeta

394,128
MEMBERS

13,071

IN-GAME

77,241

ONLINE

Founded

8 January, 2013

Overview Announcements Discussions Events Members Comments

All Discussions > Bug Reports > Topic Details

Unjolliness 12 Aug @ 3:01pm

Custom logo position bug when opening a game page for the first time after client launch

ISSUE
When you open a game that has a custom logo for the first time after Steam client launch, this logo appears at the original location for a split second and then moves to the custom location.

OS
Windows 10

STEPS
Set custom logo and change its location
Restart Steam
Open the game page
RESULTS
Logo moves from the original to the custom location

EXPECTED
Logo appears directly at the custom location

Please fix this. It's especially annoying with bright logos because of the flickering it causes.

Video demonstration:
https://imgur.com/a/uGWGjVk

P.S. Might be connected to this issue somehow. This new one is less severe, but still pretty annoying.
https://steamhost.cn/steamcommunity_com/groups/SteamClientBeta/discussions/0/2838914020278101999/

Last edited by Unjolliness; 12 Aug @ 3:37pm

< >

Showing 1-1 of 1 comments

Unjolliness 1 hour ago

Looks like custom logo coordinates are calculated only after first render with default parameters. Those coordinates are probably get cached afterwards, so we don't see this behavior on subsequent page visits.

componentDidMount() { this.props.overview.BHasCustomImages() && this.FetchCustomLogoPosition() }

render() { const {overview: e, fullscreen: t=!1} = this.props, {rgHeroImages: r, bHasHeroImage: n, rgLogoImages: a, logoPosition: s, rgHeaderBlurImages: o, customLogoPosition: l} = this.state

logoPosition: l || s

I think those calculations should be moved to the parent component with actual coordinates passed down as props. It shouldn't hurt performance and even if it did, I'd rather take that than flickering and shifting images.

Last edited by Unjolliness; 1 hour ago

< >

Showing 1-1 of 1 comments

Per page: 1530 50

All Discussions > Bug Reports > Topic Details

Date Posted: 12 Aug @ 3:01pm

Posts: 1

Start a New Discussion