AS OF June 29th, 2021 - This version of Custom Roles for TTT is no longer being actively developed. Please see note at the top of the description.

yep worked, yw and thanks again^^

I figured it out. There was a bug that could cause all of the roleweapons features (and shop randomization) to not work with certain weapons.

Should be fixed now, thanks for the report =)

Hmm, interesting. I'll look into that

also weapons of type EQUIP2 cant be excluded. Is that a bug? See for example https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=1377883019&searchtext=ttt+controllable+manhack

oh nicee, i thank you for implementing^^

And now there is. Thanks for the idea =)

There is not currently a way to do that, no

hey, is there a way of excluding equipment weapons like the radar? only found an option too include in the docs.

hmm okay

The client side settings apply to any server you connect to because they belong to the client. That's how they work and I verified that by testing. I'm sorry Thairoon but I am not going to implement some extremely custom something that risks breaking other addon compatibility. It's not worth it.

if i can count my local host as a server too, then the settings i have set for me on my server do not apply on my local host^^
and to extend the function, there could also be an if condition binding the functions execution to an id that is this unique addon name else drop it and remove the previous setting

Thairoon: I'm not saying if they have both on one server, I'm saying if someone goes to a server running this and then to a different server running another version it causes problems.

And no, it wouldn't avoid compatibility issues because the very fact you are setting the client values to something invalid (-1 or 0) is what causes the compatibility issues.

why would somebody add this addon and another (BEM itself or other versions of Custom Roles)
if this here already contains it? and you listed above that installing other versions of CR and BEM itself would cause compatibility issues under conflicts too^^

and in my last comment i mentioned a function example with a if condition that applies the code clientside if the server has allow_change set to 1. that would also prevent compatibility issues if someone would still install another addon.

At this point the main problem is compatibility, not how to get the client to not have default values. As I mentioned in one of my previous comments, I wrote a proof-of-concept and while it worked in this addon, it caused problems with any other addon that had BEM functionality (BEM itself, other versions of Custom Roles, etc.) and that's not something I wanted to do.

If you set those client values to 0 or -1 and that client joins another server that isn't running code that supports that, their shop window is completely messed up and unusable. They can fix it by changing the client setting values but any time they joined a server running this code they would have the same problem and I don't want to cause that.

a function that does:
if server convar allow_change = 1 then
ulx cexec <playername> allow_change = -1

thats okay^^ at least i know now this isnt done so easily.
btw. i was referring to to ulx beeing able of executing commands on clients
beacuse u said it would be doable if the convar would be set on clientside to -1.
dunno what exactly u where thinking of when u said that but that was just an idea as an solution for that problem

Thairoon: I don't think there is a good way of implementing this without breaking compatibility with other systems which I won't do. If you are really determined to force your clients to use a specific different default, you can use your ULX way to do that but I don't really understand why this is so important. If a player wants to have a different configuration, they should be able to. If your players are asking for the configuration to change, just tell them how to do it themselves. It's in the F1 menu so it's really easy to change.

I think that's as much time as I'm willing to spend on this, sorry.

i had another idea. i remembered my server is running ulx, which enables me to remotely run conosle commands on other players clients. what i havent foud out is how to autoexecute a ulx command on a player on server join. maybe knowing this helps?

there is no way of solving the issue i guess?

@Malivil Ok, Thanks!

@1nvent0r: If you're using a peer-to-peer game you can put the settings you want in the listenserver.cfg file inside your garrymod/cfg folder

Is there a way to edit the settings for a steam peer2peer game? Pardon my ignorance but I don't know anything about the gmod config. Do I need a dedicated server?

autoexec.cfg only runs on the client, it doesn't force a client to run something
I don't think it runs on a server at all

i understand, cant that be achieved too by adding the convar line with value -1 to the autoexec.cfg of the server? it would be executed on every client right? or did i also missunderstood the functionality of the autoexec.cfg?^^

I tested it, it's doable... but if someone switches to a server that doesn't have the same logic, their buy menu completely collapses and is not usable.

So, while I think it would be possible to get what you want working, I don't think I'm going to include it because it causes compatibility problems with other servers that don't have matching logic and one of my tenants is cross-addon compatibility. Sorry =/

That's just over-complicating things...

The right way to do something like this is to have the clientside convars default to an "unset" value, like -1 and then use the server-side values if the client is -1
I can do that, but what I can't do is force anyone who has clientside convars already (e.g. anyone who has ever loaded BEM or any of the CRs that integrate it) to use the new "-1" defaults.

So you can recommend your players set it to "-1" to let the server decide, but most people won't know to do that.

I had an idea. would it work if there would be a clientside convar in the autoexec.cfg of the server that would reveal the current BEM settings of the client which the server could use to decide whether to let client override?

Yea, that's not really how that stuff works, sorry

the clientside convars could be set to the default values on startup if allow_change hasnt been 1 on last startup^^

Hmm I have really no idea on how to interpret that code I just have advanced basic knowledge^^
But what if its Like this:

cols = serverCols
rows = serverRows
size = serverSize
if allow_change then
default = {
cols = serverCols
rows = serverRows
size = serverSize
}
cols = clientCols
rows = clientRows
size = clientSize
end

A simple default is given it wouldnt deny client override. Wouldnt that work? Or am I thinking a wrong logic?^^

The specific code is here: https://github.com/Malivil/TTT-Custom-Roles/blob/master/gamemodes/terrortown/gamemode/cl_equip.lua#L407

That's exactly what it does, except I have no way of telling whether they changed the client side values so if allow_change = 1, then it uses the client values instead of the server values

Like this:

cols = serverCols
rows = serverRows
size = serverSize
if allow_change then
cols = clientCols
rows = clientRows
size = clientSize
end

I dont know if that would work just a thought:
Perhaps if you cant GET clientside convar setting state you could write a function allowing clientside overwrite. Something like "if server convar allow_change = 1 then client can convar cols,rows,size.

The current implementation is a 1:1 from Better Equipment Menu, you either let the client choose or the server tells them what to use.

I would consider changing that but the problem is how do I know if someone wants to use the values they've set versus what you've set on the server? I can't just check for the client-side defaults because if someone wants to actually use those values, it will use the server values instead.

@Malivil yw :) but Its still not working the way I imagined. My Idea is I wanted to set a serverside default and enable the players to adjust to their needs. The Problem Im experiencing is the moment I set the allow_change convar from 0 to 1 then the serverside convars dont apply the default cols, rows and size convars anymore. Is there a way to quickly adjust that?

@Thairoon: All the same BEM convars should be available but you're right I didn't have them in the docs, I just added them. Thanks for letting me know =)

Hey @Malivil,
i was looking for some serverside convars for the Built in BEM but havent found any in the docs.
Are there any? If not, do you think you can implement the column, row and icon size ones like in the original? would be really nice to be able to configure it serverside.

@Horolicht: If you and your friend have some time and are willing to test, I just put out an update that optimizes something that could have been causing the FPS problems. Can you give it a try and see if that's better? It's OK if you don't have time or don't want to =)

@Malivil
After everything we decided to swap to a different Custom Roles addon. With this the lag issue was solved and it stopped giving us headaches. Anyway thank you for your effort

@RuinSmith_Hlit: Luckily I already had a system in place that made this pretty easily to do

everytime i am surprised in your ability to do requests like that, thank you so much!

@Malivil
It's something we can atleast test out, still I don't believe that solves the issue. Next thing we think about it to disable the throttlng of the GPU itself by some third party software or something.
It really is bizarre...

@Horolicht: I honestly have no idea what could cause that. My previous comment to you had a list of the things that this addon displays which really isn't that much. You could try disabling them (via ConVars) to see if that makes a difference?

@Malivil Heyy we sadly couldn't find a solution, but we found an issue we can not pin down. When having this addon active my friends GPU throttles down to like 1-2% usage, which of course causes lag spikes. Without the addon his GPU works fine. We have checked/updated the driver and deactivated everything which could interfere with the gmod settings, but it's no use. He is using an AMD Radeon R9 200 graphics card.
Perhaps you have an idea? Also we did make sure that we both have only this specific addon subscribed.

@RuinSmith_Hlit: I added the feature you asked for =)

There is a new paragraph named "Bypassing Weapon Randomization" on the CONVARS page on my GitHub that explains how it works: https://github.com/Malivil/TTT-Custom-Roles/blob/master/CONVARS.md#bypassing-weapon-randomization

@Horolicht: I would be very curious to know. There aren't many things the addon actually renders. Just the icons over everyone's heads, labels when you look at someone, the color change for Zombies, and the halo affect for Zombie vision, Vampire vision, and traitor vision (if it's enabled).

@Malivil This should not be the problem since we specifically took care that we have the same things from our collection subscribed. When finding a solution I will come back here to report.

There isn't currently a way of configuring that, no. I can add a system using a similar approach to the RoleWeapons and Excludes system (e.g. you create a weaponname.norandom.txt in the data/roleweapons/{RoleName} folder)

probably going to be an impossible question to answer but, with random shops and there percentages, is there anyway to set an item to be 'always there' ignoring making the item a 'tool' ?