No idea why but this mod doesn't work at all for me, interacting with pumps gives no refill option, placing tanks on the ground doesn't do anything, either. Just doesn't seem to do anything, sadly.

@Longrin dont use it then you spoiled C@#NT

太慢了. it's too slow to refill propane

罐子冲几天也冲不满

I am not fixing someone else's mod. Fix your garbage.

@Satanovski - it works, thank you :)

The slow fill stems from mods that alter the useDelta of the torch/tanks. The code edit below is certainly one way of reducing it.

Another would be altering UGTakePropaneMenu.lua line 202, change the 100 to something less. This is the duration value that is passed into the Timed Action and multiplied by 'take' which is the total item uses missing. In a vanilla game, a blow-torch can have 10 'uses', this is then multiplied by the 100 value.
Changing the 100 to a 1, for example, would mean the time needed would be the useDelta missing.

Line 209 uses a MUCH smaller duration value for torches for some reason.

Time to fill a truck can be altered on line 35 of UGFillPropaneTruck.lua.

For those who are not shure where to edit "UGTakePropane.lua" (like me) My path was this:

C:\Program Files (x86)\Steam\steamapps\workshop\content\108600\3394378143\mods\[B42]PumpsHavePropane-transplant\42.0\media\lua\client\TimedActions

Open UGTakePropane.lua with a text editor to change line 47 from this:
self.action:setTime(take * self.duration)

to this:
self.action:setTime(take / itemMax * self.duration)

Save the file and start the game.

can you make a setting where it cuts the time in half or smt? cuz spending a full day filling a tank when i want to fill a trailer next isnt so pleasing

whys it take 3 years to fill a tank?

大佬，丙烷罐加油一天，充入丙烷喷灯只能充1次。

Thanks JamailKamali. That worked!

same issue here, taking way too long to fill a propane tank. not feasible to even use this mod

油泵充丙烷速率非常缓慢,要花上一天

For some reason it is taking Days and days to fill a tank.
It is filling. Just so slow that I need to camp at the pump to fill a bottle.

workshop\content\108600\3394378143\mods\[B42]PumpsHavePropane-transplant\42.0\media\lua\client\TimedActions\UGTakePropane.lua

Line 47:
self.action:setTime(take * self.duration)
->
self.action:setTime(take / itemMax * self.duration)

Thx for JamailKamali

thank you JamailKamali for the fix

Looks like in the latest update they changed the units for PropaneTank UseDelta. In UGTakePropane.lua UGTakePropane:start() needs to be update for the setTime calculation.

function UGTakePropane:start()

print( "keyword: Test UGTakePropane:start() called")
if self.istorch then
self:setOverrideHandModels(nil, "BlowTorch")
else
self:setOverrideHandModels(nil, "PropaneTank")
end
self:setActionAnim("TakeGasFromPump")
self.tank:setJobType(getText("ContextMenu_TakePropaneFromPump"))
self.tank:setJobDelta(0.0)

local itemCurrent = math.floor(self.tank:getCurrentUsesFloat() / self.tank:getUseDelta() + 0.001)
local itemMax = math.floor(1 / self.tank:getUseDelta() + 0.001)
local take = (itemMax - itemCurrent)

self.action:setTime(take/itemMax * self.duration)
self.itemStart = itemCurrent
self.itemTarget = itemCurrent + take
end

slow as in a full day at the pump will not fill the tank , not worth using this

works but the refill rate is extremely slow 42,7

Not working since last update .. propane tank gets never filled

Great mod! Just a heads up, the recent update seems to be preventing the refilling of tanks.

B42.7更新后在油泵充丙烷速率非常缓慢，有考虑修复吗

Does not work with propane tanks. Pump is looking for BBQ tank but propane tanks taken out of bbq are called propane tank.

Not working. Equipped Welding Torch (Empty) in primary and it still didn't show up on the pump.

is this savegame compatible?

Confirmed, working perfectly, equip the Propane Tank (empty) in Primary and you can right click the fuel pump.

Tank you Winnie

It works, but it removes the ability to see how much fuel there still is in the tanks

If it works like the B41 mod, then the pumps have to be on. So you have to power the pumps.

I do not know for a fact, but I assume what is happening is that the mod uses gasoline to fill the things. It does take time, and more time for bigger containers. So maybe when the fuel is out, the propane is out.

Winnie the pooh

Is the propane at gas stations unlimited or limited (like fuel)?

非常感谢

Does not work with propane tanks. Pump is looking for BBQ tank but propane tanks taken out of bbq are called propane tank.

Hey, there is a bug with self-depleeting batteries and propane tank. Could you make recipe to refill propane tanks full somehow? It's fine if it is from thin air, it's gonna be 1:1 for bugs trouble it causes. I don't want to just sit and wait for fix update, who knows when it will come out.

@QAstral thank you

@QAstral
Thank you very much. I will take some time to create a separate mod for this project to avoid any further negative issues

@QAstral
Worked like a charm! thanks my man <3

To fix debug mode you need to do those steps:

1. Open Propane_Refill_recipes.txt from this location:
.\steam\steamapps\workshop\content\108600\3394378143\mods\[B42]PumpsHavePropane-transplant\42.0\media\scripts

2. Update line 3. Instead of CN characters you need to have this:
craftRecipe PropaneRefillMod

3. Remove line 7 (with CN characters)

4. Add a new file Recipes_EN.txt into :
.\steam\steamapps\workshop\content\108600\3394378143\mods\[B42]PumpsHavePropane-transplant\42.0\media\lua\shared\Translate\EN

5. Modify this file from step 4 and add there this block:
Recipes_EN =
{
Recipe_PropaneRefillMod = "Refill Propane",
}

6. Repeat steps 4 and 5 for CN version, where instead of EN would be CN

debug模式启动，填充丙烷瓶会显示错误

经查，确实是“填充丙烷瓶”配方和debug mode冲突导致游戏闪退

好像“填充丙烷瓶”和某个mod冲突了，启动游戏黑屏闪退，log里面显示craft recipe填充丙烷瓶抛异常

hank hill would be proud of this mod

same error, crash at start / or load infinite when start loading scripts

Hello! Same error, the -debug mode crash the game at start when loading scripts.
When i tried to start without this mode enabled, it's working, but it crash the game as soon as it is enabled and lua reload.

Working for me.
Thank you.

Can confirm, this mod is breaking -debug mode. CDTS when trying to launch the game. same error as @hoshie

測了一整晚才發現你這個模組
無法在-debug下進行遊戲
一旦兩者同時啟用便會出現錯誤
不過問題不大 因為你這個模組
即使突然停用也不會造成太大問題
回報一下 ~

AND i would also like to have the feature @stevej018 mentioned - filling propane tanks at the fuel pumps

After the update the games crashes on startup.


I'm not a coder myself but:

- it might be related to UTF-8 or special characters. The error says recipe name "????" which could be that he can't parse the name?
- a few lines above the error the log mentions that there should be no spaces in the recipe name "fuel pump"

Here is the error and below you find the "space info":

LOG : General > [craftRecipe] removing script due to load error = ?????
ERROR: General> ExceptionLogger.logException> Exception thrown
java.lang.Exception: CraftRecipe error in ????? at CraftRecipe.Load(CraftRecipe.java:359).
Stack trace:
zombie.scripting.entity.components.crafting.CraftRecipe.Load(CraftRecipe.java:359)
zombie.scripting.entity.components.crafting.CraftRecipe.Load(CraftRecipe.java:249)


Space error:
ERROR: General > FluidContainerScript.load > Sanitizing container name 'Fuel Pump', name may not contain whitespaces.