My guy. Much appreciated.

kk went ahead and released my forked version with 1.4 compatibility:
https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2894762088

@-=JkJkLoL=- tk421storm Will you kindly update in a comment here should you be allowed to upload your version?

I updated this mod to 1.4 - and included the fix posted below by @Thop - I have opened a pull request on the github, hopefully this is monitored and approved!

1.4v. Mod?!

please update, this is such a useful mod

update?

Hi is this getting a 1.4 update?

Hello everyone. Someone subscribed to one of my mods told me that my walls weren't working and upon investigating it was because THIS mod changes the wall definition. Looking at the comments it seems like that's a problem for some of you too, so here are two solutions, you only need to do one:

1) Make sure this mod is last in your load order so that other mods that rely on the "Wall" source code get that info before this mod overwrites it.

2) Go into the mod definition and change
<ThingDef ParentName="BuildingBase" Name="Wall">
to
<ThingDef ParentName="BuildingBase" Name="MatchingEmbrasures">
The Name field can be literally anything, this is just an example. Doing this will prevent the mod from overwriting the "Wall" code and will instead create a new *Thing* called "MatchingEmbrasures", this will also fix it and is what @cucumpear should do to fix their mod.

this mod is overwriting Wall and BuildingBase, pls fix (i can provide logs if needed)

Doesnt work well with CE but does work fine without CE. Also embrasures counts as outside. Doesn't close as room.
CE has embrasures itself.

for some reason embrasure textures load over mining.co forcefield and it didnt do that in 1.1 or 1.2 pls fix

I'm having the same issue as @Kuiperling and others with embrasures not properly separating rooms. having the mod enabled also seems to stop some walls from other mods from functioning as room dividers too

great mod, love it, question: any chance of adding in an adjustment slider to change how effective the cover is? they do feel a bit to powerful and a little personalized tweaking would be perfect. don't have to if you don't want to, it's your mod, just makin a suggestion to make a great mod greater.

[Matching Embrasures] causes compatibility errors by overwriting Wall in file D:\apps\windows\scoop\local\apps\steam\current\steamapps\workshop\content\294100\937587020\Defs\ThingDefs\Structure\Buildings_Structure.xml

Please fix it! Thanks.

Can this be added to an existing save?

can turrets shoot through embrasures like colonists can?

This mod has the same issue as two other embrasure mods, ED-Embrasures and Seamless Embrasures, where rooms merge between them. Effectively, they no longer function as actual walls in separating rooms.

Having an issue where prison area is spreading through embrasures now. Is this intentional?

Do you think it's possible you could work with the make of Mixed Stone Blocks to get it to match mixed stone walls?

For those who think the cover is too OP, just edit the XML from the mod to the value you want.
Not a 100% practical, bus does the job.

I love that anyone running up to an embrasure gets to use it to shoot equally against someone on the other side. I am not thrilled that you can shoot melee units/creatures with impunity. I wish they would try to break down the wall if they cannot find an easy path to the other side, just like they would try to break down doors if they see someone go through one.

Love that you made this.... Great work.... Yada Yada you have read this before ..... ;)

I was using embrasures by Skullywag before 1.2 broke it. I was wondering if I used this mod if it would mess up my save games?

can we put an embrasure outside up against a cooler?

I second the corner ones.Thanks for sharing :)

Corner embrasures (if possible) should look diagonal, that would be legit. Also would be nice for the in-game description to also explicitly mention that the embrasure acts as a vent. I eventually figured this out even before double checking the mod, but would be nice to not have to recheck the mod page...

should include corner embrasures. I dont see any mods including this.

@Shadow Wolf The embrasures from Fortified Walls have less cover, but are also explosion-proof and have more hitpoints. Those might be perfect for you. Comes with a companion mod, Fortified Doors.

@Kaz the Mercenary The embrasures from Reinforced Walls are explosion-resistant or explosion-proof I believe. Also comes with another mod, Fortified Doors. They are tough, going above 1000 hp in some cases, but not invincible.

95% cover is a little OP, you know you can stack cover from just putting your pawn on a wall close to embrasure?

One version of embrasures or another needs to include mitigation of explosion damage.

Right now explosions just pass right on through, which is wild.

Hey, any chance you can add a setting to change the cover value of the embrasures? I used to run with Brunayla's embrasures, but they're not getting updated and all other embrasure mods have OP cover values. I want to get embrasures that give hardly any more cover than sandbags.

I also think the 95% is probably too high, the "Reinforced Walls" mod only uses 75% (I think) for their embrasures. So maybe keep the value down around 75-85%.

yeah i recommend changing the cover value as well, or even better adding settings. if you could manage the settings this would be the better embrasure choice by far

wouldn't 85-90% be a bit more balanced as you still got the hole you are sticking the gun out of along with part of your face as you need to see what you are shooting at.

shouldnt the embrasures be under security category and not structure?

does anyone know how i could go about changing the cover value of these embrasures for myself?

@RyansPlace I never tested this ok? but I remember back in 2017 Tynan said on one reddit post that, only the object being lean on by the pawn will help with the coverness affect.

I don't see why it would, but does Real Fog of War work with these?

Well done. Thanks for making this.

Your description states that enemies can shoot through these without issue. Is there an advantage to lining sandbags in front of these walls? Do they block blast damage?

I don't use CE and therefore have not optimised embrasures for use with that mod.

They are kinda buggy while using with Combat Extended , you almost cant shoot with aimshot/snapshot anytime

embrasures have giant open holes for shooting out of it so it makes sense that they don't retain heat, you just have to plan better. but thank you for making these, i have used these for a long time and they've been vital :)

Ah okay, thanks. Stinks though I'll have to rethink my next base/restart of rimworld then

As far as I'm aware all embrasure type walls will behave like that now. This changed a couple versions ago, both that a room connected with embrasures to outside will count as outside and the temperature overlay ignoring them.
I usually connect all rooms with embrasures but keep a normal external wall with a second part- embrasure wall for defense.

The embrasure mod I'm using makes it so that any room you use it with isn't considered "inside" does this mod make it so that you can use it on a room wall and anything on the otherside is still inside?

ok ty :)

It's essentially a wall, other than being able to shoot through it and equalising the temperature. You can't walk through or over the embrasures.