Store Page
Slay the Spire
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Slay the Spire

Store Page
Slay the Spire >  Workshop > Michael Mayhem's Workshop > Downfall Expansion Mod - 5.3 > Discussions
Downfall Expansion Mod - 5.3
Description Discussions182 Comments1906 Change Notes
yoonsung 6 Sep, 2021 @ 11:08pm
Bug report : Game Crashed with Snecko and Molten Egg
Game crashed when entering the shop, probably because problem with previewing upgraded card(maybe SnekBeam) with molten egg.

Game crashed.
Version Info:
- Java version (1.8.0_144)
- Slay the Spire (12-22-2020)
- ModTheSpire (3.23.2)
Mod list:
- basemod (5.33.1)
- stslib (1.24.1)
- downfall (3.1.10)
- coloredmap (2.4.1)
- Hermit (1.2)
- superfastmode (1.0.7)
- thecursed (1.1.10)

Cause:
java.lang.ArrayIndexOutOfBoundsException: 1
at sneckomod.cards.SnekBeam.upgrade(SnekBeam.java:68)
at com.megacrit.cardcrawl.relics.MoltenEgg2.onObtainCard(MoltenEgg2.java:39)
at com.megacrit.cardcrawl.relics.MoltenEgg2.onPreviewObtainCard(MoltenEgg2.java:33)
at com.megacrit.cardcrawl.shop.ShopScreen.initCards(ShopScreen.java:266)
at com.megacrit.cardcrawl.shop.ShopScreen.init(ShopScreen.java:212)
at downfall.util.HeartMerchant.<init>(HeartMerchant.java:95)
at downfall.util.HeartMerchant.<init>(HeartMerchant.java:46)
at downfall.rooms.HeartShopRoom.showHeartMerchant(HeartShopRoom.java:98)
at downfall.rooms.HeartShopRoom.onPlayerEntry(HeartShopRoom.java:45)
at downfall.patches.ProceedButtonPatch.Insert(ProceedButtonPatch.java:37)
at com.megacrit.cardcrawl.ui.buttons.ProceedButton.update(ProceedButton.java:205)
at com.megacrit.cardcrawl.core.OverlayMenu.update(OverlayMenu.java:65)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2649)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:871)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:419)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)
< >
Showing 1-7 of 7 comments
Huyra 7 Sep, 2021 @ 10:52am 
Hi, I've got a similar issue:

Game crashed.
Version Info:
- Java version (1.8.0_144)
- Slay the Spire (12-22-2020)
- ModTheSpire (3.23.2)
Mod list:
- basemod (5.33.1)
- stslib (1.24.1)
- downfall (3.1.10)

Cause:
java.lang.IndexOutOfBoundsException: Index: -1, Size: 31
at java.util.ArrayList.rangeCheckForAdd(ArrayList.java:661)
at java.util.ArrayList.add(ArrayList.java:473)
at sneckomod.cards.unknowns.AbstractUnknownCard.replaceUnknown(AbstractUnknownCard.java:197)
at sneckomod.cards.unknowns.AbstractUnknownCard$2.update(AbstractUnknownCard.java:170)
at com.megacrit.cardcrawl.actions.GameActionManager.update(GameActionManager.java:179)
at com.megacrit.cardcrawl.rooms.AbstractRoom.update(AbstractRoom.java:325)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2532)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:871)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:419)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)
#1
&(*null) 23 Sep, 2021 @ 2:46am 
Seemingly unrelated but probably is -- none of the cards show a checked checkbox when viewing the presented upgraded version.

The Egg issue, do you know what actions were taken immediately before?
As it a reward screen, a shop, and is it consistent with every egg for every instance of that thing? If is not, I will track down the card causing it and fix it. If it is, that's a bit more involved and don't quite know the libraries involved well enough to do it from memory and will probably need to install an IDE.
#2
yoonsung 26 Sep, 2021 @ 8:19am 
Originally posted by dereferenced null pointer:
Seemingly unrelated but probably is -- none of the cards show a checked checkbox when viewing the presented upgraded version.

The Egg issue, do you know what actions were taken immediately before?
As it a reward screen, a shop, and is it consistent with every egg for every instance of that thing? If is not, I will track down the card causing it and fix it. If it is, that's a bit more involved and don't quite know the libraries involved well enough to do it from memory and will probably need to install an IDE.

I was entering a shop right after the reward screen(shop fight). Maybe the problem doesn't happen for every instance, because I was holding the egg for quite a long time before then. The problem happened when I was playing Snecko, so I guess the problem is related with some Snecko card.
Last edited by yoonsung; 26 Sep, 2021 @ 8:19am
#3
&(*null) 26 Sep, 2021 @ 4:32pm 
Your specific issue is with snekbeam's "newer" upgrade.
Huyra's is who that reply was for.

Specifically it's this :: https://github.com/mikemayhemdev/EvilWithin/blob/a373e47a8b49cf9cab5e7cb47f9a7cee3ddba868/src/main/java/sneckomod/cards/SnekBeam.java#L68

Which points to an english localization of https://github.com/mikemayhemdev/EvilWithin/blob/a373e47a8b49cf9cab5e7cb47f9a7cee3ddba868/src/main/resources/sneckomodResources/localization/eng/CardStrings.json#L66

The chinese version is also up to date.

The Korean version actually doesn't have English in it. So it would be better if someone made a genuine improvement rather than my English fix. This is how it "should" look in English

https://github.com/mikemayhemdev/EvilWithin/blob/a373e47a8b49cf9cab5e7cb47f9a7cee3ddba868/src/main/resources/sneckomodResources/localization/kor/CardStrings.json#L65

"EXTENDED_DESCRIPTION": [
" NL (Deals !D! damage.) NL Exhaust.",
" NL (Deals !D! damage.)"
]

Since you would have to wait for an update to be posted to Steam, I have a solution for the meantime...
inside steamapps/workshop/content/646570/1010056683/
Open downfall.jar with an archiving application.
Navigate to sneckomodResources/localization/kor/CardStrings.json and open that file. Search "SnekBeam" and change the "EXTENDED_DESCRIPTION" to match what makes sense to you.

Save it, and close the archiving utility.
Start the game with mods enabled.
Start or continue your game.
Open the console
hand add sneckomod:snekbeam 1 1
Let me know if the game crashes.

(I'm not sure on the console command for this specific card's spelling, use the dropdown to find it)

Hope this helps.

If you know japanese, the localization files need help :/
Last edited by &(*null); 26 Sep, 2021 @ 4:44pm
#4
&(*null) 28 Sep, 2021 @ 5:41pm 
Looks like there was a huge update within the last 3 days with a bunch of changes towards the Korean localization shortly after posting this but it doesn't have the fix inside it.
#5
yoonsung 29 Sep, 2021 @ 3:14pm 
I modified the jar file as you advised, and I successfully entered the shop without crash. Thank you so much!!
#6
&(*null) 30 Sep, 2021 @ 1:11am 
You're welcome =D
#7
< >
Showing 1-7 of 7 comments
Per page: 1530 50