Total War: WARHAMMER II

Total War: WARHAMMER II

The Bank of the Great Ocean
NotSoSocial 14 Jan, 2021 @ 3:50pm
Bug Report & Suggestions
There is a bug / exploit I think you should be aware of.

Issue: currently when I click repay loan it forgives my loan but does not subtract any money. I was able to repeatedly take out loans and then repay them during the same turn and retain all the money.
- that said loan payment deductions seem to be working normally, as long as I have a loan out it deducts the money every turn.
-additional note after testing each amount this only occurs with the 30,000 gold increment all lower amounts activate a deduction event. The 30,000 loan repayment triggers no such event.

my active mods in order:
UI Modding Framework
Mod Configuration Tool: Reborn
Region Trading
Region Trading Unrestricted sub mod
Diplomatic Options
Soldiers of Fortune
The Bank Of the Great ocean
Clandestine Aid
GCCM: Main Mod
GCCM: Custom Assets
GCCM: Unique Faction Capitals
Ai General 2
Improved Arrow Trails

*Everything past this point is personal opinion*

Additional notes and suggestions:
you added a 1 second delay to it closing the UI when taking out a loan or making an investment but the large check at the bottom still closes the UI without waiting the 1 second just as if the user had pressed escape. We I click the loan buttom and nothing happens I feel inclined to press the check imediately after.

This also leads to a minor thing that may feel like a bug to most users but is really the script catching up. when you do a transaction and then click the check. Then go back in to UI to compulsively check if it processed and if anything is different, it immediately closes.
This also led me to doing 2 transactions and only the investment registering, without me having money deducted for the investment, just still recieving the return 10 turns later. I was only able to replicate this 2 more times and only with the 30,000 amount.
Granted this is a very minor interface issue / exploit that only occurs if the user clicks things that fast. Nonetheless I wanted to provide feedback on it.

I have a few suggestions on improving the UI to minimize the above minor issue.
1 - starting with the simplest, change the check box to an X to indicate exiting or cancelling, since the user only needs to click it if they are not making a transition. The auto close will close it otherwise.
Additionally if possible, move the X to the corner or a less prominent location to make the user less inclined to needlessly press it.

2 - option 2, have the check be the trigger for the transaction and auto close. I think this is less ideal than option one since it adds another click for the user and may lead to accidental transactions.

3 - purely idealism, if possible, remove the auto close and have the UI refresh for the transaction. Then the user can click the check to exit knowing that the transaction completed before leaving the diplomacy menu.

Note about loans, 7% a turn is 140% over the life of the loan. If I borrow 30,000 and then raise an army of modest value the upkeep wouldn't cover that amount. It's is 72,000 if payed of at the last turn. That is loan shark style loans, i understand wanting the loan to have weight on the player but there is already a time limit to pay back the original amount or else. The only time I would use a loan in this game is if I was desperate but I wouldn't knowing it would bankrupt me. I recommend lowering that amount to 3% per turn, that equals 60% payed over the life of the loan. The player could at most pocket 40% of the amount but face retaliation. This seems more reasonable to me in a desperate situation.
-Alternatively if you want to avoid the ability for a player to profit from unpayment you could set it to 4% at 25 rounds equalling 100% value of the loan and a connection force.
-if possible you could also consider lowering the amount for the first 10 - 15 turns and then increasing it for the remaining 5-10 as a late fee penalty. This would allow it to have low upkeep for the first half or more of the loan but still penalize enough in the end to prevent profit or abuse.

Notes about investing, if possible investing should be a partial gamble. If combined with one of my above loan suggestions. A gamble could make investing borrowed money a very rewarding or very bad thing.
With a lower loan upkeep a player might choose to invest part of or all of his borrowed money. If the player knows he will cover the loan and turn payments for 10 turns than it becomes abusive and repeatable. If they had a chance to lose 25-50% of the investment than this plus the loan payments could create quite the problem. If the player had the chance to earn up to 100-150% on their investment, than that risk may become worth it.
So adding a 15% chance to land on -50% investment lost, -25% investment lost, 30% chance to break even, and 15% chance to get +50% profit and +100% profit. Would create much more inventive for the player to use it, but also risk to make it a weighted decision to not just to do without considering.
-This could be be combined with making investments pay out periodically over the life, similar to how you've done the loan payments. Adding the chance for profit or loss to each pay out. Example, the bank holds 10,000 for 10 turns and then the player recieves it back having all the profit or loss per turn deciding the success of the investment. Each turn the player recieves an income adjustment. Such as -1,000 equalling 10% loss of investment, if the player recieves that same one for 10 turns than they have lost the entirety of the investment. So in this example each turn they could get -1000, -500, 0 , +1000, +1500
Making the maximum loss possible 100% of the investment and the maximum profit possible 150%
While greatly decreasing the likeliness that the player could ever predict how well it will perform. This would also be much more code than just one lump sum payment event at the end, but you have already done a reoccurring turn event so I don't feel like it's a huge leap.


Apologies for any weird formatting. I took notes as I tried it out.
I want to include that I have no knowledge of the dev kit or the restrictions you may be limited by other than a general background in coding.
I hope this helps you improve the mod, I've greatly enjoyed the depth your mods add.
Thank you for joining my Ted Talk.
Last edited by NotSoSocial; 16 Jan, 2021 @ 12:58pm