RimWorld

RimWorld

Replimat
This topic has been locked
sumghai  [developer] 9 Dec, 2020 @ 3:34am
[Details] Why Prison Labor is incompatible with Replimat
As there have been repeated inquires as to why Prison Labor is incompatible with Replimat, I'm providing the following excerpt of a conversation with PL's author Avius, so that people can understand why the issue won't be fixed in the near future.

Summary
Avius did, in fact, already had a fix for the Replimat-PL issue, but mismanaged his own repo so that he can't publish the fixes on his end.

Details
(August 20, 2019)

Avius: oh ok, so I dont know what 'meal logic' you mean, but PL modifies vanilla mechanics so Prisoners can get food from another room
Avius: it should be harmony patch yup
Avius: do you want me to point to specific code fragment?

sumghai:Yes please
sumghai:Because Dubwise and I were working on Replimat together
sumghai:and he was convinced you Prison Labor was doing something different

Avius: https://github.com/Aviuz/PrisonLabor/blob/master/Source/HarmonyPatches/Patch_DisableAreaRestrictionsForPrisoners.cs
Avius: https://github.com/Aviuz/PrisonLabor/blob/master/Source/HarmonyPatches/Patch_SocialPropernessFix.cs
Avius: my bad first one is bad

sumghai: Okay, ignoring first one :wink:
sumghai: Here's what we've got on our side:
sumghai: https://github.com/sumghai/Replimat/blob/master/Source/HarmonyPatches.cs
sumghai: https://github.com/sumghai/Replimat/blob/master/Source/ReplimatUtility.cs

Avius: oh
Avius: yeah i remeber now
Avius: in this version I really ♥♥♥♥♥♥ up
Avius: fixed it but patch is in patch queue for centuries

sumghai: Ah

Avius: okay so here the problem
Avius: I somehow failed to patch it normally
Avius: and did really something weird
Avius: copied all code for food delivery and rewrite it
Avius: then replaced whole code

sumghai: D:

Avius: https://github.com/Aviuz/PrisonLabor/blob/master/Source/Tweaks/FoodUtility_Tweak.cs
Avius: https://github.com/Aviuz/PrisonLabor/blob/master/Source/Tweaks/JobDriver_FoodDeliver_Tweak.cs

sumghai: No wonder Dubs was tearing his hair out trying to work out why our patches weren't compatible with yours

Avius: https://github.com/Aviuz/PrisonLabor/blob/master/Source/Tweaks/WorkGiver_Warden_DeliverFood_Tweak.cs

Avius: those three are for that
Avius: yeah I believe I fixed that, but cant make patch solid and push to master
Avius: its pain in the ass, I'm waiting about a year now
Avius: to push changes

sumghai: You can't push changes?

Avius: I mean, I can but I have only two branches
Avius: master and dev
Avius: and on dev there is too much to do to make it "stable"

sumghai: For my own projects, I usually just push directly to master lol
sumghai: (after testing that it works locally on my machine)

Avius: so there is matser 1 year old and dev and so tiny amount of motivation
Avius: master*

sumghai: I see
sumghai: I guess I'll let Dubs know

Avius: you can override this anyway
Avius: but dont know what is better for you
Avius: I'm planning get back to modding soon, but god know if im going to

sumghai: I'll talk to dubs, but I believe he'll be reluctant to modify Replimat to specifically override Prison Labor

(August 21, 2019)

Dubwise: naaaa
Dubwise: people are ditching prison labor these days for other mods so just have to tell
Dubwise: i aint got time to harmony patch other peoples mods to fix them
Dubwise: takes long enough just to make them compatible

Where to go from here?
As far as Dubs and I are concerned, the ball is firmly in Avius's court here.

I have also received unconfirmed reports that Prison Labor is being maintained by a different author - if someone could put me in touch with him/her, perhaps we can fix this issue once and for all.
< >
Showing 1-6 of 6 comments
Zargachi 11 Jan, 2021 @ 12:55pm 
im playng with both mods today and both works fine together, also, the incomatibility warning is only on Replimat, PL no more have this warning. more than 2 days passed in game and averything apparently works very well. log don't show any erros at all, im in the PL discord server and they said that the incompatibility warning on mod manager is a thing configurated by the mod creator, if is really this case, please remove the warning and update the mod description for more people know they are ok together now. (if you need help to test something on Replimat i would be happy to help)
sumghai  [developer] 11 Jan, 2021 @ 3:14pm 
@Umbra - Are you absolutely sure the incompatibility issue has been fixed?

When running PL with Replimat (only), are prisoners able to use Replimat Terminals installed inside prison cells and other prisoner-allowed areas? And if the Terminals are outside the prisoner-allowed areas, are wardens still able to deliver food to prisoners?

Also, how long ago did PL and Replimat started working again? Was it before Avius's last update, or after the new author Hazzer took over maintaining the mod?

In fact, could you please invite Hazzer to this discussion as well, so that we can officially confirm this is no longer an issue?
Zargachi 11 Jan, 2021 @ 5:06pm 
@sumghai - as far as i know both mods works perfectly, prisioners can take food at will, wardens and colonists too (guests, mercenaries, tenants from other mods too) i just din't teste to animals because i don't have, prisioners was able to go to other rooms to take food like normal colonists as far the doors permit it, i do'nt know how long these two mods works together, i just tested by my self today, i play with more than 100 mods, and i din't see any errors on logs realted to Rep or PL until now.
Hazzer 12 Jan, 2021 @ 1:05pm 
Well a lot change in code since then. Most of classes mentioned in 1st post was change and handled different way. I did quick test run and looks like it works. Didn't check warden food delivery tho.

Vid or didnt happen:
https://www.youtube.com/watch?v=eXIsV5QocZU

Cheers :)
sumghai  [developer] 13 Jan, 2021 @ 4:04am 
Looks good to me, Hazzer! Many thanks for your fixes.

I'll push out an update for Replimat this weekend which will (among other minor fixes) remove the compatibility warning for Prison Labor.

If the wardens does end up having trouble fetching food for prisoners from the Terminals while running Prison Labor, we can then deal with that separately as a bug.
sumghai  [developer] 15 Jan, 2021 @ 7:21pm 
Replimat 1.2.2 has been released, which now removes the compatibility warning for Prison Labor.

If there are any problems in the future, please file a bug report on Replimat's GitHub issue tracker.

In the meantime, I'm closing this discussion.
< >
Showing 1-6 of 6 comments
Per page: 1530 50