I noticed a couple of interesting things while perusing your mod files. First and foremost of which is your use of "if" in the pcm_building_decisions file. The if statements have no limit, so they don't really work. Which honestly is fine, because you are already using a limit on "every_county_province".

Other thing is, you are assigning indexes manually to your traits, which is unnecessary, the new trait system automatically assigns trait indexes when the game loads, so the new syntax is to leave the index empty.