Thank you very much for your suggestions! I will look into improving my code in the next days.
I never thought that much about the performance... Thanks for reminding me!

Hello,
nice mod! I would like to contribute by suggesting some more code optimization:

Since you're using CBA, you can filter out unwanted classes from your XEH. Moreover, I would switch to a "initPost" XEH in the case there are other "HandleDamage" kind EHs applied somewhere (because only the last one returns the damage to apply).


This should work and prevent parachutes to show your custom effects. Please note that the form "addEventHandler ["type", {call myFunction}]" is faster than "addEventHandler ["type", {all my code here}]" and that I assume you implemented functions as suggested above (an alternative could be building your mod by following a CBA template so that your functions would be compiled at their manner).

Going on, when you set your "state" variable you should make its value public by setting the third parameter of setVariable as true (or again with CBA by using CBA_fnc_setVarNet). At the moment you set the variable where the aircraft is local and if there is a pilot change your variable would not exist for the new pilot causing the aircraft to potentially take more damage than the set treshold!

Lastly, you should set a default value when you use getVariable (private _state = _unit getVariable ["FSCL_state", 0];) and you should NOT remoteExec call or spawn since they could be blocked by battleye filters. Instead remoteExec a function (remoteExec is already scheduled when calling for functions, so suspension is allowed as for spawn).

Please consider adding your mod to github even if small in code amount :)

thank you!

@Brazzer, thank you for your sugestions! I will definetely look into optimising my code. Also I will upload the source code to github in the next days and publish the link here and in the mods description.

@Brazzer, here is the link to the mods GitHub[github.com]

I made a pull request, please have a look at github :) I also sent you a friendship request

@Brazzer, thank you! It look really cool, I am already readign the documentation and trying out hemmt!

@Brazzer, when after building the addon using hemmt, which works fine, I got an error while launching arma:
'x\fscl\addons\main\functions\script_component.hpp' not found.
I fixed it by copying the script_component.hpp file into the functions folder. However I still receive an error about a misisng file called "XEH_preStart.sqf"

that's my fault, let me fix it

made a pull request, if you prefer, we can continue with private messages, anyway XEH_preStart is needed for function caching. Solved.

@Brazzer, I will look into it later, I changed some things myself already. There were some minor errors in the scripts (like < and > being swapped) which I changed already, as well as defining the settings inside the XEH_preInit.sqf file. I will push thoses changes tomorow, when I am sure everything works. Additionally I plan on creating a dev branch a GitHub, so that potential problems can be addressed before pushing it to the main/release branch

seems legit to me :) thank you for considering my help. Have a nice day :)

I bloody enjoyed reading this.. Love this community, good on ya fellas!

excellent feedback