Store Page
UBOAT
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews
UBOAT >  Workshop > Urfisch's Workshop > (2022.1) TDC MOD (TVh-Re/S3) > Discussions
(2022.1) TDC MOD (TVh-Re/S3)
Description Discussions30 Comments589 Change Notes
DECAFBAD 25 Dec, 2022 @ 8:06pm
Bugfix thread
commit 8e7498d875932eec79e50fc056f17ece53692aad Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Mon Dec 26 03:48:20 2022 +0100 Update AoB, AoI, spread, gyro dials, even if no solution 1 file changed, 4 insertions(+), 10 deletions(-) commit 63a66368f278b9caa50fc26a212ebec96f5f14f5 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Mon Dec 26 03:25:29 2022 +0100 Hold true bearing steady during salvo shooting At the moment of triggering the firing lever (the launching of the first torpedo), the electro-magnet coupling connected the comparator with the own course receiver and the error signal produced by comparator controls (instead of the error signal from the target bearing dial) and the electric motor driving the shaft, responsible for entering the target bearing to the calculator internals. That means, that since this moment, the bearing pointed to by the periscope/UZO has no influence on the calculator settings. Moreover, the U-Boat can turn during the salvo shot – the change of bearing resulting from the course change is compensated for and the gyro angle will be updated. Because in the circuit there is no latching relay, the firing lever has to be pushed till the last torpedo in the salvo is launched (which is signaled on the torpedo control lamps table).  2 files changed, 18 insertions(+), 5 deletions(-) commit 747d076cb4fea81ca3c473b09dc8d30e8be6ae1f Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Mon Dec 26 00:47:13 2022 +0100 Correct salvo order for 4-fan shots 1 file changed, 8 insertions(+) commit b603537c5f7897ba502af80e19571e54b1d46ced Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Mon Dec 26 00:00:50 2022 +0100 Take real time bearing data during salvo shots The gyro angle was transmitted to the torpedo until the very moment it was launched 2 files changed, 39 insertions(+), 38 deletions(-) commit 157f09c5b69aa373526057afd2b419fd4f037f69 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 Historical salvo interval 1 file changed, 1 insertion(+), 1 deletion(-) commit 7de85bf5ec92d6b353cf57f3938d6407633397e6 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 Correct salvo spreads Values published by Maciek Florek 1 file changed, 20 insertions(+), 12 deletions(-) commit b1636da6b9849ff675ac85cf500626f3b6472b8e Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 Disallow firing forward and aft tubes in the same salvo 1 file changed, 11 insertions(+), 1 deletion(-) commit 4767c3aa69c223d8a2e1578673d179f27211f5a6 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 Faster launch The Torpedo officer's hand is already on the launch lever when the captain orders a launch. A two second delay is simply incomprehensible. 1 file changed, 1 insertion(+), 1 deletion(-) commit 0dd3ca332902c59adf7b68e68b1bdea461d1b085 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 12° course motor 1 file changed, 2 insertions(+), 2 deletions(-) commit 5cae5d69d024f959b49fd1f9c3746e7460dbc5d5 Author: mygamingaccount <68995233+mygamingaccount@users.noreply.github.com> Date: Sun Dec 25 02:32:08 2022 +0100 Fix AOB / dial180 bug 1 file changed, 2 insertions(+), 18 deletions(-)

Patches:
https://gofile.io/d/EaN60p

How to apply these patches:
https://stackoverflow.com/questions/6156474/whats-a-good-gui-utility-to-apply-patches-on-windows
TortoiseSVN:
https://sourceforge.net/projects/tortoisesvn/files/1.9.7/

The TDC Mod files are in your steam/steamapps/workshop/content/494840/2282199115 directory
However I strongly recommend that you make a copy to the Mods directory. Sometimes the Manifest file is updated on the Workshop, and when that happens you will have to re-apply these patches.
Last edited by DECAFBAD; 11 Jan, 2023 @ 10:18am
< >
Showing 1-15 of 15 comments
McDewgle 27 Dec, 2022 @ 4:18am 
Do these changes also fix the TDC launching more than one tube when only one flooded tube is ticked?

And thank you so much for taking the time to put this together!
#1
DECAFBAD 27 Dec, 2022 @ 5:03am 
Originally posted by McDewgle:
Do these changes also fix the TDC launching more than one tube when only one flooded tube is ticked?

And thank you so much for taking the time to put this together!

I am unable to fix that at the moment. All flooded tubes are launched.
Last edited by DECAFBAD; 27 Dec, 2022 @ 5:04am
#2
Eridano2013 30 Dec, 2022 @ 5:33am 
@DECAFBAD

I have tried every possible way to use Tortoise SVN patch, without being able to merge the two files, due to my inability to use programming tools. The instructions on their site are too advanced.
Could you please post the already patched files on a public file server, or send them to my email (which I will send you privately), or write here in simple words how to use that diabolic tool? .
Thank you.
Last edited by Eridano2013; 30 Dec, 2022 @ 5:33am
#3
TigrisDK 31 Dec, 2022 @ 1:47am 
I don't understand how i should use the Tortoise program, i can't well see it on the Stackoverflow? is it possible for you to make a guide? :)
#4
Kyle Hunt 11 Jan, 2023 @ 9:12am 
The link is not working unfortunately. Does the mod have a thread on github?
#5
DECAFBAD 11 Jan, 2023 @ 10:17am 
The code may not be uploaded to github as that would go against the terms of services of Github as well as the Steam Subscriber Agreement.

Trying a different file host:
https://gofile.io/d/EaN60p
#6
Eridano2013 11 Jan, 2023 @ 12:09pm 
Frustration.
Wouldn't it be easier to submit patches to the TDC mod authors, so that they themselves implement the (right) fixes?

I say "correct", because while the TDC mod is a wonderful piece of software, and - to me - an indispensable complement to the game, IMHO it *has issues*. I had to stop using it because, for example, 2-3 torpedoes launched in salvo almost never hit the target, and this is a limitation.
Note - I have read the Manual carefully.
My fault, of course, but maybe not… who knows?
So why can't even those who are not advanced programmers get away with it?
I tried to patiently edit the files by hand, but hours of work were wasted, because the TDC mod I edited (obviously badly) crashed. Maybe one **** brace less, and that's it.
So please cooperate.
#7
DECAFBAD 11 Jan, 2023 @ 12:27pm 
The original author (ZNC) has been absent for years. This means that the only ones who are allowed to apply these patches and distribute an updated version are the devs themselves (DWS)
#8
Kyle Hunt 11 Jan, 2023 @ 4:56pm 
Thanks, the link did work. However I had to manually edit the code files because Tortoise refused to work and spit all kinds of error messages. I would suggest condensing all the changes into one block of code per file, it can help to edit the files quicker.
#9
sq_paradox 20 Jan, 2023 @ 2:38pm 
Originally posted by DECAFBAD:
The code may not be uploaded to github as that would go against the terms of services of Github as well as the Steam Subscriber Agreement.

Trying a different file host:
https://gofile.io/d/EaN60p
There are tons of Unity Harmony mods on Github, likely hundreds. Many dozens of mods for Battletech alone. I have several on my Github account.
As far as I know no Unity Harmony mod has ever been removed from github.

I did a forum search when you started asking me about this and found that this has been explained to you before, but I'll get into the nitty gritty.
I'm not a lawyer so take the following with a grain of salt:

Almost all mods fall somewhere in the realm of copyright infringement. The copyright holder can take it down if they want. We operate within their good graces and generally those can be removed at any time. There are some rare exceptions, but as a rule they own what you create and can take it.
Things get more grey if they actually try to take it. You own the parts of your creation that are wholly yours, but where that dividing line is gets a bit fuzzy. Good policy is to pay for it, and you'll find plenty of examples of that, but that doesn't always happen.
See Star Wars reusing assets from the community without permission, crediting, or paying.
#10
DECAFBAD 20 Jan, 2023 @ 3:13pm 
Originally posted by sq_paradox:
There are tons of Unity Harmony mods on Github, likely hundreds. Many dozens of mods for Battletech alone. I have several on my Github account.
As far as I know no Unity Harmony mod has ever been removed from github.

I did a forum search when you started asking me about this and found that this has been explained to you before, but I'll get into the nitty gritty.
I'm not a lawyer so take the following with a grain of salt:

Almost all mods fall somewhere in the realm of copyright infringement. The copyright holder can take it down if they want. We operate within their good graces and generally those can be removed at any time. There are some rare exceptions, but as a rule they own what you create and can take it.
Things get more grey if they actually try to take it. You own the parts of your creation that are wholly yours, but where that dividing line is gets a bit fuzzy. Good policy is to pay for it, and you'll find plenty of examples of that, but that doesn't always happen.
See Star Wars reusing assets from the community without permission, crediting, or paying.

Battletech third party EULA:
https://steamhost.cn/eula/637090_eula_0
expanded here:
https://legal.paradoxplaza.com/mod-policy?locale=en
gives you permission to use tools necessary to create mods. This implies the use of reverse engineering and decompiling apps, if they are necessary.

UBOAT has no third party EULA, therefore the Steam Subscriber Agreement's terms apply to it.

The Steam Subscriber agreement is straight up draconian compared to the Battletech EULA: you are forbidden to reverse engineer the source code, and to distribute derivative works anywhere based upon the derived code. Nowhere did the devs ever even drop a hint that anybody is exempt from these rules for any reason.
When I asked the devs on their Discord for the permission outlined by all other games' EULA's that use Harmony, I was told to f*ck off. The vetting process is opaque, so I'm left with the only option to publish diffs: these diffs aren't derivative works of UBOAT, these only show you how to change files that are distributed on the Workshop in source code form, to fix problems with the Workshop mod. They can also be inspected to see that the changes are trivial, not requiring any knowledge of the internal workings of the program, outside of what is already available in the source code of the Workshop mod.

Anything else would be equivalent to piracy.

With the assumption that ZNC had the proper permissions to inspect the code, necessary to create the hooks to the internal APIs of UBOAT, the copyright surrounding his implementation and the work belongs to him or her. The Subscriber agreement give only Steam and affiliates the permission to modify the workshop submission: so in the absence of ZNC, either steam or DWS have to change and update the files. I have been forbidden from contributing even after asking.
Last edited by DECAFBAD; 20 Jan, 2023 @ 4:14pm
#11
sq_paradox 20 Jan, 2023 @ 6:58pm 
I'm not going to argue with you.

Take-real-time-bearing-data-during-salvo-shots and Hold-true-bearing-steady-during-salvo-shooting depend on Correct-salvo-spreads being done first.
That's fine if people apply all the patches in order, but you may want to state the patches are not independent and shouldn't be applied piecemeal.

There are also a bunch of changes that got exported that aren't actually changes, but that's neither here nor there.

Additionally, you have a syntax error in the correct salvo spreads patch:
TorpedoParameters = new TorpedoData(angles + 360f) % 360f, GetDistance(), IsAFT());

should be:

TorpedoParameters = new TorpedoData((angles + 360f) % 360f, GetDistance(), IsAFT());
Last edited by sq_paradox; 20 Jan, 2023 @ 7:01pm
#12
DECAFBAD 20 Jan, 2023 @ 10:07pm 
Originally posted by sq_paradox:
I'm not going to argue with you.

It you don't want to, then don't, lol.
You probably shouldn't be so open about committing copyright infringement. If you keep your yapper shut you'll still have plausible deniability on your side.



I didn't rebase individual patches onto the root for each change, that would have taken unnecessary work.
#13
sq_paradox 21 Jan, 2023 @ 9:09am 
Originally posted by DECAFBAD:
You probably shouldn't be so open about committing copyright infringement.
It's still copyright infringement even if you have permission, or a license (depending on the terms). That was my entire point.
They still own it, they've just agreed not to enforce the copyright.
Last edited by sq_paradox; 21 Jan, 2023 @ 9:19am
#14
DECAFBAD 21 Jan, 2023 @ 11:46am 
Originally posted by sq_paradox:
It's still copyright infringement even if you have permission, or a license (depending on the terms). That was my entire point.
They still own it, they've just agreed not to enforce the copyright.

Are you trying to be silly or are you genuine? Or you just didn't read any of the terms?
It says right there in the Battletech modding terms: they allow you to use their tools to create derivative works, for the purpose of publishing mods, with the understanding that you won't receive compensation in return. It's all perfectly outlined.
Do you think it is copyright infringement to use software the way it is defined in the license agreement?! Are you kidding me?

And DWS never said anything about not enforcing the license terms that they made you agree with, you are just implying that they are going to willy-nilly forfeit their copyright. Unless you reach out to them and ask them for the permission to use reverse-engineering tools, because their use is very, very specifically forbidden, you will be in breach of the agreement when you use them.
Last edited by DECAFBAD; 21 Jan, 2023 @ 12:00pm
#15
< >
Showing 1-15 of 15 comments
Per page: 1530 50