I lied. Playing KG now. The modifiers from the unique advisor decisions seem to last a few months to a year or two before expiring and the decision becomes available again. Probably from the latest update.

100% reproduction rate.

http://i.imgur.com/ctXxTyB.jpg

It is originally WAD, since these retirement events fire if you aren't actually hiring unique advisors. The events don't - and can't - check whether they are in the advisor pool or not. It means you always need to stop the game, enact decisions and hire them as soon as possible, if we set these retirement events to happen directly after these advisors have "dead". Otherwise the modifiers will be removed during you are trying to hire them.
But I will take a look and make your waiting time shorter.

Btw. I can't understand why there are so many Nitori... It shouldn't be so. I need to check the code.

EDIT:
I figured out. You enacted these decisions, but haven't actually hired them. After some months the retirement events happened and you were able to hire the same character again despite of the fact that she is in your advisor pool.
That's why in the early version I have set 50 years for the expire the modifiers without the retirement events. In this way, you can't choose decisions. The negative part is you can't hire advisors for 50 years no matter if they have dead. I don't decide which one is better. Need some time for consideration.

Ah, yes, I was using the decision purely for the tech modifiers.

In my opinion, the earlier version was a bit better. It somewhat prevents what I was just doing - using the decisions just for the tech bonus, which felt pretty cheesy. Unless there's a flag to differentiate between an active advisor and an advisor in the pool, I don't see the current version working and it's a little immersion-breaking having multiples of the same character in your pool.

Though I feel like there's a better way to implement this, but I can't think of anything at the moment.

To be honest, if you feel it is a cheat or player exploit, you can just choose not to use it.
Another solution is, we can increase the cost of decisions and add timers in order to force players not to choose decisions constantly.

Put some thought into it and I wasn't able to come up with a perfect solution.

But I may have an alternative though it requires more work. What about leaving the advisor system vanilla and simply making the summons an event? You could have the event give the buff and a whole new set of positive or negative events revolving around these characters being at court. This way, you can have them stay for as long as whatever arbitrary time limit you want to set, if at all, as well as having full control over the mechanic.

Even more work, but you could even make it permanent with no reason not to take it at the start of the game and then redo and switch out the game's events with Touhou-flavored events, since most, if not all, events are either administrative/diplomatic/military events.

Since we can't check advisor's existence in the pool, we would have the same result as the current system. Such summon events will fire even if you have advisors in the pool.
In addition, the reason why I added the current decisions is because I wanted to respect player's will than randomness in this choice.

The events you have suggested are already in game. The presence of characters at the court triggers many events or modifies their chance.

I mean taking them out of the advisor system entirely and making their presence felt just through (a lot of) events. If creating new and unique events becomes too draining, you could rebrand the game's generic events with Touhou splashes, change the descriptions to match, and make some modifications to the choices and effects, so that the overall feel of the base game is not lost, but not so much that the game feels awkward or loses its balance.

The more I think about it, the more the whole system seems... forced. What with the aging and death vs everliving characters.

Touhou advisor icons are one of the strong points of this mod. Thus I would like to keep them as advisors.

You are right about the game balance, but it is too ambitious, considering the size of the current team.

Hi guys, i wanna start by saying thanks for this mod, make a donate button so i can buy you a coffee.
Now, I've been playing as KG (got trashed after 180 years tho) And a few bugs from them. Firstly, Elections are only once every 100 years? That's painful. Secondly, when the election did come round, I wanted to vote alice to get her admin points, but it was set to lose 1 republic legitimacy per year. With elections once every 100 years, that means voting for her would ruin the game (I don't know if that continued to the next election, I didn't make it sadly).
Next one, the KG advisors expire after 10 months, not 10 years, every time. That's a little frustrating, but I can't tell if it's a bug or if it's because I can't afford to hire the character as an advisor, any advice on that one?

Anyway, I'm gonna play as Hakurei now, I'll let you know if I find any bugs there. Thanks again!

Originally posted by Tenryū:

Hi guys, i wanna start by saying thanks for this mod, make a donate button so i can buy you a coffee.
Now, I've been playing as KG (got trashed after 180 years tho) And a few bugs from them. Firstly, Elections are only once every 100 years? That's painful. Secondly, when the election did come round, I wanted to vote alice to get her admin points, but it was set to lose 1 republic legitimacy per year. With elections once every 100 years, that means voting for her would ruin the game (I don't know if that continued to the next election, I didn't make it sadly).
Next one, the KG advisors expire after 10 months, not 10 years, every time. That's a little frustrating, but I can't tell if it's a bug or if it's because I can't afford to hire the character as an advisor, any advice on that one?

Anyway, I'm gonna play as Hakurei now, I'll let you know if I find any bugs there. Thanks again!

The election terms are not really truthful - age-related death will usually claim them. I think the 100 years is just a "for life" term, basically. There isn't a way to make rulers immortal in EU4, so we can't really do anything about them eventually dying (then being re-elected).

That was a change a few updates ago, when you use the Decision to get them, they'll leave the Court if you don't hire them after a while. If you hire them proper, the effect will remain until they die or you kick them out. Though it's a bit bugged right now and if you keep letting them "time out", and then bring them back, they'll keep adding to the pool, since EU4 doesn't check the Advisor pool...

Originally posted by xkuripuri:

The election terms are not really truthful - age-related death will usually claim them. I think the 100 years is just a "for life" term, basically. There isn't a way to make rulers immortal in EU4, so we can't really do anything about them eventually dying (then being re-elected).

That was a change a few updates ago, when you use the Decision to get them, they'll leave the Court if you don't hire them after a while. If you hire them proper, the effect will remain until they die or you kick them out. Though it's a bit bugged right now and if you keep letting them "time out", and then bring them back, they'll keep adding to the pool, since EU4 doesn't check the Advisor pool...

Alright, thanks for the clarification! Any ideas about the negative republican tradition if I wanted to vote Alice? I'll play again and try and get a screenshot this time.

Originally posted by Tenryū:

Originally posted by xkuripuri:

The election terms are not really truthful - age-related death will usually claim them. I think the 100 years is just a "for life" term, basically. There isn't a way to make rulers immortal in EU4, so we can't really do anything about them eventually dying (then being re-elected).

That was a change a few updates ago, when you use the Decision to get them, they'll leave the Court if you don't hire them after a while. If you hire them proper, the effect will remain until they die or you kick them out. Though it's a bit bugged right now and if you keep letting them "time out", and then bring them back, they'll keep adding to the pool, since EU4 doesn't check the Advisor pool...

Alright, thanks for the clarification! Any ideas about the negative republican tradition if I wanted to vote Alice? I'll play again and try and get a screenshot this time.

The negative Tradition is intended, yes. I think the idea is because, for Kirisame, Alice has some better abilities and stats overall, you get a penalty for using her. For Reimu its the same for Yukari, and SDM has Sakuya who does the same.

So expect if you use them, to spend a few "terms" having the counterpart in charge to recover your Tradition. I know chatnoir is wanting to add more events and the like to recover Tradition though, so there is more reason to try using the other ruler.

Originally posted by xkuripuri:

The negative Tradition is intended, yes. I think the idea is because, for Kirisame, Alice has some better abilities and stats overall, you get a penalty for using her. For Reimu its the same for Yukari, and SDM has Sakuya who does the same.

So expect if you use them, to spend a few "terms" having the counterpart in charge to recover your Tradition. I know chatnoir is wanting to add more events and the like to recover Tradition though, so there is more reason to try using the other ruler.

Oh, maybe it was just because of the last patch, but I played SDM in the last patch and didn't get negative RT for choosing Sakuya?

Sakuya has the republican tradition penalty in the current version.

Hi guys, sorry, it's me again... I've been playing the fairies and I've come up against something a bit... annoying.... I've been going to fabricate claims on Alsace and when rivaled, the game tells me that there is only a 0.06% chance of discovery. But I'm discovered in the first month. Annoying. rage quit and re-try. same again. So I started a new game, only to find that this happened again. Same thing, each time, 0.06% chance of discovery, then discovered in the first month. So I tried it a 3rd time and low and behold, the same again. Is there a rhyme or a reason to this??? It's not a game breaker, it's just really annoying, especially as the HRE vs HRE aggressive expansion penalty is HUGE. Thanks in advance!