The Binding of Isaac: Rebirth

The Binding of Isaac: Rebirth

[Rep] Jukebox
AceHand 27 Nov, 2024 @ 12:03pm
Adding song titles to What's That Song? when both mods are active
Hey there!

I noticed that when both Jukebox and What's That Song? are simultaneously active, the AddTitlesToJukebox function is always overridden by the one from Jukebox, meaning the song titles do not get added to What's That Song? in such a scenario.

To ensure compatibility between the two mods, would you consider adding the following lines to the end of the function? It would be greatly appreciated. Nevermind, for some reason this causes a crash, but only when Jukebox is exclusively active. Strange? After a bit of trial and error, I have found a solution. If you would consider adding the following, updated lines to the end of the function, it would be greatly appreciated! I shall be making the necessary changes to What's That Song? to ensure the titles are correctly displayed on the Jukebox side.

if WhatsThatSong ~= nil and WhatsThatSong ~= true then WhatsThatSongAPI:AddSoundtrack(title, tracklist) end

EDIT: I additionally discovered that, vice versa, if both mods are active, the WhatsThatSongAPI:AddSoundtrack function is always overridden by the one from What's That Song? though I have not yet found a solution for fixing that.

EDIT 2: I have now found a solution for the issue mentioned in the EDIT, which works when either of the mods are active on their own, or if they are active simultaneously. The crash that happens when the above lines of code are added to the AddTitlesToJukebox function in the Jukebox mod's Lua file is still a mystery.

EDIT 3: Everything should be solved now.
Last edited by AceHand; 27 Nov, 2024 @ 4:39pm
< >
Showing 1-1 of 1 comments
☢ Nato Potato ☢  [developer] 29 Nov, 2024 @ 9:15pm 
Ah, never expected people to run both mods at the same time so wasn't considering this kind of issue, thanks for this, I'll update in a bit
< >
Showing 1-1 of 1 comments
Per page: 1530 50