Total War: WARHAMMER II

Total War: WARHAMMER II

Pirates of the World (w/ OvN Araby support!)
Almatar 14 Aug, 2021 @ 12:59pm
Bug
Your mod breaks the animation of the Master Assassin from the Eshin Clan
https://ibb.co/CB2xXM7
< >
Showing 1-5 of 5 comments
Lingling 14 Aug, 2021 @ 1:38pm 
The same happens with the Eshin sorcerer
piercebuster  [developer] 14 Aug, 2021 @ 2:58pm 
Thanks for the report. Looking into fixing it now.
piercebuster  [developer] 14 Aug, 2021 @ 3:28pm 
Fixed https://i.imgur.com/kkSetog.jpg

Why this bug happened:
In order to save on memory, Warhammer 2 doesn't load every animation of every unit that exists in the battle. It only loads the animations of the units it thinks it will need.
This is very good. You wouldn't want the game to load over 1,000 animations every battle.

Unfortunately, instead of just... loading the animations of the units actually in the battle.... it instead has a chart that it references by faction, and factions are authorized certain animations.
(The specific table for this is culture_to_battle_animation_tables_tables)

So it checks: Is Faction A in the battle? OK, load *every animation* Faction A is authorized to have.

The pirates in sea encounters belong to the faction wh2_dlc11_cst_vampire_coast. In the base game culture_to_battle_animation_tables_tables gives all the animations for Vampire Coast units to wh2_dlc11_cst_vampire_coast, and none of animations for other races' units. So I need to assign these animations from other factions to the wh2_dlc11_cst_vampire_coast faction so that it works.

For reasons beyond me (see: poor coding practices), Creative Assembly did not assign the Master Assassin hu17_dlc14_master_assassin_dual_claw or Eshin Sorcererhu17_skaven_eshin_staff_and_sword animations to the SKAVEN faction in this table. My best guess is that there is another programming rule in the game that governs the assignments that modders don't have access to, but defers to the faction animations chart. This makes sense: As part of the modding agreement Creative Assembly worked out with Games Workshop, Games Workshop reserves the right to be able to remove all modded units in the future. This gives them the option to remove the animation chart and mod units die while original units still work, I theorize.

So this has worked.... until it hasn't, right now. When I created a new entry in that table to give that animation to the Vampire Coast faction, the game only found that entry. It didn't also find another entry for the Skaven. Meaning that then only gave it to the Vampire Coast.

The fix is simple. Just add another entry for the animations to the Skaven faction.

But the fix should have never needed to happen.

Since these two animations belonged to DLC agents, I double-checked the animations of all other DLC units and agent units that this mod uses.

I also found that the Greenskins' snotling pumpwagon was missing their own animation rule, so I updated that as well.

I didn't see any others, so hopefully everything works as intended now.

Thanks again for the report. If you still encounter the bug, uninstall and reinstall the mod to make sure that you download the update, since Steam doesn't always push updates.
Last edited by piercebuster; 14 Aug, 2021 @ 3:37pm
Lingling 14 Aug, 2021 @ 3:37pm 
Thanks for fixing it so fast. I really enjoy playing with the more varied sea encounters :steamthumbsup:
piercebuster  [developer] 14 Aug, 2021 @ 3:46pm 
Thank you! This mod is the third-most time-intensive mod I've made yet. I knew it would be received well but the reception has been even better than I expected. I'm glad people are enjoying it!
< >
Showing 1-5 of 5 comments
Per page: 1530 50