I'll look into this today and see what's going on. In the meantime, if you need to fix your character's points you can type !CDT_ResetMyAbilities in the chat box in game (you may need to enter it twice if you haven't typed anything else yet) while controlling the character whose ability points you want fixed. You'll see a confirmation message in the chatbox when the command is recognized. This will remove all points you have in combat abilities and set your character to the correct amount of available ability points, including an extra point if you have All Skilled Up talented.

I just reread what I wrote and realized it doesn't really make sense. Sorry, it's late here. ^^
Anyway, here is what is going on as far as I can tell.
You are supposed to lose the Combat Ability point when you deactivate All Skilled Up, so yeah that works as intended for me. The problem is that when you then reactivate All Skilled Up, you do not actually receive that extra point again.
This means that activating and deactivating that Talent gives you a -1 on overall Combat Ability points with each cycle. The invested Luminary points don't seem to get deleted when those are all that's left, but if you change them to something else while doing this, it is in fact possible to end up with 0 Combat Ability points.

As for your temporary fix, I'll try it and report back.

EDIT: I can confirm that your suggested fix worked and I managed to recover the point I've lost. Thank you.

So there were two issues here:
1. If your character had All Skilled Up when entering the mirror then you would be short an ability point when leaving the mirror if you chose Accept.

2. If your character removed All Skilled Up in the mirror and there was not an available Larian ability point or free ability point to relinquish, then CDT abilities would not be decremented to compensate for the lost point from removing All Skilled Up.

I've updated CDT to address both of these problems. Thanks for making this post!

I've installed a bunch of other unrelated mods, played to Act 2 while going wild with mirror respecs and class mods. So far so good. Seems that whatever you have changed is working well so far.
Great job and thank you. ^^

I have noticed a different bug that isn't too problematic as far as I can tell, but I thought I'd point it out. When I'm shopping for gear at vendors and I compare what they're selling to what I have equipped, often random items display +1 Luminary bonuses that aren't actually real.
Not sure yet when or why this happens and I have installed a lot more mods that might interact with yours in some suboptimal way since my original post, but it can get confusing when you buy an item for its Luminary bonus and it doesn't actually have one once it's in your inventory.

PS: I'm at the beginning of Act 2 and my crit mage Luminary build is very strong. I don't feel like this class is underpowered at all.

PPS: At what point do the Luminary vendors start selling some Legendary weapons? The rest of my party is gathering Legendary equipment fast at level 11. Driftwood's Luminary vendor is still stuck selling Epics at best.

I'm not sure why you wouldn't be able to see the Luminary bonus on item tooltips after you purchase them. The boosts are actually a part of the item's data itself. Custom Damage Types checks for these boosts in the item data and when it detects them, it adds a label to the tooltip. So it's unexpected that CDT would be able to detect this boost when you're trading with the vendor, but not when the item is in your inventory.

Are you playing using a controller? For keyboard+mouse users, this boost detection process is unified across all UIs in the game (player inventory, trader inventory, crafting menu, etc.), but for controller users each UI has to handled individually. There may be an issue specifically with the inventory UI if you are on a controller. I bought several Luminary and Light Resistance items on vendors while using KBM and didn't notice any stats disappearing. The next time you notice one disappearing, I'd be interested to know if you still get the boost when equipping the item. Please check this if it happens to you again.

Luminary vendors follow the same item rarity progression of the "base" object categories for weapons, meaning that unless a vendor is designated to specifically roll higher than the item category normally would, then Luminary will keep pace. Looking at the tables now, many vendors do have a guaranteed roll or two at an elevated rarity. I've added a chance for the Luminary vendors to roll some higher tier pieces of gear so that they should remain competitive. You should find a Legendary piece of gear on a Luminary vendor a little over half the time at level 11 with the new patch.

I'm playing the GOG version on PC with keyboard and mouse.

The first time I remember noticing it, it happened when I was trading with Nebora in Act 1 to get a ring with a useful bonus.
My equipped ring showed a +1 Luminary bonus it didn't have before, after or outside the trading menu while I was trading with her.
I actually took a screenshot when it happened.
https://i.postimg.cc/d1xQdzw1/2022-01-30-0554-1.png
Similar things have sporadically happened with other items too since, but I've mostly ignored it since it didn't affect me too much.

One of my other characters actually did have a real +1 Luminary ring equipped at that time. Might this have something to do with it?

Ah OK, I am see some potential problems based on your screenshot. You have opened the trade window with one character (your lizard) and then are trying to trade from another character (Ifan). This may cause CDT to try and scrape the boosts that the character you started the trade with has on items in that slot. Meaning that your lizard probably had a ring on with Luminary, but Ifan did not. Additionally, this is a comparison tooltip which throws another monkey wrench into things.

I am pretty confident that this is all just a visual glitch though. If the trader is selling an item with Luminary on it, then that item should boost your Luminary if you equip it to a character.

I will look into this tomorrow and try to sort it out. Thank you for bringing this to my attention.

Sounds about right.
I entered the dialogue with my custom main Luminary Lizard, saw that she sold a Huntsman ring and switched to my Ranger Ifan to compare it with his rings and see if I needed it.

I found another visual bug.
https://i.postimg.cc/zD4M79xC/2022-02-02-2038-1.png

I'm trying to craft the Luminary Source books and the icons are missing from the crafting menu.
(...and so is the Lockpicks icon next to the Identifying Glass for some reason?)

I pushed a fix to CDT for the tooltip issues when trading with merchants.

The icons missing is a problem with how the game generates icon images in the UI. You should download LaughingLeader's mod "Combined Icon Atlases - Larian Icons" to heavily mitigate the circumstances that icon images will disappear.

I noticed 2 more things. One of them kinda weird.

First, I bought a Legendary Staff from the Driftwood Luminary vendor and it keeps switching between Light damage and "Rot" damage randomly for some reason. No idea what triggers it or how to reproduce it but it has happened multiple times. Doesn't affect me too much during combat because I use it mostly for the bonuses but still, probably worth looking into.

https://i.postimg.cc/Gbkn71bD/2022-02-03-1001-1.png
https://i.postimg.cc/w628zcyT/2022-02-03-1223-1.png

I used two of the Luminary Maces in the earlier parts of this playthrough and never noticed anything like that with those.


The second is a minor visual thing. I saw you removed a minus. Maybe you also want to remove a plus.
https://i.postimg.cc/r8MX7YpP/2022-02-03-1125-1.png


I really enjoy this class. Finally I'm able to run a mixed damage party that doesn't feel ineffective or like I'm constantly struggling with friendly fire from my mage. I appreciate your work.

Thanks for the additional reports. The rot damage you're seeing is a UI-only issue and won't affect your combat damage at all. This used to be consistently reproducable by mousing over many items in very quick succession but your manifestation of the issue may be different considering that's from the equipment pane. I'll look into this and see if I can put in some extra failsafes to make sure the UI edits take hold more consistently.

The extra + sign should be much quicker to fix by comparison 😁

Good to hear you are enjoying the mod and finding it useful in your playthrough!

https://i.postimg.cc/5bmRcBs2/2022-02-07-0553-1.png

Unidentified gear items show Luminary bonuses and resistances before being identified with the newest update. Didn't notice this before but maybe I didn't find any.

I'll double check this as I know I fixed this once. It may be some comparison tooltip bug again lol

Pushed a fix to CDT for this.