Store Page
Project Zomboid
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Project Zomboid

Store Page
Project Zomboid >  Workshop > Orc's Workshop > Improvised Glass > Discussions
Improvised Glass
Description Discussions5 Comments218 Change Notes
 This topic has been pinned, so it's probably important
Orc  [developer] 20 May, 2022 @ 6:21am
Bug Reports
Post your bug reports here. Please include the following
  • General explanation of the error and the expected behavior
  • Any other mods you may be using
  • Windows, Linux or MacOS
  • Steps to reproduce the error
  • If possible, relevant error log(s)
< >
Showing 1-15 of 15 comments
Manwith Noname 28 May, 2022 @ 6:29pm 
<edit>Pretty much skip this post and go to the second one with fixes listed.</edit>

Posting here because it was the first mod I found with an actual bug report thread.

I just happened to look through my logs and found some warnings and errors. I'll start with the one I have pinpointed, though this applies to the flooring mod...

WARN : General , 1653782547485> ItemPickerJava.ExtractContainersFromLua> ignoring invalid ItemPicker item type "ImprovisedFlooring.IFMagazineEasteEgg"

This was just typos in SBIF_MagazineDistributions.lua

The following I've not looked at in depth because I'm tired...

ERROR: General , 1653782543735> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowWood" ERROR: General , 1653782543740> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowWood" in recipe "Make Wooden Window" ERROR: General , 1653782543746> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowWood" ERROR: General , 1653782543751> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowWood" in recipe "Make White Tiled Window" ERROR: General , 1653782543756> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowWood" ERROR: General , 1653782543761> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowWood" in recipe "Make Tiled Window" ERROR: General , 1653782543766> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowWood" ERROR: General , 1653782543771> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowWood" in recipe "Make White Window" ERROR: General , 1653782543776> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowMetal" ERROR: General , 1653782543781> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowMetal" in recipe "Make Chrome Window" ERROR: General , 1653782543787> LuaManager.getFunctionObject> no such function "ImprovisedGlass_XPMakeWindowWood" ERROR: General , 1653782543792> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "ImprovisedGlass_XPMakeWindowWood" in recipe "Make Slider Window"

There's a bunch of these relating to other mods also but I need sleep.
Last edited by Manwith Noname; 29 May, 2022 @ 2:55pm
#1
Manwith Noname 29 May, 2022 @ 11:23am 
Ok, fresh eyes can see some other typos that eluded me last night. A brief summary of things I have found thus far. Code blocks contain the corrected line that clears the error from the log.

Improvised Glass

...\ImprovisedGlass\media\lua\server\IGRecipeCode.lua

Line 36 function Recipe.OnGiveXP.ImprovisedGlass_XPMakeWindshieldCar(recipe, ingredients, result, player)

Letter "d" missing in "XPMakeWindshieldCar"

...\ImprovisedGlass\media\scripts\IG_recipes_vehicles.txt

Line 23 OnGiveXP: Recipe.OnGiveXP.ImprovisedGlass_XPMakeWindshieldCar,

Underscore missing.

Still not spotting the issue with the previously posted list but it took a few passes to spot these also.

...\ImprovisedGlass\media\scripts\IG_recipes_windows.txt

OnGiveXP: Recipe.OnGiveXP.ImprovisedGlass_XPMakeWindowWood,

All recipes missing "Recipe.OnGiveXP.".

...\ImprovisedGlass\media\scripts\IG_recipes_windows_disassemble.txt

SkillRequired:Woodwork=2,

Skill name should be Woodwork instead of Carpentry ofor all recipes except the metal window.

Adding detail for other mods so it's all in one place.

Improvised Cabinetry

...\ImprovisedCabinetry\media\lua\server\ICRecipeCode.lua

Line 2 function Recipe.OnGiveXP.ImprovisedCabinetry_XPWoodCabinet(recipe, ingredients, result, player)

Missing "t" in XPWoodCabinet

...\ImprovisedCabinetry\media\scripts\IC_recipes_parts.txt

Line 11 SkillRequired: Woodwork=2,

Skill name should be Woodwork instead of Carpentry.

Improvised Flooring

...\ImprovisedFlooring\media\lua\server\Items\SBIF_MagazineDistributions.lua

table.insert(ProceduralDistributions.list["DaycareCounter"].items, "ImprovisedFlooring.IFMagazineEasterEgg");

Missing "r" in lines 270, 272, 274 and 276 in "IFMagazineEasterEgg"

...\ImprovisedFlooring\media\scripts\SBIF_Recipes_Garden.txt

SkillRequired:Woodwork=1;Farming=1,

As previous, skill name should be Woodwork. Lines 29, 42 and 55.

Improvised Paint

ERROR: General , 1653846975039> LuaManager.getFunctionObject> no such function "Recipe.OnGiveXP.Give10FarmingXP" ERROR: General , 1653846975055> RecipeManager.LoadedAfterLua> no such function LuaGiveXP = "Recipe.OnGiveXP.Give10FarmingXP" in recipe "Improvised Plaster"

Initial search suggest this function doesn't exist. At least my find in files search of the base and mod lua files didn't pull up anything.
Last edited by Manwith Noname; 1 Jun, 2022 @ 8:57am
#2
Orc  [developer] 29 May, 2022 @ 5:02pm 
Wow.... you're the real MVP! When I get some time this week I'll go through and squash all these bugs.

Thank you so very much for sharing them, honestly surprised some of these weren't caught earlier
#3
Manwith Noname 29 May, 2022 @ 5:16pm 
No worries. I don't like just saying "X is broken" so I always at least look for things I can potentially solve or at the very least conclude with reasonable accuracy what the problem is.

Originally posted by Orc:
...honestly surprised some of these weren't caught earlier

Haha, I'm not. The number of times I had to read the log file and cross reference the code in the various files before spotting what was actually wrong was...well, sometimes embarrassing. Primarily the missing Recipe.OnGiveXP. ones. Multiple times of "name checks out" before I finally realised what I was not seeing.

The old adage "I may be slow but I get there" certainly applied.
#4
Orc  [developer] 1 Jun, 2022 @ 6:47am 
Once again Manwith NoName thank you for your time and effort here.
I've taken some time over lunch to knock out and publish all these fixes.

Really appreciate the effort you put into this. Made it so much easier to find, fix and verify. The carpentry thing is pretty embarrassing. lol
#5
Manwith Noname 1 Jun, 2022 @ 9:05am 
Again, not a problem. It only made sense to document the things I found accurately to make fixing them at source as simple as it could be. No point expecting you to dig through error codes when I've already done it.
#6
Balisarda 7 Aug, 2022 @ 10:04pm 
Not really a bug report, but the recipe book "Precision vehicle windows and crafting" should be "Precision Vehicle Windows and Crafting" to bring it in line with all the other titled books.
#7
Orc  [developer] 8 Aug, 2022 @ 8:07am 
@Balisarda I just checked and you're absolutely right. I'm not entirely sure why it isn't camel-case like everything else. Next time I push an update I'll slip that in
#8
747074170 19 Aug, 2022 @ 9:51am 
when you have glass in minor containers, for example chest bags, it requires only wood glue to fix windows, glass won't be used.
#9
Orc  [developer] 19 Aug, 2022 @ 1:40pm 
@747074170 oh! When I get back to town I’ll be sure to look into that. I’m indisposed for a few days but making note of this . Thank you
#10
Kyrox 17 Sep, 2022 @ 4:30pm 
Handyman Corner's Kitchen Kilns. Magazine is invisible when reading.
#11
Orc  [developer] 19 Sep, 2022 @ 6:01am 
Originally posted by Kyrox:
Handyman Corner's Kitchen Kilns. Magazine is invisible when reading.

Absolutely not intended. I've added it to the fix list
#12
THE DINOSAURUS REX 22 Dec, 2023 @ 1:10pm 
When you use the virus vaccine mod, all broken windows/jars gives "Shattered glass", and its then impossible to get "Broken glass", is there a way to use both in recipe or add a compatibility patch inside ? thank you
#13
l1bb 21 Apr @ 10:29am 
eerie country visual bug, the window should be closed but its not visually
#14
l1bb 21 Apr @ 10:29am 
same with the opened ones
#15
< >
Showing 1-15 of 15 comments
Per page: 1530 50