Shadows of Forbidden Gods

Shadows of Forbidden Gods

Orcs Plus
Draktanar 24 Jul, 2023 @ 5:21am
NPE error (24/27/2023)
A few game now have crashed because of this error:

NullReferenceException: Object reference not set to an instance of an object at Orcs_Plus.ModCore.onPersonDeath_StartOfProcess (Assets.Code.Person person, System.String v, System.Object killer) [0x00060] in <070778036c2d417a9fbff285ea8a2a06>:0 at Assets.Code.Person.die (System.String v, System.Boolean printMsg, System.Object killer, System.Boolean printTurnMsg) [0x00081] in <99889f8b324d4e9586f97cd056c9063c>:0 at (wrapper dynamic-method) Assets.Code.Unit.Assets.Code.Unit.die_Patch0(Assets.Code.Unit,Assets.Code.Map,string,Assets.Code.Person) at Assets.Code.Unit.turnTick (Assets.Code.Map map) [0x00027] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.UM.turnTick (Assets.Code.Map map) [0x00001] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.Map.processUnits () [0x00043] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.Map.turnTick () [0x00159] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.World.bEndTurn (System.Boolean forceThrough) [0x0036e] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.UIInputs.hotkeys () [0x00892] in <99889f8b324d4e9586f97cd056c9063c>:0 at Assets.Code.UIInputs.Update () [0x00052] in <99889f8b324d4e9586f97cd056c9063c>:0
< >
Showing 1-13 of 13 comments
Horrible Marksman 24 Jul, 2023 @ 4:18pm 
Figured I'd just attach my error here as well. Both times I've seen this error has been shortly after using the sapling of life power to create an orc encampment.

NullReferenceException: Object reference not set to an instance of an object
at Orcs_Plus.Pr_Vinerva_Life.crises (Assets.Code.SG_Orc orcSociety) [0x00042] in <17d0cdbc0512418989d8360cb1da4318>:0
at Orcs_Plus.Pr_Vinerva_Life.turnTick () [0x005be] in <17d0cdbc0512418989d8360cb1da4318>:0
at Assets.Code.Location.turnTickProperties () [0x00037] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.Location.turnTick () [0x00048] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.Hex.turnTick () [0x00015] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.Map.turnTick () [0x00112] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.World.bEndTurn (System.Boolean forceThrough) [0x0036e] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.UIInputs.hotkeys () [0x00892] in <99889f8b324d4e9586f97cd056c9063c>:0
at Assets.Code.UIInputs.Update () [0x00052] in <99889f8b324d4e9586f97cd056c9063c>:0
ilikegoodfood  [developer] 25 Jul, 2023 @ 2:08am 
Thank you both for the reports.
@Draktanur This bug was resolved in the last hotfix yesterday.
@Horrible Marksman I will get a fix out for this ASAP.
Last edited by ilikegoodfood; 25 Jul, 2023 @ 2:12am
ilikegoodfood  [developer] 25 Jul, 2023 @ 2:36am 
@Horrible Marksman Fix is live. That you for making em aware of that error, as it's a somewhat major oversight on my part, and could have been effecting a lot of people.
I had completely missed it due to playing with the Living Wilds mod, for which that particular error would not occur..
Draktanar 25 Jul, 2023 @ 10:00am 
thanks for the quick fixes :)
Horrible Marksman 25 Jul, 2023 @ 4:28pm 
Thank you for the quick fix and really just making the mod. The warmonger play style is my favorite and it really does add more potential opportunity to focus on it. Building up your forces to late game and then having the hordes, dark empire, and ravenous dead go to town is absolutely priceless.
jwjmoffat 2 Sep, 2023 @ 3:15am 
i know this dosent have anything to do with this NPE error but i have been suffering something that might be similar when trying to perfect a horde. it says. keynotfoundexception: the given key'orcsplus.foreground_perfecthorde.png' was not found in the dictionary.
ilikegoodfood  [developer] 2 Sep, 2023 @ 3:18am 
Originally posted by jwjmoffat:
i know this dosent have anything to do with this NPE error but i have been suffering something that might be similar when trying to perfect a horde. it says. keynotfoundexception: the given key'orcsplus.foreground_perfecthorde.png' was not found in the dictionary.

Oh dear. I didn't update the image name correctly. I'll put out a patch for that immediately.
ilikegoodfood  [developer] 2 Sep, 2023 @ 3:37am 
I just double checked the Image names for both game versions 1.0 and 1.1, and they match what they should match ("Icon_PerfectHorde.png" and "Foreground_PerfectHorde.png" respectively). There was a naming error with Perfect Raiders for game version 1.0, so if you had any of those in play, they would be producing the error you describe, but the hordes themselves shouldn't be.

What game version are you playing on? 1.0, or the Beta branch 1.1?
How long ago did you start the game? It's possible that if started last week, the game has saved the old image name, and isn't updating to the new one.

If that's not the case, I would recommend carefully checking where Orcs Plus in your mod load order, writing it down, then unsubscribing from the mod, giving Steam a few minutes to delete the local files, and then resubscribing. You will need to put it back in the load order exactly where it was before for the save game to be most likely to work.
In the meantime, I will upload the Perfect Raiders fix, and continue to investigate.
jwjmoffat 2 Sep, 2023 @ 3:50am 
it says im on version 1.0 and i cant remember when i got the game exactly but definitely not recently
ilikegoodfood  [developer] 2 Sep, 2023 @ 4:14am 
Originally posted by jwjmoffat:
it says im on version 1.0 and i cant remember when i got the game exactly but definitely not recently

While searching for the cause of this error, I have found a number of save-load errors. I am fixing all of those now, and also updating all the image file names to match the standardisation I introduced to the upcoming overhaul.
Hopefully this will solve your issue, but if one of the other items effected by the save-load errors is already present in your game, they may lead to further crashes down the line.
Sorry about that...
ilikegoodfood  [developer] 2 Sep, 2023 @ 4:36am 
Originally posted by jwjmoffat:
it says im on version 1.0 and i cant remember when i got the game exactly but definitely not recently
I found the error. It was indeed an image name, but for the power, rather than for the unit it creates. This next update will fix that for sure. With a little luck, everything else will just work out.
ilikegoodfood  [developer] 2 Sep, 2023 @ 4:53am 
Update is live.
jwjmoffat 2 Sep, 2023 @ 5:39am 
thank you
< >
Showing 1-13 of 13 comments
Per page: 1530 50