Hello! I'm looking to use your framework to add some stuff to one of my mods, and I encountered some bugs when I tried loading the example you gave us. I only managed to fix 2 of the 3 issues.

First, the bugs I fixed are a warning that appears regarding the about file, and an error relating to the progressTrackers file.

The about file warning I was able to solve by updating the dependency to this code
<li>
<packageId>Zomuro.ItsSorcery</packageId>
<displayName>It's Sorcery</displayName>
<steamWorkshopUrl>https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3013487115</steamWorkshopUrl>
</li>

And in progress trackers, it gives errors about ProgressTracker_RPG not being valid, but when I switched them to ProgressTracker_Level, the errors went away.


The error I couldn't solve is technically 3 errors, but they are 3 variations of the same thing:

XML error: <bgPath>UI/LearningTracker/Logos</bgPath> doesn't correspond to any field in type LearningTrackerDef. Context: <ItsSorceryFramework.LearningTrackerDef ParentName="LearningTrackerProgress"><learningTrackerClass>ItsSorceryFramework.LearningTracker_Progress</learningTrackerClass><defName>ISFE_LearningTrackerProgress_Logos</defName><label>learning progress</label><bgPath>UI/LearningTracker/Logos</bgPath></ItsSorceryFramework.LearningTrackerDef>

Originally posted by alite:

Hello! I'm looking to use your framework to add some stuff to one of my mods, and I encountered some bugs when I tried loading the example you gave us. I only managed to fix 2 of the 3 issues.

First, the bugs I fixed are a warning that appears regarding the about file, and an error relating to the progressTrackers file.

The about file warning I was able to solve by updating the dependency to this code
<li>
<packageId>Zomuro.ItsSorcery</packageId>
<displayName>It's Sorcery</displayName>
<steamWorkshopUrl>https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3013487115</steamWorkshopUrl>
</li>

And in progress trackers, it gives errors about ProgressTracker_RPG not being valid, but when I switched them to ProgressTracker_Level, the errors went away.


The error I couldn't solve is technically 3 errors, but they are 3 variations of the same thing:

XML error: <bgPath>UI/LearningTracker/Logos</bgPath> doesn't correspond to any field in type LearningTrackerDef. Context: <ItsSorceryFramework.LearningTrackerDef ParentName="LearningTrackerProgress"><learningTrackerClass>ItsSorceryFramework.LearningTracker_Progress</learningTrackerClass><defName>ISFE_LearningTrackerProgress_Logos</defName><label>learning progress</label><bgPath>UI/LearningTracker/Logos</bgPath></ItsSorceryFramework.LearningTrackerDef>

Noted, I'll have to update the repo with those fixes and see what's going on with all of them

Fixed- I did a forgor for the example mod, and forgot to merge branch changes that should fix everything back onto the main branch.

Thank you for catching the workshop ID on the aboutme!

Glad I could help! Looking forward to messing with this framework some. I'll let you know if I find any other issues.

ok so potential bug discovered, it seems like this framework completely breaks the context menu with Humanoid Alien Races. With a modlist only with harmony, all DLC, It's Sorcery!, HAR, de-generalize work, Kurin HAR edition, Dragonian prime race2.0 (steam page is called Dragonian primus,) Yuran race, NewRatkinPlus[1.5], and Miho, the celestial fox, I am completely unable to give move orders to drafted HAR pawns, and unable to open the context menu with them. Humans are all completely fine, i can order them to move when drafted, and i can open the context menu with them as usual. Will test again with no DLC just in case. The error sent to the log is as below:

Error trying to make float menu for Stranger: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 75F809B3]
at ItsSorceryFramework.HarmonyPatches.AddHumanlikeOrders_EXPUseItem (UnityEngine.Vector3 __0, Verse.Pawn __1, System.Collections.Generic.List`1[T] __2) [0x0001b] in <b56a4e941bc3478a91a8f1cb404a503a>:0
at RimWorld.FloatMenuMakerMap.AddHumanlikeOrders (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Collections.Generic.List`1[T] opts) [0x0703b] in <9b17790b066e46d08be4026d65926375>:0
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EnergyTrackerComp_OnConsume(Vector3 __0, Pawn __1, List`1 __2)
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EXPUseItem(Vector3 __0, Pawn __1, List`1 __2)
at RimWorld.FloatMenuMakerMap.ChoicesAtFor (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Boolean suppressAutoTakeableGoto) [0x000ae] in <9b17790b066e46d08be4026d65926375>:0
at RimWorld.FloatMenuMakerMap.TryMakeFloatMenu (Verse.Pawn pawn) [0x000da] in <9b17790b066e46d08be4026d65926375>:0
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
RimWorld.FloatMenuMakerMap:TryMakeFloatMenu (Verse.Pawn)
RimWorld.Selector:HandleMapClicks ()
RimWorld.Selector:SelectorOnGUI ()
RimWorld.MapInterface:HandleLowPriorityInput ()
RimWorld.UIRoot_Play:UIRootOnGUI ()
Verse.Root:OnGUI ()

Got a nasty UI Bug...
If you play with a higher UI scaling, the tab to level up the schemes and abilities is not available to see / completely off the screen. Nothing can be selected because it isn't inside the screen.

If I change UI scale back to 1,0 everything works fine.
I usually play with UI scale of 2,0 because of my high resolution.
Modlist of course only the dependencies and all DLCs aswell as the example mod.

I can provide screenshots aswell if needed.

Originally posted by Error413PTL:

ok so potential bug discovered, it seems like this framework completely breaks the context menu with Humanoid Alien Races. With a modlist only with harmony, all DLC, It's Sorcery!, HAR, de-generalize work, Kurin HAR edition, Dragonian prime race2.0 (steam page is called Dragonian primus,) Yuran race, NewRatkinPlus[1.5], and Miho, the celestial fox, I am completely unable to give move orders to drafted HAR pawns, and unable to open the context menu with them. Humans are all completely fine, i can order them to move when drafted, and i can open the context menu with them as usual. Will test again with no DLC just in case. The error sent to the log is as below:

Error trying to make float menu for Stranger: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 75F809B3]
at ItsSorceryFramework.HarmonyPatches.AddHumanlikeOrders_EXPUseItem (UnityEngine.Vector3 __0, Verse.Pawn __1, System.Collections.Generic.List`1[T] __2) [0x0001b] in <b56a4e941bc3478a91a8f1cb404a503a>:0
at RimWorld.FloatMenuMakerMap.AddHumanlikeOrders (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Collections.Generic.List`1[T] opts) [0x0703b] in <9b17790b066e46d08be4026d65926375>:0
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EnergyTrackerComp_OnConsume(Vector3 __0, Pawn __1, List`1 __2)
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EXPUseItem(Vector3 __0, Pawn __1, List`1 __2)
at RimWorld.FloatMenuMakerMap.ChoicesAtFor (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Boolean suppressAutoTakeableGoto) [0x000ae] in <9b17790b066e46d08be4026d65926375>:0
at RimWorld.FloatMenuMakerMap.TryMakeFloatMenu (Verse.Pawn pawn) [0x000da] in <9b17790b066e46d08be4026d65926375>:0
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
RimWorld.FloatMenuMakerMap:TryMakeFloatMenu (Verse.Pawn)
RimWorld.Selector:HandleMapClicks ()
RimWorld.Selector:SelectorOnGUI ()
RimWorld.MapInterface:HandleLowPriorityInput ()
RimWorld.UIRoot_Play:UIRootOnGUI ()
Verse.Root:OnGUI ()

oh boooooooo
one of the updates i made for performance sake was to limit the comp only to humans (the racedef irrc)

but i believe HAR races aren't humans according to the racedef

i can fix the NRE error, but i'll have to figure out a solution to let other "races" besides human use this framework

Originally posted by Akenno:

Got a nasty UI Bug...
If you play with a higher UI scaling, the tab to level up the schemes and abilities is not available to see / completely off the screen. Nothing can be selected because it isn't inside the screen.

If I change UI scale back to 1,0 everything works fine.
I usually play with UI scale of 2,0 because of my high resolution.
Modlist of course only the dependencies and all DLCs aswell as the example mod.

I can provide screenshots aswell if needed.

send screenshots

UI is agony

Originally posted by Zomuro:

Originally posted by Akenno:

Got a nasty UI Bug...
If you play with a higher UI scaling, the tab to level up the schemes and abilities is not available to see / completely off the screen. Nothing can be selected because it isn't inside the screen.

If I change UI scale back to 1,0 everything works fine.
I usually play with UI scale of 2,0 because of my high resolution.
Modlist of course only the dependencies and all DLCs aswell as the example mod.

I can provide screenshots aswell if needed.

send screenshots

UI is agony

Pictures are here:
https://imgur.com/a/s7is83K
1. is with 1.0 scale and second is with 2.0 scale (bug).


For the HAR bug:
Might be a player_pawn thing sense instead of a race? (Just a thought)

Originally posted by Akenno:

Originally posted by Zomuro:

send screenshots

UI is agony

Pictures are here:
https://imgur.com/a/s7is83K
1. is with 1.0 scale and second is with 2.0 scale (bug).


For the HAR bug:
Might be a player_pawn thing sense instead of a race? (Just a thought)

Okay, some further research results.

UI bug- the result of a funny thing (tm) i did with setting the window's initial size, so that it'd go end to end on the screen.

the HAR bug- there's definitely some funny patch business going on with HAR, so I'd have to know what the mod order looks like to figure out what's going on. HAR sets the human race def to its own racedef, which may be causing my patch to have issues.

Found the NRE issue in my harmony patch- whoops, rookie mistake

still will have to see about enabling the comp onto alien races via better patchwork

Originally posted by Zomuro:

Found the NRE issue in my harmony patch- whoops, rookie mistake

still will have to see about enabling the comp onto alien races via better patchwork

Thank you for the reply. I looked at the comments of this framework and the Cultivators of the Rim mod and didn't see anyone commenting about this conflict,so i just figured i should send the error log into this discussion, as for the mod order i believe it was as listed in my first post. I will re-type it here for clarity:

Harmony
Core
Royalty
Ideology
Biotech
Anomaly
It's Sorcery!
Humanoid Alien Races
De-generalize work
Kurin HAR Edition
Dragonian Prime race2.0
Yuran Race
NewRatkinPlus[1.5]
Miho, the celestial fox

Edited: I forgot to put Biotech into this list

Originally posted by Error413PTL:

Originally posted by Zomuro:

Found the NRE issue in my harmony patch- whoops, rookie mistake

still will have to see about enabling the comp onto alien races via better patchwork

Thank you for the reply. I looked at the comments of this framework and the Cultivators of the Rim mod and didn't see anyone commenting about this conflict,so i just figured i should send the error log into this discussion, as for the mod order i believe it was as listed in my first post. I will re-type it here for clarity:

Harmony
Core
Royalty
Ideology
Anomaly
It's Sorcery!
Humanoid Alien Races
De-generalize work
Kurin HAR Edition
Dragonian Prime race2.0
Yuran Race
NewRatkinPlus[1.5]
Miho, the celestial fox

now that's interesting- i was under the assumption It's Sorcery! would be after HAR. hoping the NRE fix will be enough. beyond that i'll need to check in w/ HAR devs for compat

Originally posted by Zomuro:

Originally posted by Error413PTL:

Thank you for the reply. I looked at the comments of this framework and the Cultivators of the Rim mod and didn't see anyone commenting about this conflict,so i just figured i should send the error log into this discussion, as for the mod order i believe it was as listed in my first post. I will re-type it here for clarity:

Harmony
Core
Royalty
Ideology
Anomaly
It's Sorcery!
Humanoid Alien Races
De-generalize work
Kurin HAR Edition
Dragonian Prime race2.0
Yuran Race
NewRatkinPlus[1.5]
Miho, the celestial fox

now that's interesting- i was under the assumption It's Sorcery! would be after HAR. hoping the NRE fix will be enough. beyond that i'll need to check in w/ HAR devs for compat

I will try the same mod load order again but swap HAR and It's Sorcery! to see if the same error pops up again or if something new happens

Edit after test: what appears to be the same error gets logged with HAR before It's Sorcery, shown below:


Error trying to make float menu for Bacon: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 75F809B3]
at ItsSorceryFramework.HarmonyPatches.AddHumanlikeOrders_EXPUseItem (UnityEngine.Vector3 __0, Verse.Pawn __1, System.Collections.Generic.List`1[T] __2) [0x0001b] in <b56a4e941bc3478a91a8f1cb404a503a>:0
at RimWorld.FloatMenuMakerMap.AddHumanlikeOrders (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Collections.Generic.List`1[T] opts) [0x0703b] in <9b17790b066e46d08be4026d65926375>:0
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EnergyTrackerComp_OnConsume(Vector3 __0, Pawn __1, List`1 __2)
- POSTFIX Zomuro.ItsSorcery.Framework: Void ItsSorceryFramework.HarmonyPatches:AddHumanlikeOrders_EXPUseItem(Vector3 __0, Pawn __1, List`1 __2)
at RimWorld.FloatMenuMakerMap.ChoicesAtFor (UnityEngine.Vector3 clickPos, Verse.Pawn pawn, System.Boolean suppressAutoTakeableGoto) [0x000ae] in <9b17790b066e46d08be4026d65926375>:0
at RimWorld.FloatMenuMakerMap.TryMakeFloatMenu (Verse.Pawn pawn) [0x000da] in <9b17790b066e46d08be4026d65926375>:0
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
RimWorld.FloatMenuMakerMap:TryMakeFloatMenu (Verse.Pawn)
RimWorld.Selector:HandleMapClicks ()
RimWorld.Selector:SelectorOnGUI ()
RimWorld.MapInterface:HandleLowPriorityInput ()
RimWorld.UIRoot_Play:UIRootOnGUI ()
Verse.Root:OnGUI ()

cool, that solves it i guess

one last thing- this is in 1.4 or 1.5?