Hey XiRiith, thanks for the feedback!

The first case does look like a genuine bug. I suspect it's something to do with the motorcycle in between the tile and the target. There's no way to tell from screenshots what the exact issue is. It may be a problem with the line of sight function, or it could be an issue with the motorcycle model blocking line of sight. I'll see if I can recreate the situation and then figure out what's going on.


The second case, surprising as it may seem, actually isn't a bug! It has to do with how line of sight and flanking is calculated. In the first three screenshots (LOS 10, 11, 12) the tile you would move to doesn't have a flanking position on the enemy because his "line of cover" is between the destination tile and the target. The bottom two screenshots do have a flanking position but for different reasons - in the first case, the tile is past the target's line of cover and so it has a natural flanking position (although you will get a "good angle" aim bonus). The second case doesn't have a natural flanking position but it does have a "peek" flank, which only happens if a unit is behind cover (between it and the target). In these cases your unit can actually step out into an adjacent tile to take their shot. So, if you moved your soldier to behind that plant, when they took a shot at the target they could step to the right and cross over the target's line of cover, which gives a flank.
Edit: Here's a pretty picture that hopefully explains it somewhat: http://images.akamai.steamusercontent.com/ugc/548682046882487319/3D8CE416A6FB8CFF7B1D753DE8EA52627B49D216/

Flanking and line of sight is a bit of a complicated topic, I know, but there's a great page on UFOpaedia that explains it: http://ufopaedia.org/index.php?title=Cover_%28EU2012%29#Flanking
The page is for XCOM: Enemy Unknown, but the mechanics haven't changed between that game and XCOM 2, so it's still all valid. The image to the right really helped me understand things (although it's a bit confusing at first).

I hope that explains things well enough, and I will definitly try to recreate the first scenario and see what's wrong. Thank you again for the post, this is exactly the kind of feedback I was hoping for to help us track down bugs! :)

I have your mod enabled and am looking forward to playing with it once it (eventually) decides to work. To clarify: if an enemy is flanked the mod should replace the red crosshairs next to the health bar with yellow crosshairs.

I am not seeing this in any of the games I am playing. Will this work for custom weapons such as popular packs like the hk416 or other weapons?

I have also checked the XComEngine.ini file and ensured that the line exists about implementing the mod that you suggested checking.

Thanks

I second SirDiesALots comment. This mod does not seem to work with my XCom 2 Installation. Nothing changes ...

@MachDelta ► Thx a lot for your answer and the picture you took the time to make. You learned me a lot. Your link is a bit tricky to understand but very helpful.

@SirDiesALot and bushd0c ► The mod does work, and is a must have. So the problems are on your side... sorry for that.

Hey guys, if you're still having trouble getting the mod to work, I'd reccomend this guide: https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=625230005
It seems to have worked for some other people. Config issues are proving to be a huge headache for mods not working so that's definitly where I would start. Do let me know if you're still having problems afterward though.

I must revise my silly comment... The Mod works flawlessly. Thx mate!

@XiRiith rather than on their side i think its inherent to Xcom, a lot of times i find LoS problems, like having my team on the roof of a building, no one near the ledges nor any holes in the floor, and while its the enemy's turn a patrol walks into the building and spots my concealed troops, with absolutely no line of sight.

And i've even seen some problems that aren't related to LoS, like enemies walking/teleporting through walls (which isn't directly related to the topic but im just bringing it up to reference that its not just LoS but even pathing that isn't properly acknowledged sometimes, so maybe the game sometimes "ignores" a wall is there or something)

@Klyem I agree. You misunderstood me : I said that because they were complaining about the mod itself. The mod works - 99 % of time ;-) see what the moder say himself -, but doesn't solve the bugs of XCom2... which for some are the same as XEU/XEW, which is a shame...

@MachDelta Great explaination about cover and Line of Sight! And thanks for the great mod, it works very well for me.

there is a bug that the indicator shows the enemy will be flanked but he is not flanked if i move there. This seems only to be if i move to the position that is one tile of the real flanking position away.

also the indicator for hack objective was not true for my specialist to remote hack. Maybe this is of the new alien hunter dlc??