X Rebirth

X Rebirth

Faster Capital Ships
SkyWølf 9. mar. 2017 kl. 12:42
Hermod and Titurel (bug)
Great mod! I really love the faster cap ships.

I've found two minor issues though:

The Hermod is not 50% faster because it actually uses 3 types of engines. You patched the engine_size_l_freighter_liquid_01_macro but missed engine_ship_l_liquid_freighter_bottom_macro and engine_ship_l_liquid_freighter_top_macro.

The Titruel still has bugged engines with different speeds in the base and is thus much slower than it should be. There is mod by nidaren (Titurel Engine Fix) that fixes this issue but doesn't have the 50% speed/mobility increase.

Would you incorporate the fix or allow me to create a version that includes the fix? Giving the necessary credit to you and nidaren of course. Nidaren already gave me his permission.
< >
Viser 1-5 af 5 kommentarer
Melody Woods  [udvikler] 12. mar. 2017 kl. 4:15 
@skywolf Thanks, I'll look into this and see if I can fix it and update it. Also, certainly, I would like to incorporate a Titurel Engine Fix. Perhaps you could help me to incorporate that fix, send me the files, and update this mod together.
Sidst redigeret af Melody Woods; 27. mar. 2017 kl. 12:32
SkyWølf 12. mar. 2017 kl. 9:02 
Sure no problem,
I already have a private version that includes both changes. For the titurel fix I used a different method then nidaren, though. Nidaren used a clean approach and created new fixed engines to replace the old ones, which mean it only works on newly spawned/build Titurels. He did this because the old ones are also used in the "Super-Freighter" which never made it into the base game. I think it's very unlikely that it will ever make it into the game at this point. So I just patched the original engines for the benefit of working with existing Titurels. But I can do the clean variant as well if you prefer.

I send you a friend invite so we can exchange info on how to send the files.

nidaren 19. mar. 2017 kl. 12:36 
Hey Guys,

Actually, it was possible to patch all the exisiting titurels even with new engine clean approach. However now in version 4.1+ patch_macros behaves a bit differently. I am still tracking the issue causing old engines to still be preserved in the save file.

Once the mod is updated, I would recommend mentioning it in dependancies (that will download my mod together with your mod), rather than integrating it directly, it makes compatibility better.

In the current game build, my old mod does not work. It preserves the old engines in the save file and while them not being visible, they still work and operate even when new ones are destroyed. It is the effect of the patch_macros not working properly. This bug affects only existing save games, also when you just edit the properties of the old ones! On a new ones all will work as it supposed to.

Bests,

nid
Sidst redigeret af nidaren; 19. mar. 2017 kl. 12:38
nidaren 19. mar. 2017 kl. 14:55 
UPDATE:

Hey Guys,

I have managed to fix all the problems in the mod. Culprit was the changed logic of patch_macro and patch_macros is 4.0+.

Should you like to integrate your mod, the best way to do it use content.xml and dependancy.

Just add the line below to your content.xml, it will ensure users download my mod while getting yours. Manually adding files should not be needed anymore. Mod will clean up all the old/broken Titurels when found.

It updates existing savegames safely and properly.

<dependency id="ws_249312552" />

Have fun!

-nid



Sidst redigeret af nidaren; 19. mar. 2017 kl. 14:56
Melody Woods  [udvikler] 21. mar. 2017 kl. 2:35 
Thanks, but I do not want the mod to depend on other mods. I would rather delete the "titurel fix" part and patch the original engines. Adding a dependency would be useless, since it lacks the increase to speed and aceleration. The mod is working fine at the moment. If some issue appears in the future, I will make the change.

Regards.
Sidst redigeret af Melody Woods; 27. mar. 2017 kl. 12:31
< >
Viser 1-5 af 5 kommentarer
Per side: 1530 50