I'll remove it. As my mod had no changes in ages, maybe ask the other mod authors first in future. If they don't care, why should I?

P.S.: the check has been changed to body size as FS also works on animals, and the C&P age can be changed by the user. So not a very reliable indicator, is it?

The last update from C&P I encountered was an additional patch, which is executed before FS (by intent) to cancel my needed checks, so I cannot execute the needed checks--the updated code took me five evenings and were plain useless as lasting for a day or so only.

I see your point, and I absolutely agree with you. Thank you for your answer.

Originally posted by Killface:

I'll remove it. As my mod had no changes in ages, maybe ask the other mod authors first in future. If they don't care, why should I?

P.S.: the check has been changed to body size as FS also works on animals, and the C&P age can be changed by the user. So not a very reliable indicator, is it?

The last update from C&P I encountered was an additional patch, which is executed before FS (by intent) to cancel my needed checks, so I cannot execute the needed checks--the updated code took me five evenings and were plain useless as lasting for a day or so only.

So is there nothing that we can do to make the mod ignore children, or render well on them? Perhaps facial features can scale with age like pawn bodies do? Just throwing out some ideas. Forgive me if they sound stupid.

As Killface said, it's C&P that breaks Facial Stuff, so I asked in the Ludeon forums post where Tragix is maintaining and updating the mod:

______________________

Me: I know this has probably already been discussed, but is there any chance that this mod will be compatible with Facial Stuff?

The author has made it clear that he will no longer work on compatibility issues. He says both mods are no longer compatible because of a patch introduced by C&P, which cancels certain Facial Stuff checks.

Also, in case this is useful, it is no longer the age but the size of the pawn that determines if Facial Stuff should render the head or not.

___________________

Tragix: I'll look into it when I have time. If it's just something we're patching that's causing it not to work, I'll see what I can do to fix that. It is a difficult line to draw as to which mod should support the other. Both add a new feature that reduces the functionality of the other if not patched, so it could technically make sense for either mod to provide that support. I am being careful to follow a general policy of "If it could work with CNP without patches, don't break it further" and so will fix any errors I cause to that end. I don't want to fall into the trap of providing CNP-side support for every mod out there.
HAR is a notable exception because I personally feel that alien race support is vital to a mod like CNP. It might not be perfect at the moment, but I do think it's important for the core purpose of CNP. Facial animations - not so much. And for babies and toddlers, there may not even be enough space on the pawn to display faces. In all cases, I have no plans to make "baby appropriate" graphics for body addons and similar.

@Sir Bitar: That was the plan. FS also supports animals in general, and as CNP users can change the age, I'd have no indication. I added a check for getting the body size, counting every pawn smaller than 100 % as a children and scaling the graphics accordingly.

@Capi: thank youfor asking Tragix.

Thank you both. Hopefully this will get resolved.

I'm writing here to avoid opening a new thread.

It doesn't look like we will have a solution to the compatibility problems with C&P and other mods soon. I respect and support 100% the decision not to maintain compatibility with mods that insist on breaking it every time they update.

Facial Stuff is so fantastic for me and I've become so used to using it that I prefer to keep it rather than keep something as (also) important to me in Rimworld as human offspring.

I'll get to the point, I have seen that it is quite simple to adjust the head offset and change other animation settings using the dev mode and Facial Stuff. Would it be too complicated to add a setting that would allow facial stuff render to be hidden in certain pawns? Even a function that would allow you to adjust the offset to an exorbitant amount would serve to hide the head.

It would be a quick fix that would work for all those mods that are not compatible with Facial Stuff.

Hai Capi, I've actually added a detector which should go off if a pawn is underage. I first used 14 as the limit, but as C&P allows players to set the child age to whatever they want, it's rather useless. Then I approached the body size to trigger FS (and use it for scaling & positioning), but in the mean time C&P has add an annotation to the RenderPawnInternal method to be run first. Long story short, as with my last edits to the source code, FS has a detection to ignore children, but it's not triggered. So basically FS should skip the pawn, haven't started RW in a while to confirm.
I'll see what I can do.

//Edit: realized that I've meant the Children School and Learning mod. I've mistaken it with Children & Pregnancy.

So how it is looking ?
May I ask you a question Killface ? How did you manage to compile the dll when Visual Studio is showing me like thousand of errors ? I tried to decomplie the latest dll and the one I have from start of 2020 and check them in WinMerge program. I added the few lines of the code back to the latest dll file and when I was trying to compile the file back in Visual Studio it is not working at all :D So many errors. ( and those errors are there even if I remove the code that I added :D )

Anyway I would like to tell you that I was trying to do some checks and debugging. And it is interesting that when I put your old dll file that I have from like start of 2020 the kids are showing without any big hads or hands or feet. They look normal.



So looks like the compatibility is till there and the code :

// compFace.IsChild = pawn.ageTracker.AgeBiologicalYearsFloat < 14;

Is still working for the CHILDREN AND PREGNANCY mod ( to not mix it with the CSL mod ).

Is there any chance from your side to try and add that line a few more lines back to your dll file ?


Thank you in advance.

Hey Jozvin. Are you sure that compatibility with Children and Pregnancy is active? I had no luck with either mod.

I was so desperate that I finally made a fork of Facial Stuff.
I simply deleted the two types of eyes and eyebrows I liked the least and left them transparent so I can edit the baby pawns and assign that style of eyes and eyebrows to them.

I've also made a fork of Children and Pregnacy because all the textures in the mod are of horrible quality, so I've made new ones from scratch.

Unfortunately I don't intend to publish either of the two mods, as I don't have permission from either of the authors and it's a suboptimal and shoddy solution.

Originally posted by Capi:

Hey Jozvin. Are you sure that compatibility with Children and Pregnancy is active? I had no luck with either mod.

I was so desperate that I finally made a fork of Facial Stuff.
I simply deleted the two types of eyes and eyebrows I liked the least and left them transparent so I can edit the baby pawns and assign that style of eyes and eyebrows to them.

I've also made a fork of Children and Pregnacy because all the textures in the mod are of horrible quality, so I've made new ones from scratch.

Unfortunately I don't intend to publish either of the two mods, as I don't have permission from either of the authors and it's a suboptimal and shoddy solution.

Hello Capi,
As I wrote you in chat.
Yes I am using the latest version of Children and Pregnancy mod with the hmm latest version of Facial Stuff but with DLLs from 02/2020 before the Killface removed those few lines of code that were there.

And only issue or errors I have in log is due to ears not possible to find them in XML or sometihing like this which is not a big problem.

Wau I must say looks like you are much better at coding than me. I must say I know a bit of python but C# never touched it in my life.

And I am trying to somehow compile that current Facial Stuff dll with the lines from that 02/2020 DLL taht are managing that there will be no rendering of Facial Stuff on kids but Visual Studio is giving me so much errors. I really do now know how Killface managed to ignore or supress all those errors and compile the dll. So right now I am stuck at this point. But I just joined the RimWorld discord channel and I am plannign to get help there how to compile that dll.


Btw woud love to see those new textures from you for Children and Pregnancy I must say.

Originally posted by Capi:

Hey Jozvin. Are you sure that compatibility with Children and Pregnancy is active? I had no luck with either mod.

I was so desperate that I finally made a fork of Facial Stuff.
I simply deleted the two types of eyes and eyebrows I liked the least and left them transparent so I can edit the baby pawns and assign that style of eyes and eyebrows to them.

I've also made a fork of Children and Pregnacy because all the textures in the mod are of horrible quality, so I've made new ones from scratch.

Unfortunately I don't intend to publish either of the two mods, as I don't have permission from either of the authors and it's a suboptimal and shoddy solution.

Any chance you'd be willing to share your versions of these privately? I'd love to have something like that in my game.