Subscribe to download
Simple Sidearms Fire Extinguisher Fix

@akervio

Its in the pipeline.

1.1? POR FAVOR

Thanks for the patch dude .

Ah. I guess I've been away from modding too long, I did not realize PatchOperationFindMod had made it into vanilla.

@Tyrant

Also if I wanted to just simply check if a mod is loaded in C# to warn the user about the lack of another mod then there are techniques in the code to do this that do not require the use of ModCheck.

At present I don't really see that it cannot be handled as an "educative" process, that the relevant mods can make people aware that this "temporary" fix is available for use for the FEs with the use of SS.

It is also beneficial for version control, since if the original author of SS decides to fix or provide an update, then the players have immediate version control with the use of this expansion mod or not, for various reasons (e.g. compatibility maintenance with upgrades in SS for continuity, removal with the intended outcome of a fix in SS being incorporated). If it was integrated then those dependencies with version control are then also reliant on the FE mods also updating.

@Tyrant

If it were just an XML solution to incorporate into a mod I would just use the vanilla "PatchOperationFindMod" technique, rather than have a dependency on another assembly that isn't needed.

But as it is a C# Harmony fix to the assemblies in Simple Sidearms (originally only intended as a temporary fix) that also requires those library additions from SS for the code to work, then it is better to incorporate as an expansion mod imho. (It is "cleaner" as an isolated addition).

(NB: I realise it could be integrated with a try catch exception handling method in C# but am unsure if that technique can be incorporated into the harmony syntax, though tbh I have never tried that to see if it is feasible.)

You should integrate the Fire Extinguisher compatibility portion into the Fire Extinguisher mod by including the ModCheck binary. https://github.com/Nightinggale/ModCheck#how-to-install

Then this mod can just be a Vanilla Weapons Expanded patch, although ideally, that mod author should do the same with theirs.

@Update

Compatibility for Vanilla Weapons Expanded.

Yup it now works perfectly just wanted to share the little anecdote as a way to say thanks its really needed ^^

@AC.Seth

Been waiting for the Author of Simple Sidearms to return to active modding to help support his mod and enact a permanent fix for this, since it was reported and a request placed for SS to ignore non-lethal weapons like the FE.

Came to the conclusion that this may be some time, so this mod will act as a "buffer" to the above as a temporary fix to avoid unwanted micro-management with the FE.