Subscribe to download
Door Outlines Mod

holy skill issue

I cant believe people could have to audacity to install literal wallhacks on tboi, smh my head

memphis maybe try reading the description of a mod before bitching in the comments?

@memphis it just puts the outline of a door where doors could be, not where the secret room is, but in places where a room could generate

mod for fatherless cheaters lol

@agentcucco thanks for your advice, it's really helpful! I've done my best to incorporate it into the mod

I will probably delete those if you ping me, to avoid cluttering the chat, but generally the biggest "issues" are the lack of use of enumerations, and overuse of "magic numbers", if you're using static values for anything at all, it's always best to define them as a constant at the top of your file (if the enums.lua doesn't provide them already).

4. You made a custom distance function which is kinda funny, it's not bad perse, but Vector.Distance/DistanceSquared() already exist (i.e. player.Position:Distance(door.Position)). math.sqrt is also a really taxy method, it is adviced you use ^0.5 instead, when working in LUA, don't ask why, the math function is just scuffed, lol.

5. This is truly a personal nitpick and not a real issue, but when checking for variables, it's good to keep this in mind:
'if x then' // 'if x == true or x ~= nil then'
'if not x then' // 'if x == false or x == nil then'
These terms are generally more readable when (and faster to write) when you have more experience coding.

A few nitpicks I found while checking the source:

1. You are barely using enumerations (i.e. typing Isaac.Spawn(1000, ...) instead of Isaac.Spawn(EntityType.ENTITY_EFFECT, ...)), this makes the code pretty unreadable and specially if you start making custom stuff, it might cause issues with dynamic ids and whatnot.

2. On the topic of readability, some of your statements get pretty long, generally it's best to keep each check in its own line.
i.e. 'if x and y then' to
'if x'
'and y'
'then'

3. In this case it doesn't matter, but it's generally a bad practice to define static objects more than once, in your case you're defining a Color every time you spawn an outline, but the color is always the same, so really there's no reason not to define it at the top of your code as a constant.

@agentcucco Haha don't worry about it.

Ok I've now defined the json library, thank you for pointing that out. I'm pretty new to modding, Isaac or otherwise, so your help is much appreciated.