Subscribe to download
Signs and Memorials

Uploaded the fixed 1.1 version to steam and will try to keep it updated.
https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2071681396
Hope this helps anyone!

When you add someone as a contributor you can tweak what they're allowed todo including updates etc.

Hi everyone, I just saw these comments and I just want to add, since I don't see me maintaining this any longer, I would be totally happy if anyone put up the new code on the workshop, hit me up and I will mark this ans invisible/deprecated and/or link to your submission.

Also big thanks @jtgibson, I really appreciate that you stepped up to this. I would be happy to add you as a contributor if you want (I /think/hope/ that would allow you to push updates yourself but I actually don't know too much about the steam workshop so ¯\_(ツ)_/¯)

1.1 build is now up there, too! I have less than zero inclination to upload to Steam Workshop -- my sole interaction with the WS is to download, rename, and copy loose into the Mods folder of my Ludeon/SendOwl copy -- and I don't want to step on the author's toes any more than I already have.

@_hmm: You have unlimited and full permission to take any content added in my fork, without credit. All contributions I have made are covered by the original MIT licence and can be considered to be as permissive as the public domain.

If anyone else wants to upload my fork in their own name, be my guest, but link to this page and give due credit to the original author, please!

Cheers!

Okeydokey! Looks like everything is more or less ready to roll. I'm going to have to upgrade to 1.1 to push a 1.1 build too (which I am *not* looking forward to; I'm running over 400 mods on 1.0!), but the 1.0 build is done and available for anyone at https://github.com/jtgibson01/RimWorld-Signs_and_Memorials/

Verified fixed the crash-on-load, while still retaining the mod settings (and sneaking in one more as a thank you for the mod... =)). Slipped in a French translation too because why the heck not, I had to translate some new mod settings anyway.

Still running a few last tests on the save-load routine, and I switched over to RimWorld's built-in zlib CompressUtility compression on it, since it was nearly tripling the saved bytes for a decent-sized memorial (590 bytes of base-64-encoded UTF-16 versus 221 bytes of UTF-8 -- the same string now encodes at 264 bytes), but everything seems to be working great now!

I also tweaked the perspective on the memorial, added perspective to the sign, and rastered at higher res so you can actually see that there's printed characters on the memorials and signs (I had no idea until I pulled up your vectors in Inkscape!).

Once I've run a thorough test, I'll try submitting a PR via a Github fork.

Running the old version and having no idea that this was updated, I looked into your pre-September source code and noticed the smoking gun that caused your trouble: rather than saving a static reference to your settings instance (and assigning that reference in your mod settings' constructor), you were instantiating and saving a reference to the mod settings in every single instance of your "SaM.Base" Building (Thing). To put it mildly, that was not quite the way to go about it. =)

I made a few other improvements on a quick pass through the source code, including serialising the saved data to base64 rather than reading/writing directly -- saving raw user-enterable strings makes save/load errors far more likely, especially if the user inadvertently uses a character that the save/load routine can't read. A user writing something like <YES> would also brick a savefile, for instance, since RimWorld would read it as XML.

Sounds like a fun mod. We need a tombstone and wall version of this xD

after some more great feedback there has been another update, which again, may (this time I'm a little more confident, but I know best how that is not a great indicator) fix this issue where saves became impossible to load with this mod enabled. If you had/have that issue simply removing the mod should allow you to load the world, without the stuffs though. Or this update really fixes it and it simply works.