Added several new events in dp_char_editor.txt ranging from .13-.15 and .62-.66
These new events implement three new menus of traits that were previously missing from the character editor. These new menus include infamy, lifestyle, and lifestyle perk traits.

The full list of traits that were added follows:

• Adulterer
  
• Fornicator
  
• Deviant
  
• Dynastic Kinslayer
  
• Familial Kinslayer
  
• Kinslayer
  
• Incestuous
  
• Sodomite
  
• Witch
  
• Cannibal
  
• Excommunicated
  
• Murderer

• August
  
• Diplomat
  
• Patriarch / Matriarch
  
• Gallant
  
• Overseer
  
• Strategist
  
• Administrator
  
• Architect
  
• Avaricious
  
• Schemer
  
• Seducer / Seductress
  
• Torturer
  
• Scholar
  
• Theologian
  
• Whole of Body

• Celibate
  
• Herbalist
  
• Gardener
  
• Aspiring Blademaster
  
• Eager Reveler
  
• Novice Physician
  
• Pilgrim
  
• Wise Man / Woman
  
• Hunter
  
• Traveler
  
• Hastiluder

In the process of completely re-working the entire traits menu of the character editor in order to make it utilize the same page system the modifier menu uses. So far, the first traits menu has forward and backward buttons, in case someone wanted to add more pages of traits, I'm thinking about if someone wanted to add a bunch of mod traits or something.

Next up is the personality traits menu, which has been completely redone from the ground up, with the new page system replacing the old. I also added a few scripted effects under LIT_scripted_effects.txt to streamline the adding and removing of traits, no need to do any checks, just feed the trait you want to attempt to add or remove into LIT_trait_check and it will add it, or remove it if you already have it.

The second scripted effect will check if the opposite personality trait is applied, and remove it if necessary, then add your own trait. This effect is embedded in the personality trait check already, now allowing you to just click on the trait you want, and it will automatically remove the opposite trait if you have it, before adding the one you wanted. This functionality was lacking with the original system.

Fixed the issue from the previous change note across all localizations files.

Fixed

• owned_personal_scheme_success_chance
  
• owned_hostile_scheme_success_chance
  
• enemy_personal_scheme_success_chance
  
• enemy_hostile_scheme_success_chance
  Each was swapped in various places in the code, importantly the dp_char_editor.txt add_character_flag section for each, where personal and hostile were flipped around. You would click the modifier to get personal and it would give you hostile, the localization entries were also flipped around. This was also the case with the negative localization for each entry.
  
• owned_hostile_scheme_success_chance_neg
  
• owned_personal_scheme_success_chance_neg
  
• enemy_hostile_scheme_success_chance_neg
  
• enemy_personal_scheme_success_chance_neg

Commented out everything related to 5 modifiers in DP_modifiers.txt including their negative form (add _neg to each)
Specifically:
scheme_power
scheme_resistance
scheme_secrecy
scheme_success_chance
mercenary_count_mult

Anywhere I found these in the file structure they were commented out. They were all throwing error codes for mismatched type and were non-functional in game. The scheme ones in particular are modifiers that apply directly to a scheme, so trying to apply them to a character is an error.

The modifier page option overflow should be truly squashed at this point, even if you somehow manage to get multiple pages being called at once, you can now pick an option that you can see and hit finish editing to clear the pages, so it should be impossible to get stuck like before.

Expanded the remove_all_go_back_event_flags to include checking for all the available modifier pages and remove them. Moved the effect from the DP_modifier_effects.txt to DP_general_page_effects.txt as it makes more sense to be there.

Also commented out the various modifier page removal effects that were found outside of remove_all_go_back_event_flags as they would have been redundant.

Edited every entry under remove_all_modifier_instances in DP_modifier_effects.txt to include a second remove_all_character_modifier_instances effect that removes the negative modifier.

Without this change, hitting the reset button in a given modifier screen would only remove the positive modifier, ignoring the negative.

Commented out untarget_character in character_interactions as it's unused. Fixed a typo in modifiers that was likely causing an issue with reducing knight limit via modifier.

Fixed culture and religion pages in character editor that were overflowing off the event window causing soft lock when editing a character other than the player.

The problem was a simple scope issue in dp_char_editor.txt fixed by adding scope:char_editor to remove_religion_pgs and remove_culture_pgs when called in main_menu option of each event.