Making a comment to make this more visible. I'll no longer be providing updates going forward. See the mod description for sightly more info.

Cheers, updated and added.

The PUC suit is also not able to use the oxygen and oxygenite tanks.

Found a possible bug. Both the unlimited oxygen tank and oxygenite tank do not work with the Slip Suit Diving Suit. The combat, normal, and abyss diving suit works fine still.

Update pushed! Thanks for pointing it out. If other oxygen related new items were added I'm unaware, let me know and I'll add them.

I put items in files named the same as the vanilla files, so I can find them after updates.

Make a new xml file, name it whatever, add opening <Override> <Items> tags, leave some blank lines, make closing </Items> </Override> tags, then put your <Item> ... </Item> in between. You can have multiple items, items from different files, doesn't matter.. Add your new file to filelist.xml, making sure to duplicate one of the existing lines starting with Item, save, should be right to go.

Okay, I would love to review how you get it to work since i couldnt figure it out I may just be a noob with no knowledge and using examples didnt work so hopefully seeing the correction will :)

Thanks. I'll update in a few minutes anyhow, hold tight.

@Tommo I found it here \Content\Items\Jobgear\Assistant\assistant_talent_items.xml
I added copied the entire code to an xml named same thing into your mod folder to try and make a patch in a set location but when I added it as you said basically copied your files but deleted all items and pasted in the clown mask code adding the contain items and status effect but nothing worked it seems

@Emlorp I didn't know there was a clown mask that could take oxygen bottles, how long has that been in the game?. Where is it in the files, I couldn't find it after a brief look.

If you've made a new .xml file, you need to add it to filelist.xml in the mod's base directory. Copy one of the existing lines that ends in .xml, paste it anywhere in that list on its own line, change the name to match your new file.

@Spartan Draco The first version of this mod didn't have special oxygen bottles, it had red diving suits that were new items therefore didn't overwrite the vanilla ones. It was cumbersome, if you left one normal suit for yourself and replaced the others for bots, bots could still take it. That ended like... a year ago? IDK, it's been a while.

Edit: I found the item but when trying to make an override to add the items the game doesnt seem to load the new xml if i drop it into your mod package

This doesnt seem to work for Clown Diving Mask.. I tried to find where the item information is to manually edit but failed to locate it. do you possibly know where it is or how to create a patch for the mask without copying its whole code and then adding additional oxygen sources?

The problem is that it also affects the armor of the base game if they have changed skins, you can put the bottle but it does not use it, I have a mod that only changes the skin and this causes that it does not work, in its day I used the mod of doom with this one and it worked, no longer

Mods need to be modified to make use of the unlimited bottles.

It's due to how Barotrauma modding works. Maintaining compatibility with other mods is a pain, I don't want to do it.

I don't mind if people make their own compatibility patches or add compatibility with these bottles into their mods.

Instructions for how to make items compatible with the new bottles can be found in the comments, around 8th September 2021.

It's very easy to make the changes, maintaining them is the problem.

not work for armours mods, why? i don't know, i need this for bots, but not work in armours

This should be an official setting in the game for singleplayer and as a toggle for the multiplayer host, it's really useful. Hopefully the devs consider adding an infinite oxygen toggle for npc's some time.

Thanks for creating a mod like this!

Thx for the explanation - and yes it works fine now, sorry for wasting your time.

How long an oxygen source lasts is defined on the diving suits, every source needs an entry to say it provides oxygen and the consumption rate while in the slot.

If that mod changes an oxygen source, it would change the diving suits as well, which is overwriting the changes my mod makes to diving suits to give oxygen and at what rate.

The suit would still be able to accept my bottles (because they're a generic oxygen source so they're allowed the slot), but you'd immediately suffocate because the code telling the game this bottle in this suit provides oxygen is overwritten by the other mod telling the game their item in this suit provides oxygen.

Hm yeah i had a mod for oxygenite crystals which did pretty much the same (according to the description).
I think i had it deactivated the last time i tried your mod but i try it again and let you know if it works.

Thx anyways for the hint - thought it changes the item (oxygen tank) and not the diving suit.

Do you use any other mods that effect diving suits? That's the most common issue, baro mods don't play well with each other.

Does not work for me, neither if i craft and fill it nor if i buy it - after putting it in a diving suit and wear it i get immediatly the oxygen warning and the screen starts to get blurry.

thanks

Should be good now.

Doesn't work correctly for me. Putting on the diving suit, the console pops up with an error. Missing some kind of sprite.

Fixed with copying reg_DivingSuit.png from Barotrauma\Content\Items\Diving into mod dir.

Updated for AtA. Just value updates to match vanilla changes for suit armour and welder use.

thankyou, i fixed, i modify the bos diving xml, all file put you item in they xml

<StatusEffect type="OnWearing" target="Contained,Character" OxygenAvailable="1000.0" Condition="-0.0" comparison="Or">
<Conditional IsDead="false" />
<RequiredItem items="oxygentankunlimited" type="Contained" />
</StatusEffect>
<StatusEffect type="OnWearing" target="Contained,Character" OxygenAvailable="1500.0" Condition="-0.0" comparison="Or">
<Conditional IsDead="false" />
<RequiredItem items="oxygenitetankunlimited" type="Contained" />
</StatusEffect>
<StatusEffect type="OnWearing" target="Contained,Character" SpeedMultiplier="1.3" setvalue="true" comparison="Or">
<Conditional IsDead="false" />
<RequiredItem items="oxygenitetankunlimited" type="Contained" />
</StatusEffect>

yes, i using [BOS]Diving and EK : Utility, if i want working with other moded Diving suit, which file can i modify?

Are you using any other mods that modify diving suits? Still works for me, but I only tested normal diving suits with unlimited bottles. The AI kept them on and followed me outside the ship.

not working at ai, they keeping put the suit down and up

oh thank god for a second I thought I'd have to update

I had a conflict with [BOS]Diving

Unlimited oxygen will no longer work properly on the wetsuit

I see, thanks. I'd probably deactivate rather the other mod. For now the bots seem to be able to survive when the pathing isn't all fucked but you never now.

Copy the StatusEffect tags, making sure to also copy the closing </StatusEffect> tag for each one.

Paste them at the end of the StatusEffect blocks in the divinggear.xml of whichever mod is top dog for each item.

The other mod might not use divinggear.xml, but somewhere in the mod there will a .xml file with those items defined, just look for the matching item identifier.

This step I don't think is needed but just in case

You may need to edit the <Containable items...> tag for each piece of diving gear. You need to add my oxygen bottles to the other mod, so the game knows the bottles can go inside. I think

e.g. <Containable items="oxygensource,weldingtoolfuel,oxygentankunlimited,oxygenitetankunlimited" />

It will be a mod conflict. I'm not willing to make or maintain compatibility patches for individual mods, but I don't mind if people do make them for themselves or others.

A few lines of copy and paste will get you going, copy from this mod to whatever mod is top dog in your load order. I think if you hover over the items in game it now tells you what mod it's loading from.

Open up this mod's files, open divinggear.xml.

Note each item has an identifier, the first is "divingmask".

Each item will have a block of <StatusEffect ... > tags. Look for the three towards the end of the divingmask item that have a <RequiredItem items="oxygenitetankunlimited" or "oxygentankunlimited".

I got the unlimited bottles. For mods I have the "brighter lights" one, which might change suits some? And EK Utilities, but not that I know any changes to suits from that one.

What specifically doesn't work? I just tested and it is working for the player-controlled character.

Do you run any mods that change the vanilla diving suits? Did you buy the special unlimited bottles?

Doesn't work. At least not for the player-controlled character.

Thank you Tommo!

Had some time and some inlking so updated much earlier than expected. I think it's all good, let me know if anything broke.

Huuuuuuuh I just assumed Steam would notify me if there were comments on my mod. I haven't played Baro in months, I'll see what I can do in the next few days.

Yep no pressure protection from regular diving suit

yeah, unlimited oxygen kinda works... but now diving suit won't provide pressure protection, and combat and abyss variant won't accept unlimited oxygen tank. So this mod can't be used for now. need update.

Thank you CABBAGE!

this is causing pressure damage after the new update.

This mod is great for my casual experience. Thank you for your time. Can you add Unlimitted batteries too please?

Hi Pile of Bees. I have no plans to make compatibility with other mods. I don't play Baro anymore, I'll support this mod if the game updates, but I don't want to be supporting more than that.

If you have a look at the files for this mod and the transparent diving suit mod, you'd be able to see what to do to make a compatibility mod. Look at divinggear.xml in this mod, look at status effects for each respirator/suit. The transparent diving suits need the appropriate status effects added for each of the unlimited bottles, and the unlimited bottles added to the containable items list.

this mod isnt compatible with transparent diving suit mod :(
can there be a fix?

nice. now i can take npcs on my diving crusade to the nests

The bottles should be in a crate somewhere on your ship after you undock, like any other purchased supplies. I haven't played Baro for a long while myself but I just had a quick test with the Dugong and it's working.

I am having an issue where I purchase the bottles but cannot locate them on my ship. Are they stored somewhere specific?