I looked at the code for this mod vs the base file, it looks like it's still needed.

Is this still a problem?

Is this still a problem?

How did this not get fixed in 2.0...

Tbh, I am waiting for 2.0, if they don't fix it by themselves by then I will drop a line to them

Caellion, if you're still playing, you can also use the in-game "Report a bug" feature and just describe which file and line. I've done it like this a few times myself.

@Caellion

I do not know about a pull-request page however there is a forum that is linked in the top right of the Avorion.net page.

The forums themselves can be found at forum.avorion.net

Hope that helps!

@_DrunkenGibberish_

Do you know anyplace I could fill a pullrequest ar a real bug report?
I don't even see any forum link on official website...

Maybe you could submit this to the Devs as a bug fix? Coding is hard enough with small projects but something as big as Avorion with only a small team and things start to slip by.

This could help them by saving them the work time needed to develop a fix and instead they only need to implement it!

well, all that my fix really does is replace this:

local richAsteroids = sector:getNumEntitiesByComponent(ComponentType.MineableMaterial)

with this:

local richAsteroids = 0
local asteroids = {sector:getEntitiesByComponent(ComponentType.MineableMaterial)}

for i, asteroid in ipairs(asteroids) do
if asteroid.isAsteroid then
richAsteroids = richAsteroids + 1
end
end

Because sector:getNumEntitiesByComponent(ComponentType.MineableMaterial) can (and will) also count wreckages as they have MinableMaterial Component.
My fix just also checks if the thing returned by component search is actually an asteroid.


And yep, it indeed is a stupid kind of bug, probably stemming from the thing that game did not have minable wrecks in very early development and then dev forgot that this script uses this method.

Sigh, figures it would be something stupid as a bug like this lol. Anyway, I was looking at the same script and wondering if it also needed a player to reinitialize the sector and proc the script, but running this now to see what happens.

just looked at relevant script, and if DLC doesn't change the script, then I believe that it still is the case.

I don't have the DLC so I can't check this, but in vanilla it doesn't seem to have changed (looks like the script wasn't even touched by the update)

Do you know if this is still an issue?