RimWorld

RimWorld

Flawless Electronics
18 Comments
Tinda 14 Jul @ 4:21am 
not only does it not work, it causes grav engine and helm to not work
氰基硼氢化钠 11 Jul @ 6:42pm 
doesn't work for 1.6
nako 21 May, 2024 @ 3:08am 
For RimPy you can locally fix the sorting for yourself by right clicking -> Advanced operations -> Modify and share sorting rule -> Click "Special rules -> Load bottom" -> Save rules.
ShinUon 9 Sep, 2023 @ 1:49pm 
You can manually move it but it will need to be done after every time you use the auto sort feature (which is every time the mod list changes).

Users are likely to forget or be unaware, so I suggest submitting a sorting rule to the RimPy Mod Manager Database as the mod author.
Irra  [author] 9 Sep, 2023 @ 12:51pm 
I never used RimPy. Does it always order your mod list before starting your game? So you can not manually move it to the end of the mod loading order?
ShinUon 9 Sep, 2023 @ 12:02pm 
Yes, no Rimefeller pipes on the ship. That is what the patch is supposed to add.

The patch also will work if this mod has the following code removed. Seems like that code is somehow removing the comps that the SRTS patch adds?

<!-- Clean up empty nodes -->
<Operation Class="PatchOperationRemove">
<xpath>/Defs/ThingDef/comps[not(*)]</xpath>
</Operation>
</Patch>
Irra  [author] 9 Sep, 2023 @ 9:42am 
I took a look at the problem. It seems like that the SRTS ships get their Rimefeller pipes only and only when the patcher is either disabled or put at end of the loading order after both Rimefeller and SRTS.

How does it break the compatibility? It is just the part about the ships having no Rimefeller pipes constructed to them?
Irra  [author] 9 Sep, 2023 @ 8:58am 
The empty-node cleanup is necessary because empty nodes will cause game to fill its log full of garbage with potential for stability issues down the road.

I can take a look at it. Until then you are better off modifying this mod or not using it at all.

It is known to cause issues for other mods that heavily dependent on the Breakable component existing.
ShinUon 9 Sep, 2023 @ 8:52am 
RimPy sorts this mod higher than Rimfeller. And it does seem to work when it's higher since there are mods below it in the load order and they have not broken down. However, it is also patching and breaking SRTS Rimefeller compatibility.

When I remove the code below <!-- Clean up empty nodes -->, the breakage stops.
Irra  [author] 9 Sep, 2023 @ 8:32am 
Since this is a patcher mod. The load order does matter a lot. So you would want them at bottom of your load order list.

Putting mods after this patch mod will be loaded after the patcher had done its job, so they wont get patched. As far my memory serves me.
ShinUon 9 Sep, 2023 @ 8:06am 
I did more testing by editing the patch and found the issue. The "Clean up empty node" section is what's causing the issue.

I'm not sure how to read the syntax, but I'm guessing the "/comps[not(*)]" is overly aggressive.

<Patch>
<!-- Remove breakdownable components -->
<Operation Class="PatchOperationRemove">
<xpath>/Defs/ThingDef/comps/li[@Class="CompProperties_Breakdownable"]</xpath>
</Operation>

<!-- Clean up empty nodes -->
<Operation Class="PatchOperationRemove">
<xpath>/Defs/ThingDef/comps[not(*)]</xpath>
</Operation>
</Patch>
ShinUon 9 Sep, 2023 @ 7:51am 
This mod breaks the SRTS patch for Rimefeller. Any idea why?

I verified this with a barebones load order:
Harmony
Core
Flawless Electronics
Rimfeller
SRTS Expanded

With this mod installed, the SRTS ships lose the Rimefeller oilpipes in the center.

Also, if I move this mod to the bottom of the load order, it SRTS Rimefeller compatability works again. Not sure if moving this mod to the bottom makes it not patch anything.
Achille12345 30 Mar, 2022 @ 12:02pm 
Finally I will no longer need to tear my hairs out when something break at a very bad moment, example heat wave and at the same time one or multiple of my cooler dies resulting in hundreds of meal rotting.
Irra  [author] 23 Feb, 2022 @ 6:07am 
I see! Thanks for helping me out figuring this out. It seems to be more of an issue with SoS2 than it is an issue with this mod. While I could at least try to make an exception for the shields, it is going to be very ugly and difficult to maintain for future versions, due to how XML Xpaths work.

Sadly, I think you have to make do without this mod for a while.
Raserei 23 Feb, 2022 @ 5:34am 
also the load order doesnt change anything
Raserei 23 Feb, 2022 @ 5:33am 
It makes shield generators unable to be lowered building up heat and grilling the inside of the ship. SoS shield generators are probably coded using some vanilla function for component breakdown
Irra  [author] 21 Feb, 2022 @ 7:55am 
That is unfortunate, how does it break the shield generators? Might worth to add I never have used Save Our Ship 2 mod.

Have you tried prioritizing Save Our Ship 2 after Flawless Electronics?
Raserei 20 Feb, 2022 @ 11:59am 
The mod works great but it is incompatible with Save Our Ship 2. it breaks Shield Generators