awesome.

Yes. I plan on doing an overhaul of how this mod determines non effective weapons for the new update. I will be going through and re-confirming all patches.

Is there a way to add a non effective weapon? I am using this with Medieval overhaul so my pawns keep grabbing wood planks as a weapon.

Thank you for mentioning this. Once I am back at my computer in a couple weeks I will add a compatibility patch for Simple Sidearms.

Is there an issue between this mod and Simple SIdearms ?

EDIT: To answer my own question, yes there is.

The issue is that in order to allow items that are not inherently flagged as weapons, that mod adds a new "weaponTags" flag called "ImprovisedMelee" to them. These items include the thrumbohorn, elephant tusk, wood log and beer. Given that this mod disables the latter two as weapons, the "forget" ability for them is removed.

However, if this mod was added after that mod, and a pawn happens to have equipped wood or beer at some point, they will forever remember this, making them carry them around in their inventory indefinitely.

In order to fix this you need to make a patch that removes the flag. In other words, patching the patch to remove the flags specifically from beer, and wood. :S

All drinks/consumables should be patched by the failsafe. If it doesn't, let me know and I will make a dedicated patch for void.

does this mod patch red wine from void?

Thank you for following up. I was starting to lose my mind trying to figure out what could be causing the drops you were experiencing. I dont use that mod, so that would explain why i never encountered it. After the new year I will either add a note in the description for future players or I will look into a compatibility fix.

I know it's been a long time, but I didn't play it for a while now, after some trials I discovered that the problem is actually with Awesome Inventory, found an option there that forced the pawn to search for a weapon, after disabling that the FPS started to work normally again.

That is weird. I always am running simple sidearms along with many other mods and haven't encountered any drops or errors. I will do some testing to see what I can find out

What @PJRocks also happens to me, it is most likely an incopatibility with simple sidearms,tried to use ur mod to fix the annoying use logs as weapons, but it plummets the fps, prob because simple sidearms is trying to equip them

I saw that you patched logs from Medieval Overhaul. Did you also patch bones? I have a slave who is constantly threatening to rebel after butchering an animal just because they get bones from doing it.

@Robob Rum should be covered by the failsafe patch that covers any consumable. I will double check to make sure the patch is working as expected.

Could you also patch rum from vanilla expanded pirates?

@MadTech You would need to start culling your list in half's to find the issue. It's working fine for for me.

Great idea although it doesn't seem to be working for me

I added this to my 800+ mod list for a couple of days but still had pawns trying to equip logs and I did make sure to remove all logs that pawns had equipped before installing. Not sure if it's conflicting with another mod but no error messages in the logs and I can't find any other settings that may be conflicting.

Correct. I remove the ability for items like logs to be equipped in general. So no matter the pawn it should prevent them from equipping them.

So with this my ghoul wont have a log as weapon?

So will my pawns stop charging at enemies with a fish in hand? :D

I have never seen significant TPS drops while using this mod. I only disable the ability for certain items to be able to be equipped. There are no extra checks that occur during gameplay.

This mod is poorly optimized. My TPS goes from 358 to 198, and my FPS goes from 140 to 18 (3x speed) when I enable this mod. Are you forcing the game to make a weapon check every single cycle? There has to be a more efficient way of doing this.

@Dark106 (not Light601)
You should be fine if you drop all the not-weapons from your pawns' inventories. If you have Simple Sidearms, remove memories of those weapon too, etc. Then save and reload, and check the log to see if there's any errors related to it. Use a custom save name, don't just overwrite your main save.

Actually this is why people always say make a backup save before making changes to your mod list.

Oh no, I accidently saved my game without dropping "weapons". Is my save corrupted or I can save it?

I would like to add that it would appear the IfAllElseFails patch messes with SimpleSidearms.

Thank you for the suggestion. I will be "officially" updating the mod tomorrow once my internet is restored and will add the warning.

The 1.4 version seems to work just fine in 1.5, with the following caveat:

Be sure to unequip/drop all ineligible weapons and save the game BEFORE installing this mod. Pawns won't drop ineffective weapons if they are already equipped, and having an unequippable weapon equipped throws enough errors to impact performance.

I'd recommend updating this mod page to warn players to unequip all ineligible weapons (including getting rid of weapon memory if using Simple Sidearms, just to be safe) before installing this mod.

Looking forward to that update! But yeah I'll try it out and it probably would work just fine anyway heheh.

This mod will be updated to 1.5 soon. Although it should inherently work already.

Sorry for the long delays. The mod has been updated to patch Rimcense. Zen garden (continued) patches were confirmed to still be working and expanded woodworking (forked) also was tested and appears to still be working.

I will look into the error next time I am on my PC while adding the prior requested mods

I was using Expanded Woodworking, to clarify*

This, oddly, made my Mixed Lumber texture completely disappear in game (still in the files, I checked). Thus causing massive log spam :D

Removing this, fixed it. Strange.

I am glad you enjoy my mod. I will work on adding patches for both of those mods as soon as I can.

I'd love it if you could patch these two, both of which add new logs that my colonists love:

Zen Garden: https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2777931683
Rimscense: https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2532255863

Thanks for this very useful QOL mod.

That is correct, I actually used Simple Sidearms and Dual wield for testing when creating the mod.

There does not appear to be any issues with Simple Sidearms. Appears to only remove those mentioned items from that mod's list. Am I right in assuming they are safely compatible?

The patches load for each individual mod only when that mod is found. So if you run a game with no mods that my mod would patch, then it will only affect base game items of wood log and beer. It also will inherently be incompatible with mods that modify base game wood logs unless I have created a patch for the specific mod (for example: MO and its timber)

Does the medieval overhaul patch work for the normal game or just with MO? cause i am not running MO

I double checked the Medieval Overhaul patch and it appears to still be functioning as intended

This mod is also incompatible with Expanded Woodworking.

thankgoodness. thank you

I will work on it. Sorry for the delayed response

Hey! Could you also patch Timber from Medieval Overhaul? Cheers

No worries; Please let me know if you find any bugs!

Thank you for looking into it!

Sorry for the delay; Added compatibility with Biomes! Caverns

Definitely! I will get a patch out sometime this weekend

Hello! When using Biomes! Caverns and Not a Weapon together, jobs involving the Mushroom Logs added by Caverns never finish, and some exceptions are shown in the logs.

Here are a couple of logs from the bug reports we have gotten about this issue:

https://gist.github.com/HugsLibRecordKeeper/b117dafa648fac68249340e47d3b4d82
https://gist.github.com/HugsLibRecordKeeper/cfb5620f71bfb2173a1ee87971aaf575

Would it be possible to add compatibility for Biomes! Caverns?

Fixed it! The error was harmless but I definitely agree with the "red error is bad" mindset. I removed beer from the main game patch as the "When all else fails" patch fired it would throw an error in the event it couldn't find anything left to patch. So now beer will always be covered by the patch so the error should never fire... Hopefully

I have got some red errors. But game still work good.
https://gist.github.com/c3a304aaabc15d436dda044b204ceaf6