Do i need to remove the vanilla entities or put this above or below it ?

@Mohreb el Yaslm The mod description includes the license used for this. To summarize, yes you can do that as long as you follow the terms of the license.

@Tranzcak, are we othorized to use your graphic in other mods (with credits of course)? I really like them but, would like to include some in a mod i do mostly for myself (and to know, if i can use/publish it if i end up doing it all the way through).

just noticed ocarinas in the kiln crafnting menu, i'm a dunce nvm.

excited for the eventual ocarina release. always fond of those.

@deliriousday7 Yes, it's because it has to redefine the entities. Any other mod that does that won't be compatible, unfortunately.

This mod breaks MANY other mods btw. I stopped using it a bit ago, but see many comments in other mods that trace the issue with the mod back to this.

I am having the same problem as @{WeB}*Hithron*

also @ 𓂍 ꂅnki 𓂍 you make them from chopped wood i believe at the craft's-dwarf workshop. or use the manager's work-order menu. Before i figured out it was that easy i just ordered them from the caravan, so if you're still having trouble/I am dead wrong that is an alternate solution.

Thank you! I love this mod. Being a human who wears a kilt and does not own a pair of pants I appreciate the level of creativity gone into this mod (Bagpipes) which in real life would be terrifying to have even one set played underground. also Organ grinders FTW.

Love the mod it's a great idea but is there anyway to change load order mid game please ? it's blocked all my new crafting recipes at my workshops, if not that's my bad for not realising i'll have to make a new world cheers for any help.

following closley

How to get seeds from cave reed?

@Mc.turdle I haven't tested it, but to my knowledge there haven't been any relevant changes that would break it. It should be as working as it ever was (not perfectly as you can see from the known issues).

is this still working?

Have you seen NPC entertainers appearing with custom instruments in your mod? I've been working to add custom instruments to my own mods, but in my experience visiting performers that ought to have one won't, unless you enable procgenned instruments. I might be doing something wrong however. If there's any evidence they will at all it'd be good to know.

the craftsdwarfship is the of the highest quality!

This really makes instruments fun. I get excited when humans and elves bring their instruments so I can add more variety to my temples and taverns.

Yup. This will be the main source of incompatibility with other large mods, unfortunately.

@WallCat BI is cutting and replacing the MOUNTAIN entity, which deletes any changes to it made by mods loaded earlier in the load order. Make sure BI is loading before any other mods.

Procedurally generated instruments are a cool idea, but the current implementation feels half-baked. This is a great substitute.

@Trainzack Genesis Dwarves (the standalone module, not the full overhaul), Training Hall, Set Production, along with some assorted QoL mods. Again, I made sure to check every conceivable combination of mods, yours is literally the only one, period, that when active, makes all other mods stop working. I turn it off, everything works. I turn it on, I may as well be playing vanilla.

@Qev Okay, I'll do that for the next release
@WallCat What other mods are you using?

Your mod causes literally all other mods to not activate at all. I checked my modlist, yours is the culprit.

You've got bbcode in the steam description token in your info.txt, which is what's causing all the errorlog spam. You can just delete the description token entirely unless you want it updating the desc here every time.

The marimba and the gong are furniture.

I haven't built any instruments that can be placed in rooms under the furniture construction place instruments menu. Which can be placed individually in rooms?

Getting the same error spams as @TossThrown’s post below. Caused a number of crashes - Love the mod and simplicity but it’ll be an uninstall until it’s fixed. Please keep up the good work!

@^ban^ I would If I could, but I need to remove tags to remove the generated instruments, and you can't currently do that through a select tag.

Some future version of this mod will split it off into a mod that just adds the instrument and reaction definitions, and several more that actually add the instruments to the entities.

You should change this mod to use [SELECT_ENTITY:MOUNTAIN/FOREST/etc] instead of redefining the entire entity. This would allow other mods to patch the entities without users needing to ensure that your mod loads first.

Hmm, in my testing I can start the reaction just fine, but it eats the sand and fuel and produces nothing.

I noticed that crafting ocarinas wasn't working at all, as people said. When I tried to do that it gave me a job cancel message that it couldn't be done because I had no item that CONTAINS_GLASS or something of the like, I assume it's supposed to be looking for sand bags but is looking for non-existent glass bags instead???

Regardless, what I'm actually here to say is that I noticed that all of the crafts for glass instrument pieces seem to not work either, even though crafting a non-glass equivalent at another workshop seems to work fine. Apologies if someone else mentioned it already.

..... Balance for a bar bones item in game?
I'm not sure I follow the logic that making an instrument harder to make would fundamentally change anything.
Any like I mentioned does not make logical sense.

Mostly for balance reasons, those materials are easier to use than clay or sand. However, due to a bug I still can't suss out, you currently can't make an ocarina at all ;D

Any reason why the Ocarina can't be made of stone, or wood?

I suspect that you mod is spamming the errorlog.txt

Example:
EARLIEST_COMPATIBLE_NUMERIC_VERSION must be less than or equal to NUMERIC_VERSION!
Unrecognized mod info token: /b
Unrecognized mod info token: *| Renamed to high-tension lute.[*| Prevented dwarves from trading or embarking with it, or with the high-tension lute strings.[*| [b
Unrecognized mod info token: /b
Unrecognized mod info token: *| Made bars one shade darker.[*| Fixed sprite (it was using old version).[*| [b
Unrecognized mod info token: /b
Unrecognized mod info token: *| Made body two shades lighter.[/list|

@Ether

Dang, it looks like you're right. I'll have to look into this.

I created glass ocarina, the materials are used, but it does not create anything.

I hope you add drums, and I hope dwarfs will be able to use them.

kobold kazoos made my day :)

@Obe4ken No, so long as this mod is loaded after the vanilla entities, it should be fine. However, do make sure that it goes before any other mods that alter the vanilla entities.

The mod description says it replaces the entity_default file. Does that mean I need to remove "Vanilla Entities 50.01" from the load order?

thank you for the raw vs code link thats very interesting

Here's my attempt at a bagpipes sprite for you.

https://i.imgur.com/iiNLKv4.png

Great work

@deus.tempestas Currently, you can find all the parts by looking at the instrument description. I'm not sure if that or the reaction description is visible in game, though.

What are the parts called?

@Harms dwarven gurdy is now in

Excellent, thank you so much for making this mod!

Thank you for this, I like it al ot

@Trainzack I'll look into doing that, thank you so much.

@MagicMoron Harps are an elvish instrument. However, if you want to give your dwarves harps, you can make another mod that depends on this one that adds the item and reactions to the MOUNTAIN entity. I'll get a metal harp body reaction in the next release as well to support that.