Neh, i structured my file well so it wasn't too hard to do. I just don't understand how i made the mistake i made while making the mod XD

thanks, searching through all those lines must've been draining!

Bug ERADICATED! The mod will now work correctly for everyone!

I found what's causing the error, there's something wrong with the Ixoling "patch", i'll try and fix it asap

Seems it only happens with the C version of the mod, lemme see if i can find out why.

Ahh i see...

It's in the log in storage

When does the error pop up? the main menu? after starting a game? I've reinstalled the game, started a new save and i never see any errors...

I wiped my saves and reinstalled the game and it's still showing up with this as the only mod

I could reinstall it and delete all my saves to test I guess.

Ok, now THAT makes no sense... I'm assuming you're just using the latest version of Starbound?

I unsubscribed to all my mods and I'm still getting it for some reason

I'd unsub or disable all mods and turn them on one by one or in batches, my mods were written to be extremely compatible with other mods but it seems another mod is making mine throw errors.

I resubbed and it's still doing it, which likely means a mod conflict. I don't know with what though.

I cannot seem to replicate your error with a fresh install of Starbound and just my mod (Even with multiple of my mods installed), so something else must be causing my mod to throw this error your way, try and figure out if you have another mod installed that tries to write a monster.treasurepools.patch file.
If that doesn't work, try unsubscribing and resubscribing to my mod and see if that clears it up.

Sorry i can't be of any more help.

I am getting the following error:

[Error] Could not apply patch from file /treasure/monster.treasurepools.patch in source: C:\Program Files (x86)\Steam\steamapps\workshop\content\211820\2926553403\contents.pak. Caused by: (JsonPatchException) Could not apply patch to base. (JsonPatchException) Could not apply operation to base. (TraversalException) Could not remove element after end of array

Thanx for those kind words Fox9000 :D

#Mod-of-the-year-2023

This mod was primarily made for Single player, it should also work with multiplayer providing the server has it.

I doubt this is client side but I'm still gonna ask anyway.
Still need to finish my figure collection.

Excellent work with the update 🏆!

I see you've changed the patch system to be much more compatible with other mods (particularly with combining loot)!

I'm assuming i need a "test" line for every mob, so i'll just add those in.

Yes, that's correct. Adding a desired weight to make up the difference from the 80% multiplier would be better.
Was giving options to show where an existing edit for poolrounds could be moved since I vaguely remembered seeing one of the mods alter that too.

Wouldn't it be better to take the game's code in mind and just add a line of code that adds sufficient weight to reach the desired % effect and leaving the 80% stuff alone?

I need a few moments to wrap my brain around this method, i appreciate you taking the effort on helping improve the code.
The part that makes me scratch my head is that you add stuff, but then proceed to remove the base game's 80% roll, wouldn't that just cause the same issues as me replacing the base game's loot lines?
Also do i need to add just that 1 test line or do i need a test line for every mob?

I'd advise against relying only on replace operations. There are mods that also add to the bosses loot pools like Beta Bound adding unlockable techs or Extended story adding a progression item to ancient guardians.

It's okay for the weighting to exceed 1.0; it just causes the game's probability system to weight the items by the new denominator when that happens. For example if you have a probability of 0.6
of dropping item1; the game has a 60% chance of dropping that item. If you add an alternative item2 with a probability of 1.0; then the probability changes to:

0.6 / 1.6=0.375 item 1
1.0 / 1.6=0.875 item 2

Ps You can edit the games code without copying and pasting using the test/add patch operation
I had an example in my previous comment of those ops to increase loot probability, but Steam's auto check algorithm seems to have glitched out.

Pps I appreciate your answers and persistence in improving the game. +1 👍

Here's an alternative way to increase the drop rates for a figurine. Say you want to increase the chance of an adult poptop drop to 1/100 when
It's current chance is 0.001x0.8. You would integrate:

[
[
//Similar patch lines here
],
[
{
"op": "test",
"path": "/adultpoptopHunting/0/1/pool"
},
{
"op": "add",
"path": "/adultpoptopHunting/0/1/pool/-",
"value": {"weight" : 0.009, "item" : "adultpoptopaf"}
}
//And have another line to change the pool rounds weight to remove the 80% modifier.
]
]

P.s. you can use a similar approach to edit most code files without having to edit the entire base.

For example if a mob has a total "weight" of 1.0 on it's entire droptable and for example 0.599 is for meat 0.400 is for claws and 0.001 for the action figure i increase the weight on the action figure line to for example 0.0022 and lower the meat to 0.5978 so the total of the 3 stays 1.0

The code is actually fully comprised of replace operations, the items adjusted are all items that are already in the game's code and using add instead of replace might cause even more issues down the line.

Nice work :)
This should be useful to players who just want to increase the droprate chance without altering other parts of the game.
I wouldn't frown on increasing the drop chance of boss figurines or even guaranteeing most of them; since (besides the penguin bosses) you have to repeat a 30 minute mission just to reach them in Vanilla.

In fact I'd actually call the action figures you've quoted here as more Consistent rather than "cheaty" since Vanilla drop rates are already painfully low

P.s. Just make sure you're using test and add operations in your code to avoid overriding changes that other mods make to the relevant loot tables (you probably already are).