RimWorld

RimWorld

Trade Price Fix
48 Comments
irrelevantredundancy 7 Jul @ 10:27am 
@Sushima-Carmine - - this mod is recommended for use with Unlimited Reborn by the mod author. There is a link to this mod page in Unlimited Reborn's description. So, I would guess that there is no conflict.
NuanKi 29 May @ 10:40am 
@Sushima-Carmine It does not, mine removes the limits on the pawn, this removes and changes the limit in the code that makes selling and buying everything at less than $1
Sushima-Carmine 29 May @ 3:14am 
Anyone know if this conflicts with Unlimited Reborn?
Black_Overlord 17 Jan @ 6:07am 
So that's why my pawn with several hundred % trade price improve wasn't able to sell stuff for more than 1 silver
lightvsdarkness 16 Jun, 2024 @ 9:47am 
Conflicts with VanillaTradingExpanded (if placed before and after) https://pastecode.dev/s/ik2mdm6j
Any idea what to do?
Lunya 14 Nov, 2023 @ 2:44am 
The sell price cap seems to only effect some items and not others but it might just be my modlist?
Vaarelsauce 14 Sep, 2023 @ 12:10am 
Doesn't seem to work I think, but the other mod (UnCap TradePriceImprovement) does change the price in a positive way instead. So there's that.
FarmerJoe  [author] 21 Apr, 2023 @ 6:42am 
it should be
velack14 21 Apr, 2023 @ 12:38am 
is this compatible with the vanilla expanded trading mod?
FarmerJoe  [author] 2 Apr, 2023 @ 5:16am 
yes, that the main point of this mod. to allow you to buy low and sell high
Stallion 31 Mar, 2023 @ 9:54pm 
Does this allow your selling price to be higher than the buying price if your skill is good enough?

E.g. You could buy for 25% of the worth of a statue but still sell it for 100% of the worth?
FarmerJoe  [author] 5 Mar, 2023 @ 6:23am 
ok I figure out why problem. I had default set to null by accident. usually hit Apply Setting would fix it but I'll push an update in a minute
Jirnu 5 Mar, 2023 @ 6:10am 
i'll relaunch with the mod active in a bit and update you)
FarmerJoe  [author] 5 Mar, 2023 @ 6:07am 
can you try open the mod setting. and then hit "Apply Setting"? maybe a default value I set are broken somehow
Jirnu 5 Mar, 2023 @ 5:56am 
and I just saw im not the only one to have this issue
Jirnu 5 Mar, 2023 @ 5:56am 
using this just made everything i try to sell .01
Stallion 4 Mar, 2023 @ 11:56pm 
I don't understand how this effects the sell price.
Did you make it so that a high negotiation stat no longer lowers the silver you get when selling objects?
KnightedWarrior 4 Mar, 2023 @ 7:10pm 
Seems like when I sell stuff to caravans with this mod, all the items sell for $0.01
Kind of funny, but also sad for my drug tycoon empire
Zargachi 3 Mar, 2023 @ 4:30pm 
tks for the update on the max config values =.=
時穂 1 Mar, 2023 @ 4:13am 
After I installed all the V.O.I.D. implants to my colonists, the trade price always becomes 0.5, thanks to the making of this mod!
苍白而蔷薇 1 Mar, 2023 @ 3:02am 
This is exactly what I need
Zargachi 27 Feb, 2023 @ 1:46am 
would be possible to increace or even remove the cap from the config? cuz i can't go above 2 on max selling so i can't go "cheatty" if i want, what depending in my RP would be cool, neither above 1 in min buying which is kinda sad cuz i wanted to still have a loss when buying =.=
FarmerJoe  [author] 25 Feb, 2023 @ 5:58pm 
@Rinem try change setting and hit apply. the setting might not reflect a change after I update it.
SpaceDorf 25 Feb, 2023 @ 12:41pm 
@Rinem @FarmerJoe .. this seems to be a combination effect with the mod
UnCap TradePriceImprovement, but the Mod Page hints that different Trade Price Mods are incompatible as well.
SpaceDorf 25 Feb, 2023 @ 12:25pm 
@FarmerJoe @Rinem I just wanted to report the same issue,
Buying Prices where still at 4% of Marketprice, while sell Price were at 0.01 Silver.
Rinem 25 Feb, 2023 @ 11:59am 
@Farmer Joe in 1.3 already was a cap of 40% TPI and with more than 40% TPI sell price strarting to go down and this mechanic wasn't removed in 1.4, it was rather your instaled modes. What is your mod doing on default value is breaking everything, with it my pawn having +20% TPI start selling ALL stuff for 0.01$
SpaceDorf 24 Feb, 2023 @ 9:57am 
Yeah, this sound like a really good Idea, percentage boni from modded content and races stack up to ridiculous levels.
I have a Space Marine Trader with 20 Social, a Trait for +25 Trade Price Improvement and
Talking 155% and Hearing 180% which gives a total price improvement of 96.43%

I sell normal cloth tuques with a base of 34 for 37 and buy for 0.87 ..

it was funny at first but now I feel dirty.
FarmerJoe  [author] 24 Feb, 2023 @ 8:44am 
yes you understood it correctly. this give the option to make it how it was in 1.3, or give player the benefit of buying low, sell high. depend on people preference on how they want it that why I make it adjustable setting.
Huyderman 24 Feb, 2023 @ 8:28am 
I'm struggling a bit understanding the description of this fix. Have I understood it correctly that the change introduced in 1.4 effectively reduces your sell price if you have a very high (50%+) trade price improvement, since selling price can't be higher than modified buy price? E.g. If your buying price is 25% of market price, your selling price for an item can't go higher than 25%?

If so, how it's handled in vanilla is kinda awkward. Being able to buy something from a trader at a lower price than you can sell it to them opens up the potential for exploits, but there had to be better ways of solving this than just capping sell-price to buy-price...
Zargachi 24 Feb, 2023 @ 8:14am 
another idea would be a option to have 2 max selling/buying limits, one for caravans visiting your colony, another for you visiting other towns, cuz caravans come with the intention of buying cheaper and selling more expensive, this would be also true for you, the player, when you go with a caravan to a npc town, would be a way to add more reasons to form caravans just for trade, but i think that none of those configurations should intervene with each other, so each player can configure whatever they want.
Zargachi 24 Feb, 2023 @ 8:05am 
The value settings would be for the player to be able to decide how strong this curvature would be, and in the case of factions, how many points you would need to have with them for the base, middle and top of the curvature, and if it would be possible for the curvature to become smaller or up to negative from X points.
Zargachi 24 Feb, 2023 @ 8:05am 
I had an idea, but I don't know if it's possible to do it, or if it already exists in the base game, but it would be like this: change how the game calculates the trader's bonus in an exchange through configurable values, instead of being a flat value , be a curvature, thus allowing higher bonuses in the exchange to be only achievable with a very good negotiator, while average negotiators would still be bad, because nobody is very willing to negotiate with you, if possible something involving the friendship of the faction would be nice, for example, the more friendly they were, the flatter this curve would be, and when reaching 100 points (allies) it would be completely flat, making average traders remain average, or maybe even invert the curve, making average traders have a bonus above their capabilities;
FarmerJoe  [author] 24 Feb, 2023 @ 7:52am 
oh you mean that. then yea. after reread what you said. 100% would be 100% of marketprice. and so the another 11% wouldn't be all that noticeable
Zargachi 24 Feb, 2023 @ 7:47am 
the 111% i'm talking the stat that appear on the top of trade window like "Negotiator: Mathew (+97%)"
FarmerJoe  [author] 24 Feb, 2023 @ 7:35am 
oh the stat that indicate market price is Trading Price Improvement, not Negotiation Ability. so make sure to check that
Zargachi 24 Feb, 2023 @ 7:29am 
yeah, did that right now, apparently it is working, but something is strange... i tried max selling 2 (would be 200% right?) the selling price indead did go above market price but not much... 4.41 to 4.46 for example, dunno why... maybe 111% negotiation ability can go only this far? i'm on vanilla hardest dificulty with randy, so the price is being reduced by x0.60 selling + x0.80 dificulty, i will assume it is working as intended and a 100% negotiation ability will just make i be able to sell to market price, anithing above that is a bonus, gonna fine touch those limits so i do'nt end with a money loop.
anyway, tks for the mod, it's already a favorite for me, finally someone managed to do this, i was waiting for this since 1.1 XD
FarmerJoe  [author] 24 Feb, 2023 @ 7:14am 
maybe the setting hasn't updated yet with change
FarmerJoe  [author] 24 Feb, 2023 @ 7:14am 
try go into setting. change the value to something else and hit "Apply Setting"?
Zargachi 24 Feb, 2023 @ 6:54am 
yeah... still not working ;-;
FarmerJoe  [author] 24 Feb, 2023 @ 6:26am 
pushed a fix. try unsub (wait for a bit for steam to process) then resub.
also it should work with VTE
Zargachi 24 Feb, 2023 @ 6:22am 
nice, tks :3
i think it might work together with "VTE", if it does, this will be cool
FarmerJoe  [author] 24 Feb, 2023 @ 6:20am 
I think I figure out what the problem was. will push out a fix in a moment
Zargachi 24 Feb, 2023 @ 6:12am 
i had "Vanilla Trading Expanded", tried without it too and problem persists, so no idea, i have a bunch of mods that help with trade information, but messing item prices direclty only "VTE"
Zargachi 24 Feb, 2023 @ 6:04am 
removed "The price is right" problem persists
Zargachi 24 Feb, 2023 @ 5:53am 
that i remember, only "The price is right", but the trade is on my colony, not in a caravan on another town, so i don't think it could cause any harm...
FarmerJoe  [author] 24 Feb, 2023 @ 5:48am 
do you use any mod that would affect price calculation?
Zargachi 24 Feb, 2023 @ 5:25am 
there is something broken with the mod... or some incompatibility, cuz the buying price is working fine, but selling price is stuck in 0.01 silver for everything, my negotiator have 100% negotiation ability, so it should have a good price, but the max seeling config, if i put it very high or very low it don't change the 0.01, even a worse negotiator don't change it
skycrossercat 23 Feb, 2023 @ 8:03pm 
Gonna test this mod with "The price is right" to see could this make trading caravans even better