I'm pretty sure also that the player doesn't gain any trait XP for NPCs solving quests. It's probably the base game's detection isn't designed to think about NPCs doing quests, only the player doing quests so it fills up the log with junk.

The way this mod works is by showing a message when player's trait XP is modified in the vanilla method. If another mod patches said vanilla method, there's nothing I can do to detect it, so calling it a bug doesn't feel right to me. What you can try doing is switching the load order, but if GHI is patching over that method or calling it irresponsibly (could be both, it's not open source so I wouldn't know), this is what we end up with.

And I don't think the player gains any trait XP for NPCs solving quests, but I can take a look at it if you are sure that this how it works and this mod for any reason misses it.

2025 June it works. Only bug is that when you have the governor handle issues mod then you get a rain of notification that NPC governors from other clans are getting mercy and honor. The mod works well to avoid you getting notifications when NPCs are raiding or winning battles, but it doesn't work when NPCs perform quests.

I remember seeing some breakdown of possible outcomes on the wiki.

Super helpful mod, thanks for sharing this. Any ideas on how to increase the amount of trait gained or lost?

I don't see anyone reporting issues :)

1.2.12?

thanks buddy

Yeah, it's fine to add or remove whenever.

can this be added midgame?

yay

That's a good idea, I've added it.

@Depression Happy to help

that helps and more. put seeker's links in the discription now for everyone to use. cause its a must.

Wow, that's actually a pretty good and robust fix! Thanks for sharing it

Been looking for something like this for DAYS

For those worried about the valor bug, see here for a fix (not my mod): https://www.nexusmods.com/mountandblade2bannerlord/mods/6835?tab=posts&BH=0

Apparently what calculates valor has to do with a specific calculation being flipped. As the author states, there's an issue where you might not get valor unless you fight the battle, but that seems fitting

alrighty then looks like I got the valor thing to happen for me on my end. it seems it's quite fickle to the point that you have to be so careful with how to set up for valor gain that if you go over power even by a slight margin you get nothing for it. at least that's what i saw when i cleared out a bandit hideout (had other mods mainly adjustable bandits for larger hideout fights etc.) you need only a few compainons and the rest have to be troops. (lower teirs but competent to clear it ) and i got 20 valor boost out of it.

https://forums.taleworlds.com/index.php?threads/1-4-valor-not-being-gained-from-battles.458811/

sadness. and valor is quite finiky to. :( someone should find a way to fix that or at least pressure the devs to fix the valor bug.

Dang it.

Valor is still bugged.

anyway to get valor? i always get 0 value

np

Oh, that's cool. I haven't seen it mentioned in the patch notes but it really seems that the power calculations (that are used in valor calculations) have been simplified. Thanks for mentioning it!

i think they fixed the valor issue. hope we should see other things to improve valor etc.

developers of game still did not fix the valor bit for bravery going up. :( this sucks.

crash report

crashing

sadness on the accuracy bit. :( but at least it's something. though the developers should put out something explaining the traits etc.

otherwise like the other guys said etc. I saw the issue with the valor trait etc. hope the devs can fix it.

I've seen a bunch of info on the wiki, haven't checked how accurate it is though

question can we have a guide or something to explain the triats and how they are gained etc? cause i tried to look it up on steam nothing was there. :(

Okay, so I tested it on 1.0.0, 1.1.0, 1.1.1, 1.1.2, 1.1.6 and it persists, so it seems like this has always been an issue, the only reason it's going less unnoticed now is because of mods like this.

Dang, thank you for the link!

On the Taleworlds forums it looks like this issue has been reported and acknowledged by Taleworlds. No info on how long it'll be before its resolved. Hopefully the whole trait system gets some attention in the future. Link to thread below:

https://forums.taleworlds.com/index.php?threads/1-4-valor-not-being-gained-from-battles.458811/

Same xd

I really doubt it has been fixed :)

Is the bug still present with 1.2.7? If yes I'll check it out see if I can find what throws the monkey wrench in there. Something multiplies it by 0 or just straight up subtracts equal value. My guess is it could be tied to a player attribute that adds a multiplier, which is bugged at 0. But yeah if it still doesn't work I'll take a look

The mod doesn't change the calculations, it hooks onto the method that takes the results of these calculations and shows them. It doesn't interfere with the way vanilla way of calculating and summing up the perk xp. So no, the issue is with the vanilla code, not the mod. I've checked it quite thoroughly with a debugger - out of curiosity.

If you'd like to take a look at it, you can start with the OnBattleWon method of the TraitLevelingHelper class. The issue lays within the mapEvent.StrengthOfSide array.

Do you have any way to test it reliably without the mod? Is the base code of the game messed up, or does the mod interfere somehow? If it's reliably zero, which with the mod it is for me every time, then there HAS to be a something that acts as a zero multiplier somewhere. Where exactly is the line of code related to Valor xp? I might check it out as well, see if I can figure something out.

I'm pretty sure that's your typical Turkish programming. No matter what I've tried, valor always gets zeroed at the last calculation step. The calculations before that are pretty complex and take into consideration levels of heroes, tiers of troops and their numbers and more - but even with a level 1 hero wiping out an entire army, I've gained zero valor.

Why is it impossible to gain valor?

I've updated the mod to provide the context behind trait xp changes. It now hooks onto each of the TraitLevelingHelper's methods (OnBattleWon, OnTroopsSacrificed, OnLordExecuted, OnVillageRaided etc, etc) and includes these methods' names in the xp log after converting them into a more "human" format (e.g. 'Issue Failed' instead of 'OnIssueFailed').

It should be resilient against updates, too! Unless TW fundamentally changes the way TraitLevelingHelper works, of course.

Has anybody managed to earn any Valor or Calculating xp? I think the official information for valor is wrong, I've fought many battles where the strength level was not in my favour and gotten 0 xp so far.

It should work and autotranslate just fine for other languages from what I remember. Try it, if something is missing then let me know.

German support too ?

As it should be

The message is shown each time HeroTraitDeveloper.AddTraitXp vanilla method is called by anything. Sounds like some mod you're using has created its own honor TraitObject and uses it internally for some mechanics, utilizing the TaleWorlds' CharacterDevelopment namespace. Which is wrong, IMO, if you can't see the trait yourself in the encyclopedia and stuff - but there's nothing I can really do about it, my mod is vanilla-focused and simple by design. I can't filter every dumb decision some other mod maker made to make their life simpler and mine harder :D

Too many to write here, so its probably just a problem between mods then. I have played a bit more, and the honor doesnt seem to count as real honor, im not getting new traits from it. It just spams my events, which doesnt really matter

I don't think so. What other mods are you running?

im getting spammed with +30 and +60 honor messages, is that supposed to happen?