thx man! i really like this mod, but this glitch is really annoying and about tips for tips to improve, I honestly don't know since your mod is, without a doubt, peak

@TheOrionnッ This should be fixed in v0.8.1.1

Thank for reporting !
You can disable `Inventory Management > Craft Stack` or avoid bulk buying when you have an item in your mouse.

I'll provide a fix soon

for some reason, when i'm buying items my game simply freeze and i have to reload the entire thing, any tips?

@AvDragon17
I can't seem to reproduce the issue directly.
Could you send me the following files via Discord (@_spiky_), GitHub, a drive...:
- Your `client.log` file (located in the `tModLoader-Logs` folder in your tModLoader install directory)
- Your mod list and configs. To do so, create a mod pack of your enabled mod (`Workshop` > `Mod Packs` > `Save Enabled as new Mod Pack`), export it (`Export Pack Instance`) and provide the file `SaveData/Mods/enabled.json` and a zip of the folder `SaveData/ModConfigs`

Also, just to make sure:
- Does this happen with only Better Inventory enabled ?
- Does this happen if you disable `Smart Item Pickup` ?

@Spiky I’m using a whole bunch of mods, but none that should interfere with inventory and weapon modifiers. I was using stronger reforges and isn’t really compatible with consistent reforges. Disabled better inventory died a few times and no modifiers disappeared. I do have smart item pickup enabled, and sometimes not everything gets their modifier removed, some of my weapons sometimes keeps their modifiers but my accessories never did.

@AvDragon17 what mods are you using ?
Does this happen every time you die ?
Do you have "Inventory Managment" > "Smart Item Pickup" > "Return to Previous Slot enabled" ?

Died in medium core and had my modifiers for my equipment get removed. Turned off better inventory and all is good in the world (none of them deleted)

@Лоускіл can as ask you why ?

IMHO awful mod

Thanks for the suggestion but I don't feel like it would fit the mod.
I would like the keep this mod clientside, meaning I should not modify any player data. Besides, mods like Expended Inventory already exists, you should give it a try

Got a suggestion, You should add extra inventory slots in this mod, think it’d be super useful, especially if someone’s planning to play stuff like the Calamity mod. Would help keep things neat and organized

That would be awesome! When you have lots of mods and crafting tables, the crafting window quickly becomes cluttered by blacklisted recipes

Not currently. They only go to the end of the list but I could at toggle to hide them instead.

Is it possible to completely hide from the crafting window any blacklisted recipe?

https://github.com/Spiky-73/BetterInventory/issues/28

never mind it is not working again

No problem

never mind it is working now

What is not working, the whole mod or a singular feature ?
Do you see any errors in the "client.log" file (located at <tMLSteamDirectory>/tModLoader-Logs)) ?
Can you follow the steps in the Reporting Bugs [github.com] config to see if you can find the features that cause this?

The newest version of Fargo's Mutant Mod does not work with this mod, but it did be for the update

As far as I'm aware, Better Inventory never broke anything with world gen. The mod does not even interact with it.
Are you sure Better Inventory is causing it, and if that is the case what is the bug ?

Does this still screw up world generation or is that problem fixed?

The fix shoud be available (BetterInventory v0.8 and Spiky's Lib v1.3.1). It's not perfect but it allows Magic Storage to work properly for the time being

I think I found a workaround. I'll have to make sure that everything works properly but I may solve the issue until Magic Storage updates

Magic Storage's author is adding an API in the next update that lets mod authors designate things as "Ignore data and stack anyway." It might be easier to wait for that.

It's caused by Spiky's Lib.

In order to fix some wierd stuff with the way Terraria handles the mouse item I added UIDs to items and 2 stacks are currently assign differents uids. I guess Magic Storages see them as items with different modded data and so does not stack them.

I'll see what I can do about it.

This isn't the traditional bug, more of a mod conflict. When using the crafting interface of Magic Storage, crafted items to not get the Spiky's Lib/Better Inventory tag, and don't stack. Removing them from the system fixes it like normal, but any items crafted in the system do not register. I have also notified the author of Magic Storage, as I do not know who would be able to fix this, if anyone.

I should be able to do it.

You can add a feature that allows you to create accessories in such a way that they do not need to be removed!

Are there any recipes displayed normally and can you craft items ?
Did you create a new character ? Discovered recipes are tied to a character and are all unknowned for a brand new charater.

Does setting "Item Search > Better Guide > Undiscovered Recipes" to "Known" solve the issue ?

Hey i don't know why but all the crafting icons are just question marks. I don't know if its mod conflict or me just not being through about my search in the settings.

It's probably because you have Quick move enabled and didn't disable the "Displayed Hotkeys" setting

If it's the case, the sequence to move an items to a specific slot is displayed on said slot.
e.g. when hovering an armor in the inventory, '111' is displayed on the 1st hotbar slot as you need to press '1' three times to move it there (Armor -> Vanity -> Hotbar)

Nothing to serious but it just kinda triggers my OCD, whenever I look in my inventory the numbers in my hot bar turn to 4 digits

tysm the bestiary is actually useful now and i also dont have to manually clear my hotbar i think im falling in love romantically with you spiky

alr

If I add it, it will prodably be in an new mod as it is outside the scope of the mod. You could also try to contact the devs of Chat related mods

can u add a feature to make chat ui bigger please

Sure thing! It will probably not be until some time as I am focused on my other mod (SPIC) for the moment, but I will add it.

can you make it to where when you have an equippable item favorited and you equip it, the item it swaps with is also favorited

Does it happen every time you talk to the guide and do you have a way to reproduce it reliably ?
Can you try to find what feature causes it ?
Do you see any errors in the client.log file (located at <tMLSteamDirectory>/tModLoader-Logs)) ?

Lmao no idea what I even did but I was talking to the guide and every single thing in my inventory, short of my hotbar, just disappeared. My crafting UI also disappeared after installing this, but I don't have any other mods that interact with the guide or the crafting UI. Not sure what happened there, but maybe I've just misunderstood something.

Happy to help

So turns out Extra Item Right Click (In Item Actions) was the culprit !
I suggest you to Disable it until I update the mod.
Thanks for your help !

Got a friend on to test, and figured out it's campfires! Despite Config changes, when holding an item in the cursor, when someone else turns off/on the campfire, it deletes the item currently being moved. It's all been happening after May 1st (subscribed May 2nd funnily enough).

It does !
I've got a few more questions to ask you :
Does this happen with Shift Right Click disabled ?
Does this happen with every setting disabled ?
Do you have a way to reproduce it reliably ?
Did it happend before May 1st (v0.5 or lower) ?

My items and friends items also would disappear when playing multiplayer together. Friends are off so can't test currently but usually when I would come back to base I organize my inventory, I would left/right click the item (craft stack disabled in inventory management config) in order to hold all of or a singular piece of an item in my cursor, where randomly item I was trying to move would no longer exist (I lost weapons and more because of this). Tried to get it to happen on Single Player just now and it wasn't happening. During play session with friends I was relying on QuickMove (shift click) to avoid it happening, heh. Hope this helps.

What are the actions that trigger this bug (Crafting, QuickMove, Item Pickup, ...) ?
Does it also happen in Single Player ?

This mod has a critical bug in multiplayer where items will randomly vanish whenever you interact with them. It’s kinda rendering the mod unusable when playing with friends so if it could be fixed that would be great.

Ok sounds good