RimWorld

RimWorld

*OUTDATED - USE OFFICIAL* - BetterPawnControl - 1.5 UI Fixes
52 Comments
ED-9527 24 Jun, 2024 @ 9:54am 
O7!
Jaggid Edje 24 Jun, 2024 @ 6:29am 
Thank you for the updated info, @DomB.
DomB  [author] 24 Jun, 2024 @ 6:17am 
IMPORTANT

BPC has now been officially updated & includes the changes found here. You can safely swap over and I recommend you do.

- @Jaggid Edje / @Z9527 - thank you for bringing this to my attention
- Many thanks to all subscribers for helping to validate these changes and reporting potential issues

This mod will remain in the workshop as not to disturb anyone's modlist. I will add "OUTDATED" to the title.

Long Live BPC!
:er_wave: :cozyspaceengineersc:
ED-9527 24 Jun, 2024 @ 2:08am 
@Jaggid Edje
I see DOM in the new version of the thank-you list, and I guess I should subscribe to the original MOD
Jaggid Edje 24 Jun, 2024 @ 2:03am 
@Z9527, I'm curious about that as well. Based on the update notes, it looks like the other version rolled DomB's changed into that version. But was it all of them?
ED-9527 23 Jun, 2024 @ 1:09pm 
BPC has updated a new version. Which one should I use?
DomB  [author] 22 Jun, 2024 @ 1:26pm 
Massive thanks for your comment and appreciation :steamhappy: - it's great to know you've found my stuff helpful! :cozyspaceengineersc:
Jaggid Edje 20 Jun, 2024 @ 5:05am 
BPC is one of my most-favored mods. I can't imagine playing without it. I just discovered this fork of it today and I wanted to thank you. BPC hasn't been maintained in some time, and your fixes/tweaks/improvements are greatly appreciated. Thank you for sharing it.

Also, thanks for your good info regarding load orders. That's always useful and I use all of the mods you mentioned.
DomB  [author] 12 Jun, 2024 @ 6:28am 
No problem!

One day I might look at getting animal stuff into BPC... kind of given me an idea there

1st message should be there now
Gidwelion 11 Jun, 2024 @ 5:37pm 
Thank you for your answer. The integration list of BPC has "assign animal food" in it so maybe i will still try. Your first comment is still being analyzed or smth and i cant read it
DomB  [author] 11 Jun, 2024 @ 3:50pm 
2/2

Achtung:

Achtung rescue job is working OK for me. I have saved and loaded without issues. You can disable if you'd like, though I don't think you have to.

What can cause issues is changing this setting mid-play. So do not change it during your run and it should be fine.

Animal Control:

I don't believe Animal Control is compatible with BPC - though I have not tested this myself. I found this post where it's mentioned the creator says no compatibility:
https://www.reddit.com/r/RimWorld/comments/w2xs75/better_pawn_control_mod_and_animal_food/

So, it's likely they are gonna clash. That was 2 years ago though... you could always try it, something might have changed, but most likely it will break.

However, you can still use Animal Logic & Animal Tab, though these do not provide food restriction, they still allow for some extra control which could help you.
DomB  [author] 11 Jun, 2024 @ 3:50pm 
1/2

Yeah pretty much :) that was the plan haha.

Load Order:

The load order you specified - that's not quite the same as what I'm using here, where I believe I've got it working good:
https://steamhost.cn/steamcommunity_com/workshop/filedetails/discussion/3248747854/6678353284414993268/

Try this (relative, not necessarily all touching each other) :

BPC
Achtung
Pharmacist
Worktab

Yours may still work, I can't remember the exact details of it all, but I know this works OK.
Gidwelion 11 Jun, 2024 @ 2:09pm 
Hello, im currently putting together my modlist and i see you have "fixed" and stabilized the mods that i wanted to play with again so badly for years. (Pharmacist, BPC and Worktab)

So if i read your instructions correctly, the load order should be as following:

BPC
worktab
Achtung
pharmacist

Achtungs! rescue job is actually optional and can be turned off entirely if i remember correctly. will it help with compatibility ?

also since its really hard to get an overview of compatibilities with these mods, do you happen to know if BPC will clash with animal control ? its a mod that essentially enables food restrictions for animals.
DomB  [author] 7 Jun, 2024 @ 5:32am 
@Brooks

No conflicts.

Individual pawn "Allowed Medicine" setting takes priority.

Pharmacist settings will all be respected as default treatment for injury types.

Finally, Smart Medicine custom treatment for injury will override the above if used.
Brooks 6 Jun, 2024 @ 11:57pm 
Hey, thanks a lot! How does the Medical Care setting of this mod work with your fork of Pharmacist? Don't they conflict at all?
The Bard of Hearts 3 Jun, 2024 @ 11:38pm 
I see. Thanks for the info.
DomB  [author] 3 Jun, 2024 @ 7:58pm 
You should check out the Original mod description, I did post a link to it in my Description - there's a little tutorial video the author created:

https://www.youtube.com/watch?v=aKhFCkFcaGU&ab_channel=Alex
DomB  [author] 3 Jun, 2024 @ 7:55pm 
After you have created a new policy, switch to it within the "mini" version of the dropdown menu within the relevant tab at the bottom of the screen.

E.g. , for Work > open BPC window > create new policy > close BPC window > click work at bottom of screen > click the "default" button on the mini dropdown > select your new policy > now change the values relevant to policy how you'd like them, so for work that would be the priority values > it remembers your settings , try change back to default and you will see your changes have gone > now change back to your new policy, your custom settings are back

It just doesnt work when you change the dropdown in the big BPC window that's all.

It's working for me anyway following that method, I know it's a bit weird but it does work
The Bard of Hearts 3 Jun, 2024 @ 3:54pm 
Ok... allow me to rephrase my question. Once you have "Created" a new policy. How do you edit it??? said policy created in the BPC UI doesn't actually show up in the Assignments UI or anything like that. So even if you "create" a new policy and switch between them in the "master tabs" as you say, their functions are seemingly meaningless, there's nothing to show what those newly created/renamed policies do or mean.
DomB  [author] 3 Jun, 2024 @ 3:34pm 
Actually, there does appear to be a slight bug - the policy selector drop down lists do not work on the large BCP tab. But they do function on the individual master tabs for each function (mini version).

Only create/remove policies on the main BPC for now, and use the individual tabs to switch them
DomB  [author] 3 Jun, 2024 @ 3:13pm 
Added new screenshot to show in more detail
DomB  [author] 3 Jun, 2024 @ 3:08pm 
Once you have created new policies, you can switch between them using the drop down list below.

Also, a mini-version appears within the relevant tab for each pawn.
DomB  [author] 3 Jun, 2024 @ 2:48pm 
Sorry I'm confused? - I've added Medical functionality to BPC. That is all. The rest of behaviour should be as per original mod.

From what you are saying, it sounds like you need to click the button below rename to create a new policy... it is slightly bigger and directly below - the buttons are all ordered like this, using work as an example:

"Work"
"Rename"
"New work policy"

click "New work policy"... it's the same for all policies - you can see these button in the screenshots of this mod, they should be in your game UI.
The Bard of Hearts 3 Jun, 2024 @ 2:32pm 
OK... I have not idea how to actually use this version of Better Pawn Control. The buttons used to switch the default policies now say "Rename" but typing in a new name doesn't actually create a new policy. Can we just get the old method of choosing a policy from the list you created? That or inform me as to how I'm supposed to use this UI?
DomB  [author] 2 Jun, 2024 @ 7:00pm 
OK yeah, that makes sense

If you'd prefer to disable the rescue mod option for safety & peace of mind then sure, you can always do that - I guess you'd forfeit being able to create some high priority 'rescuer' support pawn, but that's about it.

I've updated the About.xml of this mod with a <loadBefore> for Achtung, so there will be a warning now if it's not


But, I don't think you need to disable rescuing work type - it was behaving when testing with the new load order, I was saving and reloading with stored rescue values.

I also successfully recovered a broken BPC tab + rescue missing + console errors save when using the new order - this save was first created using the 'incorrect' load order. The same method did not work when repeated using the 'incorrect' load order.

So to me that's evidence there's a positive difference, suggests some load order dependency issue - I'm playing with rescue on atm. It's your own call though really
krzarb 2 Jun, 2024 @ 3:27pm 
Hi, before you’d made your suggestions I’d disabled the rescue work type and this mod as well and the console has stopped giving any errors so everything appears to be stable for me and I’ll probably keep it that way for my current colony. When I start a new one I’ll add this mod back in and perhaps have the rescuing work type disabled for achtung and change their load order around. Would that be the best approach?
DomB  [author] 2 Jun, 2024 @ 10:00am 
All of the below also applies to this error:

Exception in LookDictionary(label=settings): System.InvalidOperationException: Tried to add different values for the same key.

Follow my fix steps and hopefully it should resolve :cozyspaceengineersc:
DomB  [author] 2 Jun, 2024 @ 9:58am 
1/2

Achtung Compatibility Issue (Rescue)

I think I've figured this one out - yet to look at a code fix but there's a manual workaround you can try

Impact:
Medium to High - 2 variants of this bug, depending on load order
1) leaves you without Rescue in the work tab + reference errors
2) completely breaks the Better Pawn Control tab & causes error spam
DomB  [author] 2 Jun, 2024 @ 9:58am 
2/2

Info / Cause:
- Firstly, Better Pawn Control doesn't seem to like Acthung being above it in the load order

But as for recreating the bug itself:
- Acthung, has a mod option checkbox 'Rescue' work priority column . This is enabled by default. If you saved the game (meaning you've stored the rescue values), then somehow this option becomes disabled (or you removed Acthung), you will get ref errors around rescuing WorkTypeDef.

You can recover from this, try the steps below

Fix:
- Place Acthung below Better Pawn Control in your load order
- Load your save
- Check your mod options for Acthung, ensure "Rescue" column is disabled .
- Save the game, reload the game
- Check your mod options for Acthung, ensure "Rescue" column is enabled .
- Save the game, reload the game
- Issues should be resolved

Let me know if this is on target, and if it works for you
DomB  [author] 2 Jun, 2024 @ 8:36am 
@Krzarb

That's really useful to know, cheers for figuring that one out.

Sounds like some patch work needs to be done - I'll add it to known issues.


I will try recreate & see what is going on, depending how complex the fix is I can't promise anything, but will let the Achtung author know if it looks like there's anything they can do too.
krzarb 2 Jun, 2024 @ 2:08am 
Hi DomB, just a follow up comment, I’ve been unable to reproduce the errors from this mod when used by itself on a fresh save. After having a trawl through my mod list, I’ve realised that the rescuing job is something that the mod Achtung adds, so that previously described error is likely a bad interaction between these two mods. Also, that rescuing job in and of itself seems to behave weirdly, sometimes it will be in the work tab and sometimes it drops off that tab inexplicably.
DomB  [author] 31 May, 2024 @ 9:46pm 
@The Bard of Hearts

If you still have issues after, then I think either:

1) You are doing something very specific to cause this bug beyond save + reload
2) Something is incompatible within your mod list / bad load order
DomB  [author] 31 May, 2024 @ 9:39pm 
Work Tab Compatibility:

Place Work Tab after Better Pawn Control in your load order.

Use my fork Work Tab - 1.5 Unofficial :
https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3253535347

- Tested with many random priorities > save > quit game > reload... all working fine.
- In my fork I made sure to use latest code & do things properly.

Other workshop uploads of Work Tab may have issues, such as:
- https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2552065963
DomB  [author] 31 May, 2024 @ 9:24pm 
The link you've posted to Work Tab 1.5 Temp ... are you saying it is not compatible?
The Bard of Hearts 31 May, 2024 @ 8:10pm 
The new 1.5 Work Tab mod is NOT compatible with this mod. With both enabled, pawns lose their work priorities in the work tab upon loading the game.
krzarb 30 May, 2024 @ 2:27pm 
Hi DomB,
Thanks for the detailed reply
1) I am using a mod to mothball unnecessary pawns so this makes sense
2) thanks I’ll consider removing dubs performance analyser if it tends to throw these sort of errors in conjunction with harmony
3) I’ll try and start a run with just this mod and its dependencies, although I might not have the time for a few days. I’ll let you know how I get on. Thanks again for the troubleshooting.
DomB  [author] 30 May, 2024 @ 9:08am 
Just a general note to everyone:

Playing the game / loading a save with Dev mode enabled will often show you lots of console logs, yellow warnings from mods etc. Generally these are safe to ignore unless red.

If you turn off Dev mode, then the console will never show unless a red error.
DomB  [author] 30 May, 2024 @ 9:02am 
@szmtex & @krzarb

3)
Could not load reference to Verse.WorkTypeDef named Rescuing

I see you both have this issue. Probably bug in original as of 1.5, I will try recreate it on my end & see if I can fix. If you could also do some test & recreate issue with only this mod enabled (+ any dependency such as harmony), then it 100% proves the cause.
DomB  [author] 30 May, 2024 @ 8:51am 
@szmtex

1)
Could not resolve reference to object with loadID Lord_69 of type Verse.AI.Group.Lord. Was it compressed away, destroyed, had no ID number, or not saved/loaded right? curParent=VanillaStorytellersExpanded.RaidGroup curPathRelToParent=/lords

Errors like this are not always an issue - it depends... Often it's a reference to something off the map that no longer exists on reload, I get them too and usually ignore.

However, I do see a lot of references to "VanillaStorytellersExpanded" - it's not 100% clear if that is in your mod list, but I suggest adding it.
DomB  [author] 30 May, 2024 @ 8:28am 
@krzarb

1)
Errors like this:

Could not resolve reference to object with loadID RelationshipRecord_152727 of type RimWorld.RelationshipRecord. Was it compressed away, destroyed, had no ID number, or not saved/loaded right?

Are not always an issue - it depends... Often it's a reference to something off the map that no longer exists on reload, I get them too and usually ignore.


2)
[Analyzer] Failed to capture Harmony ctor, exception: Object reference not set to an instance of an object

Try remove Dubs Performance Analyser, a lot of people having issues with this and Harmony at the moment

3)
Could not load reference to Verse.WorkTypeDef named Rescuing

I'm still looking into this, will update
szmtex 29 May, 2024 @ 5:34am 
ohh yeah just remembered there also seems to be a little problem with presets when I was playing yesterday I set up my default Schedule and one for emergency where everything is simply work. It works fine when I'm on my main map but when I go on caravan on another tile to mine or my caravan gets ambushed when I switch to emergency nothing happens. Though it works just fine after I go back on my main map
szmtex 29 May, 2024 @ 5:08am 
@DomB sory didnt knew you can actualy do that through link I thought it needed to be copy pasted and as for save it is completly fresh save created yesterday from newly cleaned modlist I also recompiled whole game files before starting though i had this mod on my previous one and it kept poping out also every time I loaded game always only once right after loading 2 messages for every pawn I have. I will go check how to get logs thorugh link. And as for load order it seems it is pretty much near begining after allow tool I posted it bellow that link you sendt:
https://steamhost.cn/steamcommunity_com/workshop/filedetails/discussion/3248747854/6678353284414993268/
krzarb 29 May, 2024 @ 3:09am 
Hi. I've opened Rimworld and the game launch is clean (at least no red errors), but immediately upon loading my save game, errors appear in the log that seem to be related to this mod. The full error log can be found here:
https://gist.github.com/HugsLibRecordKeeper/d04f1647538c3453346b7698b8a9edfa
These errors begin at line 3509 on the uploaded log, although they don't appear to give the full trace? Let me know if you need anything further. Cheers and thanks for taking a look.
DomB  [author] 28 May, 2024 @ 4:04pm 
@krzarb

OK thanks for confirming that :cozyspaceengineersc: sounds like your setup is good too

Yeah please do post the full log when you get chance & I will check it over, thanks
krzarb 28 May, 2024 @ 3:15pm 
Hi DomB, I have a fresh save that’s only ever used this verision of BPC and has had a stable mod list, and I’ve also seen this error pop up in my error log. I wouldn’t have necessarily thought it was coming from this mod though. I’d be happy to provide a full log when I get home from work tonight if you’d be happy to have a look?
DomB  [author] 28 May, 2024 @ 2:58pm 
To share logs you need the Hugslib mod
DomB  [author] 28 May, 2024 @ 2:50pm 
Also try validate your game files
DomB  [author] 28 May, 2024 @ 2:43pm 
@szmtex - some questions:

- Load Order - I need to see your load order / mods used, please try share a log link

- Was this an existing save and you added this mod? Did you ever have the original BPC first?


I suspect you either have a corrupt save file from swapping mods too much, some other mod incompatibility, or your load order is not correct.

(try putting this mod closer to the top, just below JecsTools / Allow Tool if you have those. For a good load order with many mods check this as an example:

https://steamhost.cn/steamcommunity_com/workshop/filedetails/discussion/3248747854/6678353284414993268/