While this mod doesn't cause errors on its own, trying to enable the other mods like Core or Wasteland results in no music playing and thousands of errors on my error log. I've uploaded a log for your convenience: https://docs.google.com/document/d/1VmRPptWt3gg6Ya6sTKYCTlWtV8xHP61W4432qvCBpCw/edit?usp=sharing

Would it be possible to extend compatibility between this mod and the Playlist Mod?:
https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3388866903

Thanks, looks like we need a null check for names in a few methods. Thanks for the report!

Bug report, involving Vehicle Framework:

Root level exception in Update(): System.NullReferenceException: Object reference not set to an instance of an object
at MusicExpanded.Utilities.NameMatches (Verse.Pawn pawn, System.String name) [0x00007] in <a82add510f71424fbf463ca29b47365c>:0

VehiclePawns have Name set to null initially, which remains so until renamed (sometimes requiring the All Vehicles Renamable mod in cases like VVE's Dirtbike, etc.). Once it checks for pawn name cues, it will repeat "Couldn't start a new song" in the debug log.

To reproduce:
1. Start game with Vanilla Vehicles Expanded and Music Expanded Core (for the TrackDefs). Enable all music sets except for Vanilla.
2. Enter a quicktest map. Using god mode, build any vehicle. Do not rename it yet.
3. Save the game, and load this save to restart the music.
4. The debug log should add one "Couldn't start a new song" message per frame or so. Destroy/rename the vehicle, and the music starts back up immediately.

Thank you so much for the message, I am really glad to hear he is doing better! Please give him my best regards, please let him know he didn't fail, without him there would be no Music Expanded at all! I've actually fixed a few bugs, and I plan to continue to maintain and improve it, I plan to continue it for 1.6 and beyond! To Dendroid: may your recovery be swift, thank you for ME and for your amazing music. - Jeremy "Zaljerem" Harris

Hello there. I'm an old and slow guy so please forgive any confusion. My son was behind the Music Expanded stuff before he had the devastating health emergency. He's recovering more and more, so that's good news if you fancy hearing it. Thank you Zali for doing what you did to keep things going, and also including your well wishes. Tiny acts of kindness like that often go unnoticed, so thank you for putting good energy out into the world. I showed your re-upload to "Dendroid" and had him read it, it was needed as he feels like he's failed a lot of people. Thank you Sit, lots of love your way.

I asked on the Music Expanded Core page, but just realised I probably should have asked here; is it possible to get the active playlist selection saved in the save file instead of globally? If we have two different themed saves we have to change the music settings every time we switch from one to the other.

was there ever updated documentation for all of the different available cues?

If you have problems with the music constantly switching around and never getting to listen to a single combat song, then go to mod settings -> Music Expanded and turn off "Vanilla Music Update", although you'd occasionally have to go back and turn it off again right after having done it once

this stupid ass setting is the fault for all the bugs AND it will automatically turn itself on after you have just turned it off

Thanks for continuing this mod, I wanted to make a patch for it for ages!

Yes, multiple packs.

So I'm not sure if this ever changed, but last I used Music Expanded there were two versions. The steam version, which only allowed selecting one music pack, and the github version which had updated with the ability to select multiple packs, allowing you to have the music from multiple different mods enabled and shuffled through at once.

I don't see this asked or answered in the comments or description, so what I'm wondering is would this continued version allow you to select multiple music packs, or just one?

I'm also having the problem with the musics constantly swapping from one to another and never playing an actual combat music until I kill all hostiles on the map, I already tried to unsub/resub but it still not working properly. There's some specific times where it seems to work fine but only when my base got raided, but when I go to another map that have any hostile it will constantly start swapping from one normal music one to another over and over again. Most of the time I have to play the combat musics manually with Music manager.

RandomElementByWeight with totalWeight=0 - use TryRandomElementByWeight.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string)
Verse.GenCollection:RandomElementByWeight<MusicExpanded.TrackDef> (System.Collections.Generic.IEnumerable`1<MusicExpanded.TrackDef>,System.Func`2<MusicExpanded.TrackDef, single>)
MusicExpanded.Patches.MusicManagerPlay/ChooseNextSong:Prefix (RimWorld.MusicManagerPlay,Verse.SongDef&)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:RimWorld.MusicManagerPlay.ChooseNextSong_Patch2 (RimWorld.MusicManagerPlay)
RimWorld.MusicManagerPlay:StartNewSong ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:RimWorld.MusicManagerPlay.MusicUpdate_Patch1 (RimWorld.MusicManagerPlay)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Root_Play.Update_Patch1 (Verse.Root_Play)

Try an unsub/resub? This should have been fixed in version 1.0.4, current version is 1.0.5.

Is there any fix to a problem with music rapidly swapping during action scenes (combat, dangers, etc)? Like one track starts playing, then swaps to another one after just couple of seconds until situation is resolved.

It seems a few new music managers have been released recently - that's all to the good, but please note that Music Manager (Continued) is currently the only FULLY Music Expanded compatible option. This may change (I stand ready to assist the authors of the new mods if I can) but for now use of any other manager is unsupported. Thank you for your understanding.

Hi Jonuss, can you unsub/resub to Music Manager? It is now version 1.0.3 and the log shows you're running 1.0.2. Sometimes Steam isn't timely about delivering updates. Please let me know if that worked. Thanks!

Additional note: ME mode (Vanilla Music Update unchecked in settings) REQUIRES that you set the "Run In Background" option in RimWorld settings, or it will immediately turn back on.

As always I appreciate everyone's patience, testing, and feedback.

Hello all, MEF recently updated to 1.0.4 - this is a massive fix update that should resolve a great many issues. Thank you to Reel for his detailed troubleshooting and testing.

- Detects map danger level correctly - combat should now step down through battle level music and play music continually as intended in ME mode.
- minRoyalTitle is now fully handled by MEF (fixing a specific issue with VFE-Deserters and restoring full functionality for one Royalty song and any future songs using this tag)
- Additional redundancy and checking in the settings menu to prevent error flooding if mods are removed, etc. Last resort - you can always remove the config file to reset.
- Official ME music packs (Core/Wasteland) will be receiving updates momentarily so they functional correctly and as intended in both vanilla and ME mode

Updated: Additional fixes to sound effect selection. Vanilla theme will no longer contain songs with a minRoyalTitle set (this fixes an issue with VFE - Deserters where ME would play songs that should be restricted)

Updated: Added redundancy and checking to avoid error flood if settings can't find chosen theme/sound effects. Should now throw an error/warning and revert to defaults.

As always, I appreciate reports of issues and your patience. I'm about 6 months more experienced with C# and I'm hoping to fix this up properly, at the least make it a little better. Thanks!

OK, this is a simple operation, and I'll see if it makes a difference as I play ：）

It appears that if you do not have Run In Background set in RimWorld options, MEF will automatically turn "Vanilla Music Update" back on. I'm looking further into the code, noting this above, please see if it behaves any differently.

Try recreating your settings as mentioned below?

This is frustrating because I've been unable to duplicate most of these problems, which makes fixing them very difficult.

Why does "Vanilla Music Update" keep turning on automatically in my mod Settings, how can I turn it off permanently

Hmmm, try deleting your config file so it gets recreated:

C:\Users\YOURUSERNAME\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios\Config

Delete the file that starts with "Mod_3263001145"

Errors non stop at launch, please look into this

Same problem with Vanilla Music Update as the others. Something seems to be amiss in this mod.

@Koyuukekkai All it needs is a loop on the theme of original wars and it's fine.

Vanilla Music Update keeps enabling itself after I turn it off whenever I enter the game. Its just constantly scrolling through all the songs with no music.

Is it possible to request how to make a custom music list here? I don't know how to start a guide

Same issue as the people above but only when "Vanilla Music Update" is on, works flawlessly otherwise.

Really weird bug where the it just cycles through 100+ songs instantly repeatedly until I turn the mod off. No music either.

For whatever annoying reason songs keep skipping through and only playing each for about 10 or so seconds before going into long silence or right into another song.

Caught a weird bug. Each song plays for 2-5 seconds and switches to the next track.
Too many mods.

Unless the mod is designed for/compatible with the framework, its songs will be lumped in with the Vanilla theme.

How do the cues (or the mod in general) work with music mods, like P Music or Music on the Rim?

My man finally forked the greatest music expanded framework, and my music mods won't go to waste anymore
Huge thanks, GOAT

Ahh yeah thank you, you're right. I've selected everything now :D

Is it still available to be selected in Music Expanded's mod settings? It should be.

It should still work, you can ignore that; it is looking for the original, outdated Music Expanded Framework mod. This continuation provides the same functionality. I named it differently internally (I do this for any mod I continue to strictly differentiate it from the original) ... unfortunately this "breaks" mods with dependencies.

I have this mod installed and some packs seem to work but for Music Expanded: Elder Scrolls, it says "Missing Dependencies: Music Expanded Framework"

Is there a way to fix that?

You two are beautiful souls, thank you :)))

Updated with the fix provided by Gensando! Thank you very much! I do source directly from the repo; please don't hesitate to make PRs if you find anything else! I greatly appreciate the assistance!

As @Reel said, after the first track music won't play again if "Vanilla Music Update" is unchecked. Made PR with a fix https://github.com/Music-Expanded/music-expanded-framework/pull/75

I believe it's related to the "Vanilla Music Update" tick option, forcing it to cycle through peaceful tracks constantly.
I tested it with the Wastelands module and it still persists. Unticking the option just makes the music stop playing after the first song is done.

I was trying to make a custom music pack for myself but whenever a raid happens, the peaceful tracks keep cutting abruptly and won't transfer over to the Tense/Battle tracks. This is also an issue that persists in the Made in Abyss music pack.

Would you happen to know a way to fix that? I have the battle tracks tagged under "BattleSmall/Medium/Large" in the cue section, yet the issue persists. My XML is very similar to the ones present in the Core module of Music Expanded, so I'm really stuck here.

THANK YOU!!