RimWorld

RimWorld

Mining Priority
Uuugggg  [developer] 30 Mar, 2018 @ 2:25am
Bug Reports
Let's keep the comments clean, report bugs here!

=========================
When submitting bugs
1) post debug log
2) be specific
3) don't be vague
4) post debug log
5) maybe explain why you think this mod is causing the problem

( I am honestly going to ignore things if I don't get these )
=========================

Vague reports can only get the response " well, that doesn't happen here "

---

The game produces log files. These are essential for debugging.

If you have HugsLib, press ctrl-F12 to upload logs

Or find logs here:
+ Windows: Steam/steamapps/common/Rimworld/RimWorld_Data/output_log.txt
+ Mac OS X: /Users/[Username]/Library/Logs/Unity/Player.log
+ Linux: Pass '-logfile /tmp/rimworld_log' to the RimWorld binary. It generates a log at that location.
And upload it all to pastebin.com or something
Last edited by Uuugggg; 5 Apr, 2018 @ 10:45pm
< >
Showing 1-15 of 19 comments
Nesano 9 Apr, 2018 @ 8:31pm 
I encountered a bug with this mod where colonists aren't able to mine (which is what inspired this post). I know it's vague, but all I know is that the problem goes away if I disable this mod. There was another guy in the thread I linked that had the same problem and name-dropped this mod without it having been brought up until then.

Some details from the linked thread:
• Colonist set to mining
• Ore is designated for mining.
• Ore is not outside restricted area.

In short, I've confirmed that in the same exact scenario, whether or not the mod is disabled is the one factor that determines whether or not it works, so it's not a problem with the vanilla game.

I can try some stuff if you have anything in mind, but this is all the information I have at the moment.

Pastebin throws a "413 Request Entity Too Large" error when I try to upload the output log, but it probably wouldn't be of much use anyway since a crash or a dialogue popup isn't involved.
Last edited by Nesano; 9 Apr, 2018 @ 8:34pm
Uuugggg  [developer] 9 Apr, 2018 @ 8:49pm 
There is an option in the settings window:

Restrict mining with yield to best miners.

Sounds like that's working as intended.

Turn off the settings and this mod should do nothing.


Now... do you not have your best miner set to mining? That might be something to adjust in this mod, make sure the best miner is actually mining.
Nesano 9 Apr, 2018 @ 9:00pm 
Ah, that must be it then; that's a pretty wise setting. I only realized mining yield scales with skill level while I was looking into this problem and I didn't realize this mod had settings. I'll relay this info to the guy in the other thread.

I did have my best miner set to mining, but he's also my best grower and best builder so, realistically, he was never going to get around to mining. Technically, he was capable of mining, but if you were to make a change based on this scenario, it would be making sure there is mining being done at the present time before giving the lesser miner the task.

I assume "restrict mining with yield to best miners" meangs "restrict mining with yield to miners 8-20," right?

Want me to delete my comments seeing as this wasn't a bug?
Uuugggg  [developer] 9 Apr, 2018 @ 9:22pm 
"Best miners" is "Best available"

Check your pawn's stats to see their mining yield. Only miners with the highest yield available will mine.

No need to delete things, more info is good for later reference
Nesano 9 Apr, 2018 @ 9:24pm 
Yeah, her mining yield is only 98% because she's level 7 as opposed to 8+. I designated some regular stone for mining and she went nuts on it. Figure that way she can get some practice. It's actually working pretty well since she was only level 6 when I initially posted this.
76561198844358074 18 Aug, 2018 @ 10:41pm 
So, I decided to do a fresh install of Ubuntu 16.04 with just the nVidia driver to try and see if Rimworld B18 64 bit would run better. I've found that Mining Priority is the only mod out of over 180 that causes a crash to desktop immediately after the pods land and I close the crashlanded dialogue, and the game starts playing. I tried removing every single mod until its just ModCheck, Core, ModSwitch, HugsLib and Mining Priority in that order. I've found that removing the ModCheck mod and leaving Core, ModSwitch, HugsLib and Mining Priority stops the game crashing once I close the crashlanded dialogue, but the game throws up a bunch of red error messages that go on continuously. I have no clue what the problem is, but I am able to run 180+ other mods including Gear Up and Go, Meals on Wheels, Smart Medicine, Replace Stuff, Share the Load, TD Enhancement Pack and What Is My Purpose without getting crashed to desktop the moment the game start playing.

On Windows, this mod has no problems.

These are the logs I am able to get before it crashes:
{LINK REMOVED}
{LINK REMOVED}
Last edited by Shrek the Donkey; 18 Aug, 2018 @ 10:41pm
Uuugggg  [developer] 18 Aug, 2018 @ 11:34pm 
I do some interesting code-level things in Mining Priority so I guess Linux handles that differently - It's a tiny mod and there's not much room for confusion.

So a probable fix here: https://github.com/alextd/RimWorld-MiningPriority/releases/tag/v1.01

Can't test it myself but this should work.
76561198844358074 19 Aug, 2018 @ 12:37am 
I tried the new file you uploaded, and as much as I'd like to say it works, it unfortunately still crashes to desktop once I close the crashlanded dialogue (usually when the pod pop open) - this was with an otherwise vanilla game without even HugsLib or ModSwitch. Starting again with "Core, HugsLib, ModSwitch and Mining Priority", I managed to grab a log {LINK REMOVED} - I first tried doing a crashlanded game and got a bunch of errors. So thinking it had something to do with the pods cracking open, I quit to menu, selected a tribal starting on their feet but ultimately it still spews out a ton of errors once I dismiss the dialog.

Regardless of whether you're able to fix it, thanks for the response, and the effort and work you put into this and all the other mods you've created.
Uuugggg  [developer] 19 Aug, 2018 @ 1:12am 
Yea, after the change I made, there's nothing that looks like it could cause problems -

so this is the weird sort of thing that would need to be tediously tested line by line to find the problem. And I guess that requires Linux to cause the problem in the first place.

Without linux all I can say is ¯\_(ツ)_/¯
Last edited by Uuugggg; 19 Aug, 2018 @ 1:12am
Uuugggg  [developer] 21 Aug, 2018 @ 12:26am 
well - there is a similar mac crash and I have a mac, so I did things and have posted an update that probably fixes linux too.
76561198844358074 23 Aug, 2018 @ 7:13pm 
Confirmed. Previously I wouldn't last 2 seconds before a crash, now the game runs the same as it did in Windows. Thanks for the fix.
Herri Batasuno 10 May, 2020 @ 10:11am 
Hi, I'm testing for my new game, and just starting the game, I get this error: https://gist.github.com/9083c08c724bee101df4fd7cbf26fea6
I've un-sub and re-sub in case of bad instalation. but still...
Last edited by Herri Batasuno; 10 May, 2020 @ 10:12am
ZzZombo 10 Jun, 2020 @ 7:07am 
Seems a conflict with Prison Labor is present:
Kenney threw exception in WorkGiver Mine: System.InvalidOperationException: Sequence contains no elements
at System.Linq.Enumerable.Max (System.Collections.Generic.IEnumerable`1[T] source) [0x00022] in <351e49e2a5bf4fd6beabb458ce2255f3>:0
at Mining_Priority.WorkGiver_Miner_JobOnThing_Patch.IsGoodMiner (Verse.Pawn pawn, System.Type workGiverType) [0x00064] in <5e139d2bb7be46d1b63d454e867ccb3f>:0
at Mining_Priority.WorkGiver_Miner_JobOnThing_Patch.Prefix (Verse.AI.Job& __result, Verse.Pawn pawn, Verse.Thing t, System.Boolean forced) [0x0002c] in <5e139d2bb7be46d1b63d454e867ccb3f>:0
at (wrapper dynamic-method) RimWorld.WorkGiver_Miner.DMD<DMD<JobOnThing_Patch2>?622139776::JobOnThing_Patch2>(RimWorld.WorkGiver_Miner,Verse.Pawn,Verse.Thing,bool)
at RimWorld.WorkGiver_Scanner.HasJobOnThing (Verse.Pawn pawn, Verse.Thing t, System.Boolean forced) [0x00000] in <0ee2c524c4be441e9b7f8bfcb20aca6f>:0
at PrisonLabor.Core.AI.JobGivers.JobGiver_Labor+<>c__DisplayClass7_1.<TryIssueJobPackage>b__0 (Verse.Thing t) [0x00013] in <ee4c22da86864c16b38dbd3e2e3a1615>:0
at Verse.GenClosest+<>c__DisplayClass2_0.<ClosestThingReachable>b__0 (Verse.Thing t) [0x00034] in <0ee2c524c4be441e9b7f8bfcb20aca6f>:0
at Verse.GenClosest.<ClosestThing_Global>g__Process|5_0 (Verse.Thing t, Verse.GenClosest+<>c__DisplayClass5_0& ) [0x00047] in <0ee2c524c4be441e9b7f8bfcb20aca6f>:0
at Verse.GenClosest.ClosestThing_Global (Verse.IntVec3 center, System.Collections.IEnumerable searchSet, System.Single maxDistance, System.Predicate`1[T] validator, System.Func`2[T,TResult] priorityGetter) [0x00125] in <0ee2c524c4be441e9b7f8bfcb20aca6f>:0
at Verse.GenClosest.ClosestThingReachable (Verse.IntVec3 root, Verse.Map map, Verse.ThingRequest thingReq, Verse.AI.PathEndMode peMode, Verse.TraverseParms traverseParams, System.Single maxDistance, System.Predicate`1[T] validator, System.Collections.Generic.IEnumerable`1[T] customGlobalSearchSet, System.Int32 searchRegionsMin, System.Int32 searchRegionsMax, System.Boolean forceAllowGlobalSearch, Verse.RegionType traversableRegionTypes, System.Boolean ignoreEntirelyForbiddenRegions) [0x0014e] in <0ee2c524c4be441e9b7f8bfcb20aca6f>:0
at PrisonLabor.Core.AI.JobGivers.JobGiver_Labor.TryIssueJobPackage (Verse.Pawn pawn, Verse.AI.JobIssueParams jobParams) [0x00357] in <ee4c22da86864c16b38dbd3e2e3a1615>:0
Verse.Log:Error(String, Boolean)
PrisonLabor.Core.AI.JobGivers.JobGiver_Labor:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Conditional:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_SubtreesByTag:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.Pawn_JobTracker:DMD<DMD<DetermineNextJob_Patch3>?-1157461376::DetermineNextJob_Patch3>(Pawn_JobTracker, ThinkTreeDef&)
Verse.AI.Pawn_JobTracker:TryFindAndStartJob()
Verse.AI.Pawn_JobTracker:DMD<DMD<EndCurrentJob_Patch1>?1953354624::EndCurrentJob_Patch1>(Pawn_JobTracker, JobCondition, Boolean, Boolean)
Verse.AI.Pawn_JobTracker:DMD<DMD<JobTrackerTick_Patch1>?759836416::JobTrackerTick_Patch1>(Pawn_JobTracker)
Verse.Pawn:DMD<DMD<Tick_Patch5>?-429816064::Tick_Patch5>(Pawn)
DTimeControl.TCTickList:TickThing(Thing)
DTimeControl.TCTickList:DoTick(Double, Boolean)
DTimeControl.TimeControlBase:TickManagerTick(TickManager, Boolean)
DTimeControl.Core_Patches.Patch_DoSingleTick_Prefix:Prefix(TickManager)
Verse.TickManager:DMD<DMD<DoSingleTick_Patch2>?2109718016::DoSingleTick_Patch2>(TickManager)
Verse.TickManager:TickManagerUpdate()
Verse.Game:DMD<DMD<UpdatePlay_Patch2>?908473088::UpdatePlay_Patch2>(Game)
Verse.Root_Play:DMD<DMD<Update_Patch0>?-58853248::Update_Patch0>(Root_Play)
Kayedon 29 Aug, 2020 @ 5:12pm 
Hello friend! Bug Report:

Error upon loading game, have not yet even loaded a save. No apparently error upon loading a save, but this is my first time using the mod so I'm going to play a bit and see if the onload error produces any further negative effects.


Error while instantiating a mod of type Mining_Priority.Mod: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
Full error: https://pastebin.com/ZMS6BuJR
Error log: https://gist.github.com/HugsLibRecordKeeper/964d5622cf1f69a400b168c7e91a04da

Please let me know if you need any additional information or would like assistance in testing!
Uuugggg  [developer] 30 Aug, 2020 @ 11:51am 
I see you have 'BetterLoading" which I have found ruins things like this.
< >
Showing 1-15 of 19 comments
Per page: 1530 50