The original 'Free Spy Promotion Choices' mod worked with Civilization VI (vanilla) leaders. I altered the sql file to include Rise & Fall and first expansion DLC leaders with this code:

INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_ADJACENT_DISTRICTS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_ALL_ROADS_TO_ROME', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_AMAZON', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_BONUS_AGAINST_BARBS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_CREE_TRADE_GAIN_TILES', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_DHARMA', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_DOUBLE_ARCHAEOLOGY_SLOTS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_DOUBLE_CULTURE_BUILDINGS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_DYNASTIC_CYCLE', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_EARLY_OCEAN_NAVIGATION', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_EXTRA_LIGHT_CAVALRY', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_FIRST_CIVILIZATION', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_FOUNDING_FATHERS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_GOLDEN_AGE_QUESTS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_GOLDEN_LIBERTY', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_GROTE_RIVIEREN', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_HELLENISTIC_FUSION', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_IMPERIAL_FREE_CITIES', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_INDUSTRIAL_REVOLUTION', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_INEXPENSIVE_BUILDERS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_ITERU', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_KHMER_BARAYS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_LAND_DOWN_UNDER', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_LAST_PROPHET', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_LEGEND_FIVE_SUNS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MAPUCHE_TOQUI', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MBANZA', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MONGOLIAN_ORTOO', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MOTHER_RUSSIA', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_NKISI', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_PLATOS_REPUBLIC', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_ROYAL_NAVY_DOCKYARD', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_SATRAPIES', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_SCOTTISH_ENLIGHTENMENT', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_STREET_CARNIVAL', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_TA_SETI', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_THREE_KINGDOMS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_TREASURE_FLEET', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_WONDER_TOURISM', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_ZULU_ISIBONGO', 'C_SPY_PROMOTION_CHOICES') ;

I confirmed this worked in both vanilla and R&F with those leaders. Then I moved on to Gathering Storm leaders. I began by adding the trait types for the new GS leaders:

INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_FACES_OF_PEACE', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_PEARL_DANUBE', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_GREAT_MOUNTAINS', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MALI_GOLD_DESERT', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MAORI_MANA', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_GREAT_TURKISH_BOMBARD', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_MEDITERRANEAN_COLONIES', 'C_SPY_PROMOTION_CHOICES') ;
INSERT INTO TraitModifiers (TraitType, ModifierId) VALUES ('TRAIT_CIVILIZATION_NOBEL_PRIZE', 'C_SPY_PROMOTION_CHOICES') ;
This did not work for the new leaders, although previous leaders still worked. As a result, I decided not to publish my 'Open Spy Promotion Choices' mod.
The next day you published your 'Choose Any Spy Promotions', which seemed to use a different approach. Rather than using a collection of TRAIT_CIVILIZATION values, you used the blanket TRAIT_LEADER_MAJOR_CIV value.

I cannot explain why using the GS TRAIT_CIVILIZATION values did not work in my mod. However, with respect to your mod, TRAIT_LEADER_MAJOR_CIV does not include the new GS leaders mentioned in Expansion2_Civilizations_Major.xml located in ...\DLC\Expansion2\Data.

I hope this research and information helps you publish a mod that includes spy promotion choices for the GS leaders (Dido, Shaka, Kupe, Laurier, etc).