the mod when activated prevents the hallowed nights jack-o-lanterns from spawning around the portal

Thanks for the bug report! I'll be digging into the game code to see if I can actually make something happen. In the meantime, I did notice that there still are jack-o-lanterns at the pig king location, so going there for your lantern needs could be a solid choice. If you get there at dusk or night, you may even be able to recover a few extra pumpkins that the pigmen haven't eaten yet.

ashes don't spawn if you modify reeds

I'm sorry, I think you'll need to be more specific about your glitch; the ashes are spawning when I torched a seed, and although I haven't killed a red hound in the test world, so far all of my red hounds were generating ashes in my main world.

If ashes don't spawn right after you burn an item / kill a red hound, then this may be an issue with another mod (unless further testing is done and the issue was isolated on Setpiece Config only, which I was unable to replicate). If you left a spawned ash on the ground for more than 20 seconds, then it will automatically be blown away, that's part of the game mechanics. Reed trap generation should only affect the initial world generation settings, and nothing afterwards should be affected.

Let me know if I can be of further help! Cheers

Bug: Linked to Hypermun's previous report, it seems that setting the game to any particular mode at time of worldgen would result in pumpkin lanterns spawning, if Hallowed Nights is default event. Minor bug, since the pumpkins are very much take-it-or-leave-it. I guess that's where Hypermun's pumpkins all went.

Hello! I have noticed that when generating a Juicy Berry Bush world, bushes around ponds will be regular berry bushes, and the pig torch ones will be too (I am unaware if pig torch berries should be Juicy or berrybush2/pretty berry bushes, but it's worth noting, especially if it's another non-Pig Village or Wormwood source of that berry bush type (i believe it is, which is part of why i was excited for the pig torch setpiece)).

I was planning on using this mod because the old Chaos Worldgen mod had issues with berry bushes too, spawning all 3 types on top of each other or removing Pretty Berry Bushes entirely, but I typically like to play with Juicy Berry Bushes on the overworld, for easy access for early game beefalo taming, plus future smallbird access, Pig Village on for the 9 pretty bushes, and classic resources in the caves, so I have access to regular bushes for building.

Ultimately this is a minor gripe, and nowhere near as broken as Chaos Worldgen's all 3 bushes on top of each other, but as someone who likes their worlds as vanilla as possible, while cheating in some rare stuff so I don't need to reset 2000 worlds, it's one that will probably be keeping me from using it for the time being.

Otherwise amazing mod, and I'm going to use it in all my non-island adventures worlds when/if a patch is pushed to fix this (while keeping the 9 pretty bushes in the Pig Village, and maybe at the pig torches (the pig torch terrarium set piece has pretty bushes, i know that much)), or I figure out commands to switch all of prefab("berrybush") in the forest to prefab("berrybush_juicy"), and maybe switch the ones at the pig torches to prefab("berrybush2").

Thank you for your time, and for the mod.

Hello! I just replicated this on a single-shard forest world, and the bug was the same. Additionally, the Pig Guard Terrarium setpiece generated its 6 pretty berry bushes just fine.

I am not a programmer, so take my analysis and suggestions with a grain of salt, but it appears that unless for some reason pig guard berry bush set pieces are meant to have pretty berry bushes, the game is generating set pieces and ponds with regular berry bushes, and no alternate versions for Juicy Berry Bush worlds. This issue does not occur with Pretty Berry Bushes, i.e. the six around the terrarium, as there is no alternate Juicy and Regular bushes for it to get mixed up with.

A possible solution could be to check if a shard has Juicy Berry Bushes or Regular ones, either by:
1 - If that's a value in the shard, i.e. 0 for regular and 1 for alt for all the alt resources, then simply check for that value in the shard and replace regular berry bushes in the shard with Juicy ones upon generation
OR
2 - If that is not a value, check if a shard has Juicy berry bushes upon generation, if yes, then the world is a Juicy Berry Bush one and regular berry bushes can be replaced with Juicy ones.

Assuming that there's no missing pretty bush pig guard set pieces, this should solve the issue, and not interfere with other normal berry bushes that are meant to be there, as none could have been transplanted from one shard to the other, or spawned in a setpiece.

Hi Celeste! Thank you for your reports. Development is shelved indefinitely for this current moment, but yeah those seem to be expected behaviors; as far as I am aware, this mod does not touch on berry bush generation around ponds. The berry bushes in pig guard setpieces are chosen randomly from a list of possible pig guard setpieces (yes, there are several!), and changing that based on juicy/non-juicy bush worldgen would require a substantial change to the code.

If it’s alright, can you just see the inconsistencies as quirks of the game? Berry bush transmutation is available as a skill, and lore-wise we can always assume that some poltergeist/early survivor transmuted it themselves for unknown reasons. Cheers!

Sure! Thanks for the mod regardless, and good luck on ur other endeavours o7

Thanks fam! You as well :D