RimWorld
Signs and Comments
nikos 2021년 9월 12일 오전 10시 56분
Please add null handling.
Hello. I am currently testing out your mod, and when i pressed the visibility toggle for the signs, i started getting null reference error spam.
This is because you don't have null handling, witch is needed for RimThreaded compatibility.

Here is our wiki page on with info about thread safe coding:
https://github.com/cseelhoff/RimThreaded/wiki/For-Devs#null-handling

Please consider adding null handling, its very simple to do, thank you.

-RimThreaded team <3

--------------------------------------------------------------------------------

Root level exception in OnGUI(): System.NullReferenceException: Object reference not set to an instance of an object
at Dark.Signs.DoPlaySettingsGlobalControls_ShowCommentToggle.RefreshAllSigns () [0x00000] in <2e70e6f2c98449859b83063c978d5672>:0
at Dark.Signs.DoPlaySettingsGlobalControls_ShowCommentToggle.Postfix (Verse.WidgetRow row, System.Boolean worldView) [0x00043] in <2e70e6f2c98449859b83063c978d5672>:0
at (wrapper dynamic-method) RimWorld.PlaySettings.RimWorld.PlaySettings.DoPlaySettingsGlobalControls_Patch5(RimWorld.PlaySettings,Verse.WidgetRow,bool)
at RimWorld.GlobalControlsUtility.DoPlaySettings (Verse.WidgetRow rowVisibility, System.Boolean worldView, System.Single& curBaseY) [0x0002b] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at RimWorld.GlobalControls.GlobalControlsOnGUI () [0x0005e] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at (wrapper dynamic-method) RimWorld.MapInterface.RimWorld.MapInterface.MapInterfaceOnGUI_BeforeMainTabs_Patch1(RimWorld.MapInterface)
at RimWorld.UIRoot_Play.UIRootOnGUI () [0x0001f] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at (wrapper dynamic-method) Verse.Root.Verse.Root.OnGUI_Patch1(Verse.Root)
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch1 (string)
(wrapper dynamic-method) Verse.Root:Verse.Root.OnGUI_Patch1 (Verse.Root)
nikos 님이 마지막으로 수정; 2021년 10월 6일 오전 5시 01분
< >
전체 댓글 5개 중 1~5개 표시 중
nikos 2021년 9월 12일 오전 11시 00분 
nikos 2021년 9월 15일 오후 1시 01분 
Update:
this one might be on our end. its fixed in the next update.

null handling and thread safe collections are still needed when appropriate though.
nikos 2021년 11월 6일 오전 9시 03분 
Update again, seems its just on this mods end, not even related to multithreading
Dark  [개발자] 2022년 3월 6일 오후 11시 48분 
Apologies for taking a long time to get to this. I haven't spent much time with anything RimWorld-related in months.

This bug should be fixed with the update I just pushed. It would trigger when there were no signs placed yet on the map and the toggle was used.
nikos 2022년 3월 16일 오전 1시 20분 
Good to hear!
< >
전체 댓글 5개 중 1~5개 표시 중
페이지당 표시 개수: 1530 50