Butikssida
RimWorld
Alla Diskussioner Skärmbilder Konst Sändningar Filmer Workshop Nyheter Guider Recensioner

RimWorld

Butikssida
RimWorld >  Workshop > Darks workshop > Signs and Comments > Diskussioner
Signs and Comments
Beskrivning Diskussioner2 Kommentarer82 Ändringar
nikos 12 sep, 2021 @ 10:56
Please add null handling.
Hello. I am currently testing out your mod, and when i pressed the visibility toggle for the signs, i started getting null reference error spam.
This is because you don't have null handling, witch is needed for RimThreaded compatibility.

Here is our wiki page on with info about thread safe coding:
https://github.com/cseelhoff/RimThreaded/wiki/For-Devs#null-handling

Please consider adding null handling, its very simple to do, thank you.

-RimThreaded team <3

--------------------------------------------------------------------------------

Root level exception in OnGUI(): System.NullReferenceException: Object reference not set to an instance of an object
at Dark.Signs.DoPlaySettingsGlobalControls_ShowCommentToggle.RefreshAllSigns () [0x00000] in <2e70e6f2c98449859b83063c978d5672>:0
at Dark.Signs.DoPlaySettingsGlobalControls_ShowCommentToggle.Postfix (Verse.WidgetRow row, System.Boolean worldView) [0x00043] in <2e70e6f2c98449859b83063c978d5672>:0
at (wrapper dynamic-method) RimWorld.PlaySettings.RimWorld.PlaySettings.DoPlaySettingsGlobalControls_Patch5(RimWorld.PlaySettings,Verse.WidgetRow,bool)
at RimWorld.GlobalControlsUtility.DoPlaySettings (Verse.WidgetRow rowVisibility, System.Boolean worldView, System.Single& curBaseY) [0x0002b] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at RimWorld.GlobalControls.GlobalControlsOnGUI () [0x0005e] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at (wrapper dynamic-method) RimWorld.MapInterface.RimWorld.MapInterface.MapInterfaceOnGUI_BeforeMainTabs_Patch1(RimWorld.MapInterface)
at RimWorld.UIRoot_Play.UIRootOnGUI () [0x0001f] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
at (wrapper dynamic-method) Verse.Root.Verse.Root.OnGUI_Patch1(Verse.Root)
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch1 (string)
(wrapper dynamic-method) Verse.Root:Verse.Root.OnGUI_Patch1 (Verse.Root)
Senast ändrad av nikos; 6 okt, 2021 @ 5:01
< >
Visar 1-5 av 5 kommentarer
nikos 12 sep, 2021 @ 11:00 
Here is more info:

https://github.com/cseelhoff/RimThreaded/issues/660
#1
nikos 15 sep, 2021 @ 13:01 
Update:
this one might be on our end. its fixed in the next update.

null handling and thread safe collections are still needed when appropriate though.
#2
nikos 6 nov, 2021 @ 9:03 
Update again, seems its just on this mods end, not even related to multithreading
#3
Dark  [utvecklare] 6 mar, 2022 @ 23:48 
Apologies for taking a long time to get to this. I haven't spent much time with anything RimWorld-related in months.

This bug should be fixed with the update I just pushed. It would trigger when there were no signs placed yet on the map and the toggle was used.
#4
nikos 16 mar, 2022 @ 1:20 
Good to hear!
#5
< >
Visar 1-5 av 5 kommentarer
Per sida: 1530 50