RimWorld

RimWorld

Growth Vats: Overclocked
 This topic has been pinned, so it's probably important
MakeItSo  [developer] 16 Nov, 2022 @ 8:19pm
Bug Reports & Compatibility and Technical notes
POSTING BUG REPORTS:
The more specific information you can give, the better. Screenshots are good. The error log (ctrl+f12) is also useful, but isn't always required depending on the nature of the bug (I don't spam the log with the ongoing status of my code because it's bad for framerates - but it's useful for actual errors).

Note about 'Enhanced Vat Learning' (the other mod for vats):
After some collaborative discussion the devs of that mod decided to change and patch for compatibility on their side. Both mods work well together and support each other in making good vatgrown pawns.



I built and tested this with a bunch of the usual suspect mods running and nothing caught on fire IRL.

Uses a couple of destructive harmony prefixes on the Pawn_AgeTracker.Notify_TickedInGrowthVat() method and the Building_GrowthVat.VatLearning property. This means the mod is probably incompatible with any other mod that relies on these being vanilla.

Otherwise it overrides the Hediffs given to vat occupants so any mod that relies on those will also be affected.

Note on crazy skill gains:
Some users have reported children aging up from babies with very high skills instantly, with this and/or other mods. I have also seen at least one report on reddit of this occurring in vanilla games, so it appears as though it is a (rare?) vanilla bug that occurs with skills and growth vats. Not sure how to reproduce it right now, as all test pawns I've grown with the mod have all been within expected ranges. If you have any extra info though, please do share.


Alien Race Framework note:
As that mod is currently under active development for Biotech compatibility things are still in flux. I currently don't handle alien races explicitly (waiting for development to settle to see what I'm dealing with and busy with other features), but any race that uses vanilla growth moments and becomes an Adult at 18 should work with no issue. Races with stranger life stages and/or growth should probably not use the enhanced learning mode, but can use the vats in vanilla mode as I've intentionally left the vanilla functionality alone as much as possible.
AFAIK as of the time of writing the 18 year old expulsion age is hardcoded in the vats and neither I nor HAR change that. Please let me know if this has changed on HAR's end and I haven't noticed or updated this message.


Add/Remove:
Safe to add and remove from existing games. Removing the mod requires using the 'Remove Mod' button at the top of the mod settings page to clean up first though. See the tooltip on the button for steps to remove and reload and what to expect.

Performance:
The mod has to hook into a bunch of places on the already performance-heavy vanilla growth vat code to do it's thing, so there will always be some hit to your framerate using this mod. I make every effort to keep that hit as low as possible, and I'm always open to suggestions on how to improve it (especially from, but not limited to, more established modders who may know any tips or tricks).

Playing without Royalty DLC:
  • If you're just *turning off* Royalty, then techprints (and by extension the rest of this mod) work just as intended.
  • If you don't have Royalty installed *at all*, you'll get an error about tags not being supported on game load - but the mod will continue to work just fine, but with no techprints.
I'll still update the mod to completely get rid of the errors mentioned (and hard Royalty requirement), but as they are not harmful and only people who don't own Royalty but also download this mod will see the errors its a low priority.
Last edited by MakeItSo; 8 Jan, 2023 @ 2:20am
< >
Showing 1-15 of 82 comments
MakeItSo  [developer] 21 Nov, 2022 @ 4:00pm 
Unlocked the discussion for anyone to add notes or ask questions about performance and compatibility specifically.
di eshor ribly 22 Nov, 2022 @ 7:19pm 
There seems* to be some kind of incompatibility with the Cloning mod and Enhanced Growth Vats.

https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2881790485

After extracting an embryo from a donor pawn and tossing it into a growth vat the baby will spawn with (what seems to be) random skills with 29999/30000 xp (rank 20). Sometimes skill sets are taken from the parent pawn (if they have any xp over 0) and boosted to 20. This skill boost is before they are returned to the vat for further growing/training.

I was using EGV with no issues before installing Cloning. Removing either mod from my active list returns babies to being properly born with 0 skills.

*This skills issue was originally reported by a user by the name of Pengus on the Cloning page. According to Pengus they have not installed or used EGV yet, but were planning to do so soon. Cloning's mod author looked into it on their end for us and thinks it might be EGV. Hopefully it's nothing too major.

Edit: here's the hugslog if it helps.

https://gist.github.com/d1ba370e0d5f954994099f90658656ca
Last edited by di eshor ribly; 22 Nov, 2022 @ 7:35pm
MakeItSo  [developer] 22 Nov, 2022 @ 7:51pm 
Ouch, that is indeed a bug! Thank you for the report. Unfortunately the hugslog doesn't have any relevant info. As its probably a weird mod interaction rather than an error it might be harder to track down.
The skills from parent sounds like a Cloning thing, and I don't touch embryos afaik. I'll check it and the original report out and see what we can work out.
di eshor ribly 22 Nov, 2022 @ 8:05pm 
They haven't added skill or trait cloning to the mod yet, just xenogenes. More and more it sounds like a random weird interaction... or something with Biotech itself.
MakeItSo  [developer] 22 Nov, 2022 @ 8:13pm 
I'm testing now. Just cloned an embryo, put in vat, DEV'd it to the last day of emby-growth and spawned a normal clone child. Are the skills given when the child is 0 or older?
Last edited by MakeItSo; 22 Nov, 2022 @ 8:14pm
di eshor ribly 22 Nov, 2022 @ 8:20pm 
The life cycle of the bugged skill clones went extraction > growth vat> birth (age 0, 0 skills). At age 3 when they become children in the vat.. random insane stat growth. Same results from dev mode speeding up or going through the 10 day gestation.

*at least in my last game. I stopped playing for a bit earlier today when I had a 0 age baby with 20 skills. They were disabled by age but hovering showed me they had the 29999/30000 exp going on.
Last edited by di eshor ribly; 22 Nov, 2022 @ 8:24pm
MakeItSo  [developer] 22 Nov, 2022 @ 8:24pm 
Thanks for the details, I'll see where this growth goes then
MakeItSo  [developer] 22 Nov, 2022 @ 8:34pm 
Ok my test pawn grew up with a couple of skills (2 shoot, 1 melee), but those were expected from the vanilla Vat Learning hediff. Now my hediff has taken over and it's working as expected. Did the skills just pop up instantly or did it just seem like they were growing very quickly?
di eshor ribly 22 Nov, 2022 @ 8:36pm 
Thinking over something Cloning's author Dark said about anything interacting with gene extractions causing...potential issues with cloning/embryo harvesting I thought I'd mention (for cross testing purposes if nothing else) is that I was using Gene Ripper, Auto Harvest Genes, EVGL, Biotech Cloning, and Gene Weight Modifier. Nothing else I was using touched children, genetics, or growth vats.
di eshor ribly 22 Nov, 2022 @ 8:37pm 
Instant 20 skills for the affected clones. Sometimes they'd spawn with a random skill value, I saw 8, 16, and 18 on a few skills.

Stupid question probably... would... uh, the mech gestator implant for mechanitors do anything to growth vats? I know it's supposed to only work on mech gestation speed... but could it be speeding up the learning tick rate or something? My donor pawn was chromed up and I'm trying to think of anything at this point =P.
Last edited by di eshor ribly; 22 Nov, 2022 @ 8:41pm
MakeItSo  [developer] 22 Nov, 2022 @ 8:43pm 
Yeah it's strange, but this doesn't *seem* like an issue on my end. I don't ever force skills on pawns, they should grow over time at a rate of about 2000xp per 100% on the hediff.

EDIT: Please do let me know if you find the culprit or if there are any other possible variables to consider. I'll keep an eye on the issue and if I can reproduce, great!
Last edited by MakeItSo; 22 Nov, 2022 @ 8:51pm
di eshor ribly 22 Nov, 2022 @ 8:53pm 
I thought it might have been a setting being overtuned, so I tested it with 200xp/tick. Still had 3 year old ubermensch popping out of the vats.

It's hard to tell if they're spawning at 0 seconds with 0 skills and improving to 20 by age 3 (when it's visible), but I pause when I get the 3 year old choice of enslavement. In the time it takes me to hit the space bar they're the world's leading expert in multiple skills.
MakeItSo  [developer] 22 Nov, 2022 @ 9:12pm 
From everything I can see and from speaking with Dark briefly I'm actually slightly leaning towards a vanilla issue. Maybe the learning stat is causing issues with some pawns and giving wildly inaccurate buffs to learning? IDK, will continue to monitor it though.
MakeItSo  [developer] 22 Nov, 2022 @ 9:19pm 
You should be able to see the Vat Learning hediff on the baby. If its doing what its supposed to then it will rise to 100% slowly and give XP at the end (but the baby gets nothing as all skills are locked). If its going fast I don't know why as that's all vanilla. If it's somehow coming up as my 'Enhanced Vat Learning' hediff even while being a baby then that might be the cause, but I wouldn't know why the baby has it. You've already tested with low XP on my hediff and it still happens, which really makes it look like its coming from elsewhere.

Phew I hope that word salad can help you track it down.
Last edited by MakeItSo; 22 Nov, 2022 @ 9:33pm
Dastardly Dragon 18 Dec, 2022 @ 12:02am 
Somewhat predictably, due to how vat-juice is set up you can only use it for a short time to grow your pawns. Because once they hit a drug overdose level this will not go down while they're in the vat as all negative hediffs are paused while in a growth vat. (For example, the current pawn I have growing has hypothermia because I store all my drugs in the freezer and as it was 4 years old it didn't take long to get hypothermia and this is not going down despite being in the vat for days.)
< >
Showing 1-15 of 82 comments
Per page: 1530 50