Store Page
The Binding of Isaac: Rebirth
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

The Binding of Isaac: Rebirth

Store Page
The Binding of Isaac: Rebirth >  Workshop > Math-Man's Workshop > Samurai's Blade > Discussions
Samurai's Blade
Description Discussions1 Comments128 Change Notes
 This topic has been pinned, so it's probably important
Math-Man  [developer] 4 Feb, 2023 @ 1:12am
Bug Reports
If you have encountered some strange behavior or the item flat out did not work for you, I'd appreciate it if you make a bug report on this thread.


Here are the things that you can include in your bug report so that I can make sense of the issue:
  • A brief description of what happened.
  • The log file. You can find it under
    Documents\My Games\Binding of Isaac Repentance\log.txt
    You can upload the log wherever you want, but pastebin[pastebin.com] is probably the easiest solution.
  • Any big overhaul mods you have installed. I doubt this mod would have any kind of conflict with another mod but it'd be good to cross-check.


If the mod doesn't work at all, as in nothing happens when you pick up the item, you should include the log. Also, try to "Verify the integrity of the game files" through steam just in case.


If you have found a visual bug or an item synergy bug, just a brief description will do.


Also, you need Repentance. if you don't have it, mod will not work.
Last edited by Math-Man; 14 Jun, 2023 @ 1:53am
< >
Showing 1-15 of 22 comments
rainy 4 Feb, 2023 @ 6:41pm 
Blade sometimes can't attack enemies if there are Obstacles between us, and I'm not sure why this happens. In addition, I feel it's unfair that Blade can't collect pickups like Spirit Sword and The Forgotten, hope you could tweak it.
#1
Math-Man  [developer] 4 Feb, 2023 @ 9:58pm 
Originally posted by yuqingzhitian:
Blade sometimes can't attack enemies if there are Obstacles between us, and I'm not sure why this happens. In addition, I feel it's unfair that Blade can't collect pickups like Spirit Sword and The Forgotten, hope you could tweak it.

When the blade tries to damage an enemy it does a line-of-sight check. This check is only done for non-flying enemies. I might try to make this check more forgiving. Either way, I'll add an option to completely ignore line-of-sight through the mod config menu.

The item pickup idea is good, I'll see what I can do about it.

Edit: I've sent the changes. Both requests are also added as options to the mod config menu.
Last edited by Math-Man; 5 Feb, 2023 @ 2:04am
#2
Ghostbroster Connor 5 Feb, 2023 @ 12:38pm 
Hey, your "ENTITY_TAKE_DMG" function, and related SamuraiBladeEntityDamage function, both have the capability to "return true" in the "ENTITY_TAKE_DMG" callback.

At the moment, a function returning non-nil will cause any code from other mods for the same callback to get skipped entirely. So you should only ever return false (if you want to stop damage) or don't return anything at all / "return nil"

I know you use typescript so hopefully the description of the issue still makes sense. Would appreciate it if you could fix this to avoid sometimes causing problems with other mods.

Thanks!
#3
Math-Man  [developer] 5 Feb, 2023 @ 1:03pm 
Originally posted by Ghostbroster Connor:
Hey, your "ENTITY_TAKE_DMG" function, and related SamuraiBladeEntityDamage function, both have the capability to "return true" in the "ENTITY_TAKE_DMG" callback.

At the moment, a function returning non-nil will cause any code from other mods for the same callback to get skipped entirely. So you should only ever return false (if you want to stop damage) or don't return anything at all / "return nil"

I know you use typescript so hopefully the description of the issue still makes sense. Would appreciate it if you could fix this to avoid sometimes causing problems with other mods.

Thanks!


Oh wow, I had no idea. I guess I should've read the docs more carefully, thanks for the heads-up. I'll send a fix right away.
#4
Ghostbroster Connor 5 Feb, 2023 @ 1:13pm 
No worries! Thank you!
#5
Luqinhas 23 Mar, 2023 @ 6:26pm 
after this game update the sword no longer appears at the beginning
Last edited by Luqinhas; 24 Mar, 2023 @ 4:57pm
#6
Ghostbroster Connor 23 Mar, 2023 @ 8:22pm 
Yeah there was a bug in an isaac patch but thankfully they hotfixed it and things are fine now
#7
ᚲᚺᛁᛗᚨᛋ ᛒᛟᛁ 25 Mar, 2023 @ 6:01pm 
after this game update the sword no longer appears at the beginning
#8
Math-Man  [developer] 30 Mar, 2023 @ 1:50am 
Originally posted by Chimas_Boy:
after this game update the sword no longer appears at the beginning

Originally posted by lks_ke:
after this game update the sword no longer appears at the beginning


Item not being spawned in the starting room is intentional. I am trying to slowly pull the mod out of 'beta' so I've set it to be disabled by default.

You can still enable the item being spawned in the starting room through the mod config menu. Look for the option 'Spawn In The Starting Room' and set it to 'true'.
Last edited by Math-Man; 30 Mar, 2023 @ 1:53am
#9
Rat 17 Apr, 2023 @ 4:12pm 
it doesnt show up, i attack and nothing happens
#10
soggy sailor 8 May, 2023 @ 9:14pm 
I got the item as T judas and it prevented me from attacking period, I don't know if it's on my end or not but I couldn't use it :(
#11
chaze 10 Jun, 2023 @ 11:59am 
glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack
#12
Math-Man  [developer] 13 Jun, 2023 @ 10:16pm 
Originally posted by chazeracer:
glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.
Last edited by Math-Man; 13 Jun, 2023 @ 10:17pm
#13
chaze 14 Jun, 2023 @ 11:48am 
Originally posted by Math-Man:
Originally posted by chazeracer:
glad im not the only one, no matter what i do it cannot spawn in the room, 2nd it will never attack

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.
yeah i fixed it haha. sorry!!
#14
Math-Man  [developer] 14 Jun, 2023 @ 11:20pm 
Originally posted by chazeracer:
Originally posted by Math-Man:

Sounds like a mod conflict. I honestly can't do much without the log file, I've tried to replicate this issue multiple times before with different setups and I couldn't get it to happen.

I'd appreciate it if you pass me the log file. Also, have you tried using mod config menu options to spawn the item at the start? And try to change the Tear-Behavior from the config menu as well, I suspect not firing might be related to that option.
yeah i fixed it haha. sorry!!

Awesome, thanks for letting me know :reheart:
#15
< >
Showing 1-15 of 22 comments
Per page: 1530 50