Store Page
Oxygen Not Included
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Oxygen Not Included

Store Page
Oxygen Not Included >  Workshop > scitor's Workshop > Darkness Not Excluded (fixed) > Discussions
Darkness Not Excluded (fixed)
Description Discussions9 Comments126 Change Notes
Lost Dream(lilcan) 15 Oct, 2023 @ 11:37am
Space Darkness issue
Figured i would make this a post to better format it as well as keep it out of the comments.

First, i have no real knowledge on the coding language involved, but i do know about coding in general.

So for the issue, i thinks its less of a bug and more of a unintended overload.

Simply put the darkness effect is quite heavy on the game, and revealing that large of a tile amount causes a crash.

So the solution would be to have a different part of code run if the tile amount is greater then the crash number, or to change how the reveal is done.

I would recommend the changing how the reveal is done to reduce lag.

I personally suggest doing it over time, since i think it would be the easiest to implement.

Maybe make the reveals occur over like 10 seconds, either segmented, or a radial effect.
< >
Showing 1-6 of 6 comments
Lost Dream(lilcan) 15 Oct, 2023 @ 11:47am 
Just checked yea, the amount you reveals on a normal maps is almost double

like 14k tiles on the original and 9k tiles or so on spaced out. give you dont count the tiles in the red area, and give or take some for measurement mistakes.
#1
scitor  [developer] 18 Oct, 2023 @ 7:07am 
I don't think the amount of tiles is the actual problem. It reveals the whole map in debug mode no problem, it takes a second or two but it doesn't crash. The surface layer is not really that many cells.

I suspect some internal changes to game sim, since the same problem appears to crash "High Pump" now, even tho it didn't on earlier versions of the game. Somehow the "FloodFill" is not safe anymore. and I think its not because of too many tiles, it's because it loops over invalid/null tiles. I didn't look further into it as it's hard to debug and I don't know how to step-debug this.. maybe I'll find out at some point, I was rather hoping the author comes back until then :D
#2
scitor  [developer] 18 Oct, 2023 @ 7:21am 
The `GameUtil.FloodCollectCells` is an game method, it should return all the cells but this actually crashes. Didn't look too much into the filter yet, which could actually be the problem.
If you want to do this in batches you'd need to collect all the cells manually... maybe that could be the way to debug this, rewrite the method and check where it fails
#3
Lost Dream(lilcan) 18 Oct, 2023 @ 9:54am 
This comment is awaiting analysis by our automated content check system. It will be temporarily hidden until we verify that it does not contain harmful content (e.g. links to websites that attempt to steal information).
#4
scitor  [developer] 25 Oct, 2023 @ 9:45am 
in case you didn't see, your last 2 msgs didn't go through, so idk...
currently I don't have time to investigate so for now this part just stays unmodded
#5
Lost Dream(lilcan) 25 Oct, 2023 @ 2:38pm 
Showed it went through on my end, and the second was a bug it double posted the same message.

No worries, i just talked what could possibly be gibberish.
#6
< >
Showing 1-6 of 6 comments
Per page: 1530 50