Project Zomboid

Project Zomboid

Mod Manager: Load Order Sorter
REfRigERatoR  [developer] 29 Mar, 2024 @ 9:55am
Bugs
Describe bugs found here
< >
Showing 1-15 of 29 comments
莫名某某 7 Sep, 2024 @ 6:41am 
`function: sortFunc -- file: MMPanelFilter.lua line # 749 | MOD: Mod Manager
function: @stdlib.lua -- file: null line # 52
function: @stdlib.lua -- file: null line # 63
function: @stdlib.lua -- file: null line # 64
Repeat the above statement many times
function: sort -- file: MMListBox.lua line # 82 | MOD: Mod Manager
function: updateFilter -- file: ModSelector.lua line # 1219 | MOD: Mod Manager
function: order -- file: MMPanelFilter.lua line # 432 | MOD: Mod Manager
function: onMouseUp -- file: ISTickBox.lua line # 189 | Vanilla
java.lang.RuntimeException: Stack overflow
at se.krka.kahlua.vm.Coroutine.ensureStacksize(Coroutine.java:131)
at se.krka.kahlua.vm.Coroutine.setTop(Coroutine.java:147)
at se.krka.kahlua.vm.LuaCallFrame.setTop(LuaCallFrame.java:126)
at se.krka.kahlua.vm.LuaCallFrame.init(LuaCallFrame.java:151)
at se.krka.kahlua.vm.KahluaThread.luaMainloop(KahluaThread.java:999)
at se.krka.kahlua.vm.KahluaThread.call(KahluaThread.java:163)
at se.krka.kahlua.vm.KahluaThread.pcall(KahluaThread.java:1980)
at se.krka.kahlua.vm.KahluaThread.pcallBoolean(KahluaThread.java:1924)
at se.krka.kahlua.integration.LuaCaller.protectedCallBoolean(LuaCaller.java:104)
at zombie.ui.UIElement.onMouseUp(UIElement.java:1228)
at zombie.ui.UIElement.onMouseUp(UIElement.java:1183)
at zombie.ui.UIManager.update(UIManager.java:816)
at zombie.GameWindow.logic(GameWindow.java:262)
at zombie.core.profiling.AbstractPerformanceProfileProbe.invokeAndMeasure(AbstractPerformanceProfileProbe.java:71)
at zombie.GameWindow.frameStep(GameWindow.java:765)
at zombie.GameWindow.run_ez(GameWindow.java:681)
at zombie.GameWindow.mainThread(GameWindow.java:495)
at java.base/java.lang.Thread.run(Unknown Source)
`
REfRigERatoR  [developer] 7 Sep, 2024 @ 7:34am 
please check if there is a message "Mods sorting STARTED" in the logs?
Anyway, try to unsubscribe from my mod, launch the game, and check if the error repeats.
Judging by the logs you sent, the problem is not in my mod.

also make sure that ModManager is the very first (should be located at the top of the mod loading list).
REfRigERatoR  [developer] 7 Sep, 2024 @ 7:57am 
I was able to reproduce your error.

Thanks for finding it!

This error occurs when my mod is enabled and the player tries to sort the list of all mods by date in the main ModManager window.
Steps to reproduce
Main Menu -> Mods -> [mods "Mod Manager" and "Mod Manager: Load Order Sorter" are enabled] -> Sort : by date added -> descending
莫名某某 7 Sep, 2024 @ 8:33am 
But the real problem is that when you launch a mod that requires dependencies, it won't launch the corresponding dependencies correctly, but will launch other unrelated mods instead
莫名某某 7 Sep, 2024 @ 8:42am 
In addition to this, I found that the framework "that DAMN Library" of ki5 vehicles does not correctly place before some ki5 vehicles, such as the '82 Oshkosh M911
REfRigERatoR  [developer] 7 Sep, 2024 @ 8:54am 
Originally posted by 莫名某某:
But the real problem is that when you launch a mod that requires dependencies, it won't launch the corresponding dependencies correctly, but will launch other unrelated mods instead

I'm trying to reproduce what you're talking about now, and it doesn't work...
prerequisites: ModManager and ModManagerLoadOrderSorter are enabled.
steps: enable the '69 MIni Mk2 mod (requires that Damn library)
result: there are no problems, that Damn library is activated, no extra mods are enabled

But enabling dependent mods is not part of my mod's functionality. ModManager is responsible for that.
莫名某某 7 Sep, 2024 @ 9:00am 
With thousands of mods in the game, it's pretty hard to create an intelligent sorting mod. Especially since the authors of many of these mods aren't that professional.
But maybe people don't need it to sort "intelligently." After all, most mods are not affected by ordering. The automatic enabling of dependencies on the original modmanager is sufficient.
For me, it would be good enough to see in the list of load order which mods are dependencies of other mods, and to tag mods that are "translated".
If you really want to complete this mod intelligently, perhaps rimworld's mod manager: rimpy is a good example.
莫名某某 7 Sep, 2024 @ 9:04am 
Originally posted by REfRigERatoR:
Originally posted by 莫名某某:
But the real problem is that when you launch a mod that requires dependencies, it won't launch the corresponding dependencies correctly, but will launch other unrelated mods instead

I'm trying to reproduce what you're talking about now, and it doesn't work...
prerequisites: ModManager and ModManagerLoadOrderSorter are enabled.
steps: enable the '69 MIni Mk2 mod (requires that Damn library)
result: there are no problems, that Damn library is activated, no extra mods are enabled

But enabling dependent mods is not part of my mod's functionality. ModManager is responsible for that.

I know the ModManager is responsible for enabling dependent. But I did an error occurred enabled a mod need dependent, and when I not enabled ModManagerLoadOrderSorter eliminates this problem.
莫名某某 7 Sep, 2024 @ 9:08am 
Originally posted by REfRigERatoR:
I was able to reproduce your error.

Thanks for finding it!

This error occurs when my mod is enabled and the player tries to sort the list of all mods by date in the main ModManager window.
Steps to reproduce
Main Menu -> Mods -> [mods "Mod Manager" and "Mod Manager: Load Order Sorter" are enabled] -> Sort : by date added -> descending

In fact, you repetition of this error will still occur in ModManagerLoadOrderSorter not enabled, but only popup game err tips. errorMagnifier doesn't give the error I originally posted. Maybe it's not the same mistake.
REfRigERatoR  [developer] 7 Sep, 2024 @ 9:08am 
Originally posted by 莫名某某:
Originally posted by REfRigERatoR:

I'm trying to reproduce what you're talking about now, and it doesn't work...
prerequisites: ModManager and ModManagerLoadOrderSorter are enabled.
steps: enable the '69 MIni Mk2 mod (requires that Damn library)
result: there are no problems, that Damn library is activated, no extra mods are enabled

But enabling dependent mods is not part of my mod's functionality. ModManager is responsible for that.

I know the ModManager is responsible for enabling dependent. But I did an error occurred enabled a mod need dependent, and when I not enabled ModManagerLoadOrderSorter eliminates this problem.

Yes, I'm trying to figure it out. Most likely it's due to reuse of ModSelector class.
REfRigERatoR  [developer] 7 Sep, 2024 @ 9:15am 
if don't use sorting from Mod Manager, then my algorithms for sorting the order of loading mods work well. I checked on 1000+ enabled mods
莫名某某 7 Sep, 2024 @ 9:22am 
There are three different errors:
1: Load Order Sorter mod is enabled (or not) and the player tries to sort the list of all mods by date in the main ModManager window. Pop-up error
2: Load Order Sorter mod is enabled. The prefix of some mods cannot be started correctly. Cannot be repeated. For me it happened when Mod Options Readability Enhancements were enabled and modmanager incorrectly enabled POETRecycleEverything
3: Using the Load Order Sorter can not properly sort the mod. The '82 Oshkosh M911 is placed in front of that DAMN Library
REfRigERatoR  [developer] 7 Sep, 2024 @ 9:24am 
Originally posted by 莫名某某:
`function: sortFunc -- file: MMPanelFilter.lua line # 749 | MOD: Mod Manager
function: @stdlib.lua -- file: null line # 52
function: @stdlib.lua -- file: null line # 63
function: @stdlib.lua -- file: null line # 64
Repeat the above statement many times
function: sort -- file: MMListBox.lua line # 82 | MOD: Mod Manager
function: updateFilter -- file: ModSelector.lua line # 1219 | MOD: Mod Manager
function: order -- file: MMPanelFilter.lua line # 432 | MOD: Mod Manager
function: onMouseUp -- file: ISTickBox.lua line # 189 | Vanilla
java.lang.RuntimeException: Stack overflow
at se.krka.kahlua.vm.Coroutine.ensureStacksize(Coroutine.java:131)
at se.krka.kahlua.vm.Coroutine.setTop(Coroutine.java:147)
at se.krka.kahlua.vm.LuaCallFrame.setTop(LuaCallFrame.java:126)
at se.krka.kahlua.vm.LuaCallFrame.init(LuaCallFrame.java:151)
at se.krka.kahlua.vm.KahluaThread.luaMainloop(KahluaThread.java:999)
at se.krka.kahlua.vm.KahluaThread.call(KahluaThread.java:163)
at se.krka.kahlua.vm.KahluaThread.pcall(KahluaThread.java:1980)
at se.krka.kahlua.vm.KahluaThread.pcallBoolean(KahluaThread.java:1924)
at se.krka.kahlua.integration.LuaCaller.protectedCallBoolean(LuaCaller.java:104)
at zombie.ui.UIElement.onMouseUp(UIElement.java:1228)
at zombie.ui.UIElement.onMouseUp(UIElement.java:1183)
at zombie.ui.UIManager.update(UIManager.java:816)
at zombie.GameWindow.logic(GameWindow.java:262)
at zombie.core.profiling.AbstractPerformanceProfileProbe.invokeAndMeasure(AbstractPerformanceProfileProbe.java:71)
at zombie.GameWindow.frameStep(GameWindow.java:765)
at zombie.GameWindow.run_ez(GameWindow.java:681)
at zombie.GameWindow.mainThread(GameWindow.java:495)
at java.base/java.lang.Thread.run(Unknown Source)
`

reproduced even with only two mods enabled: "ModManager" and "ModManager:Server"
So this bug is not directly related to my mod
莫名某某 7 Sep, 2024 @ 9:28am 
For the third mistake. Perhaps because that DAMN Library was not added to the dependency of '82 Oshkosh M911. Although there is a dependency in the steam Workshop presentation
莫名某某 7 Sep, 2024 @ 9:31am 
Originally posted by 莫名某某:
Originally posted by REfRigERatoR:

I'm trying to reproduce what you're talking about now, and it doesn't work...
prerequisites: ModManager and ModManagerLoadOrderSorter are enabled.
steps: enable the '69 MIni Mk2 mod (requires that Damn library)
result: there are no problems, that Damn library is activated, no extra mods are enabled

But enabling dependent mods is not part of my mod's functionality. ModManager is responsible for that.

I know the ModManager is responsible for enabling dependent. But I did an error occurred enabled a mod need dependent, and when I not enabled ModManagerLoadOrderSorter eliminates this problem.

Then it is the fault of modmanager itself. Because I only enabled modmanager and Load Order Sorter
< >
Showing 1-15 of 29 comments
Per page: 1530 50