RimWorld

RimWorld

Flavor Text
hekmo  [developer] 7 Jan @ 12:09pm
BUG REPORTS
Report any bugs or errors here. Include a log of the error.
Last edited by hekmo; 22 Jun @ 11:10pm
< >
Showing 1-15 of 35 comments
I've been playing with the Flavor Text mod in my modlist including Medieval Overhaul and it worked perfectly. But once I've loaded a save without changing the modlist, whenever a meal was cooked (in this case a Simple Meal) I got the following OutOfRange error message, and the meal name got set to default.

Let me know if you need more info or need me to run a version with only Medieval Overhaul and Flavor Text in the modlist.

Edit: It seems to not work for meat only meals, like a meal using only tortoise meat or mixed meat meals as well. I've tested now with other ingredients and it generated a flavor text normally.

flavorString is braised {0_coll} (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) ingredient was Meat_Tortoise (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) flavorString is {0_coll} fried in a pan and basted with its own juices. <i><color=#66E0E4FF>Flavor Text</color></i> (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) ingredient was Meat_Tortoise (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) Error when formatting flavor description: reason: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index [Ref EFF13321] Duplicate stacktrace, see ref for original (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) The final compiled and formatted flavor label was null or empty, cancelling the search. (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)
Last edited by GrassTypeFire; 14 Jan @ 9:51am
hekmo  [developer] 14 Jan @ 8:05pm 
Originally posted by GrassTypeFire:
I've been playing with the Flavor Text mod in my modlist including Medieval Overhaul and it worked perfectly. But once I've loaded a save without changing the modlist, whenever a meal was cooked (in this case a Simple Meal) I got the following OutOfRange error message, and the meal name got set to default.

Let me know if you need more info or need me to run a version with only Medieval Overhaul and Flavor Text in the modlist.

Edit: It seems to not work for meat only meals, like a meal using only tortoise meat or mixed meat meals as well. I've tested now with other ingredients and it generated a flavor text normally.

flavorString is braised {0_coll} (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) ingredient was Meat_Tortoise (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) flavorString is {0_coll} fried in a pan and basted with its own juices. <i><color=#66E0E4FF>Flavor Text</color></i> (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) ingredient was Meat_Tortoise (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) Error when formatting flavor description: reason: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index [Ref EFF13321] Duplicate stacktrace, see ref for original (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39) The final compiled and formatted flavor label was null or empty, cancelling the search. (Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

The log messages you're getting tell me you're using the previous version of the mod, which I updated yesterday. I wasn't able to recreate the error with the current version, so try it with the current version and lmk if you still get the error. You may need to unsub and resub to the mod, steam workshop can be finicky sometimes :/
Last edited by hekmo; 14 Jan @ 8:12pm
apologies, I haven't checked if the mod was updated. But I resubbed to it and still got the same error, it pops up as soon as the save is loaded. I'll make a test with a simplified modlist when I can and debug it from there.

To help keep track of the mod version, I'd recommend adding a <modVersion>0.1.1</modVersion> in the About.xml and a <version>0.1.1</version> to the Manifest.xml
Last edited by GrassTypeFire; 16 Jan @ 5:16am
hekmo  [developer] 15 Jan @ 4:35pm 
Gahh, it was my workshop version that hadn't been updated. I went ahead and updated to v0.1.2 and removed some debug messages that may have been the problem. Also included the version numbers in the About.xml like you suggested.

If it keeps happening see what the minimum mod list is to recreate it and send the full debug log. Cause I'm still not able to trigger it on my end here.

Are you using any of the Food Texture Variety mods by chance?
Nice! Thanks for the quick replies!

I couldn't recreate the error with the minimum mod list yet so I'm guessing it's a conflict with one of the 400 mods where the error poped up. It might take a while until I can track it down so I'll post it here in case it happens again. I'm sending the full log that I get when loading the save, the error is at line 6382 onwards: https://gist.github.com/HugsLibRecordKeeper/4a1c09e47e4d9d29746fef6b08e29364

I'll also editing my past comments to reduce the logs messages to make this thread easier to read.

Oh and I'm not using any Food Texture Variety mods.

Edit: Looking back at the previous log messages with the debugs prints, it seems that some flavor descriptions are being generated without the flavor string like 'braised thing'. Do you think that has some relation to the error?
Last edited by GrassTypeFire; 16 Jan @ 5:25am
hekmo  [developer] 16 Jan @ 3:57pm 
"braised thing" is just another flavor name like all the others. An error there would create the error you're experiencing, but I've gone over it and everything looks proper.

If you haven't narrowed it down, try using this experimental version of the mod that has more verbose logging, and send me those logs.
https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3363111420
Last edited by hekmo; 16 Jan @ 3:58pm
I've ran the save with your experimental mod and got the logs here: https://gist.github.com/HugsLibRecordKeeper/e62512d3ffece765843dcb371864f454

Your prints start at line 6537, and the first error is logged at line 6679 with a "Found digit 66 in substring".
hekmo  [developer] 16 Jan @ 6:40pm 
Originally posted by GrassTypeFire:
I've ran the save with your experimental mod and got the logs here: https://gist.github.com/HugsLibRecordKeeper/e62512d3ffece765843dcb371864f454

Your prints start at line 6537, and the first error is logged at line 6679 with a "Found digit 66 in substring".
Well, that number should be 0 lmao. Are you using any mods that change the color of the meal name text or format the text?

EDIT: Wait I see it. Something that's appending the source mod to an item's description. That's on me for not being precise enough when replacing placeholder text. Working on a fix.
Last edited by hekmo; 16 Jan @ 9:59pm
Not that I know, only mod that changed anything to the meals was Medieval Overhaul and only the textures.

If you need help testing the fix just let me know!
hekmo  [developer] 17 Jan @ 2:00pm 
Originally posted by GrassTypeFire:
Not that I know, only mod that changed anything to the meals was Medieval Overhaul and only the textures.

If you need help testing the fix just let me know!

Alright, I updated Flavor Text - Experimental to include this new fix, go ahead and see if it works on your side. :)

The specific thing this other mod is doing is appending the name of my mod to the meal description, in italics and light blue text. You know any of your mods that do that? If this fix works, you should also be able to see what I'm talking about in the info window for a "braised meat" meal (or any item probably).
Last edited by hekmo; 17 Jan @ 3:24pm
Yup it worked, I tried making a 'braised' meal and no errors! Thank you very much for the fix!

Oooh now that you metioned a light blue text there is a mod that does just that, which is the What's This Mod (https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=2258431182). I didn't think about it because I thought it didn't affect the description directly to cause a conflict so sorry about that.
hekmo  [developer] 21 Jan @ 2:24am 
Yep, that'd be it lol. I did some more work on compatibility, and now everything's uploaded to the main Flavor Text mod.
Something with VCE is causing these messages to popup everytime a dessert is made
Unable to find a matching FlavorDef for meal VCE_LavishDessert809637 at (165, 0, 193). Please report. Error: System.InvalidOperationException: Attempted to get valid flavor defs for meal type but there were none [Ref 47C18511] Duplicate stacktrace, see ref for original 417 FlavorDefs are loaded FlavorDefs were initially passed into TryGetFlavorDef to search within 0 FlavorDefs match the meal type ingredient in slot 0 was RawBerries ingredient was in the following thingCategories PlantFoodRaw FSFRawTasty FT_Berry ingredient in slot 1 was Chocolate ingredient was in the following thingCategories FSFGluttonous FT_Sugar UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch6 (string) FlavorText.CompFlavor:TryGetFlavorText (System.Collections.Generic.List`1<FlavorText.FlavorDef>) FoodTextureVariety.Graphic_MealVariantsExpanded:FindByFlavorDef (Verse.Thing) FoodTextureVariety.Graphic_MealVariantsExpanded:PopulateIngredientList (System.Collections.Generic.List`1<Verse.ThingDef>,Verse.Thing) FoodTextureVariety.Graphic_MealVariantsExpanded:SubGraphicFor (Verse.Thing) Verse.Graphic_StackCount:DrawWorker (UnityEngine.Vector3,Verse.Rot4,Verse.ThingDef,Verse.Thing,single) FoodTextureVariety.Graphic_MealVariantsExpanded:DrawWorker (UnityEngine.Vector3,Verse.Rot4,Verse.ThingDef,Verse.Thing,single) Verse.Graphic:Draw (UnityEngine.Vector3,Verse.Rot4,Verse.Thing,single) Verse.Thing:DrawAt (UnityEngine.Vector3,bool) Verse.ThingWithComps:DrawAt (UnityEngine.Vector3,bool) Verse.Thing:DynamicDrawPhaseAt (Verse.DrawPhase,UnityEngine.Vector3,bool) Verse.Thing:DrawNowAt (UnityEngine.Vector3,bool) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.PawnRenderUtility.DrawCarriedThing_Patch1 (Verse.Pawn,UnityEngine.Vector3,Verse.Thing) Verse.PawnRenderNodeWorker_Carried:PostDraw (Verse.PawnRenderNode,Verse.PawnDrawParms,UnityEngine.Mesh,UnityEngine.Matrix4x4) Verse.PawnRenderTree:Draw (Verse.PawnDrawParms) Verse.PawnRenderer:RenderPawnInternal (Verse.PawnDrawParms) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.PawnRenderer.RenderPawnAt_Patch9 (Verse.PawnRenderer,UnityEngine.Vector3,System.Nullable`1<Verse.Rot4>,bool) Verse.PawnRenderer:DynamicDrawPhaseAt (Verse.DrawPhase,UnityEngine.Vector3,System.Nullable`1<Verse.Rot4>,bool) Verse.Pawn:DynamicDrawPhaseAt (Verse.DrawPhase,UnityEngine.Vector3,bool) Verse.Thing:DynamicDrawPhase (Verse.DrawPhase) PerformanceFish.Rendering.DynamicDrawManagerPatches/DrawDynamicThingsPatch:DrawThingsNow () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.DynamicDrawManager.DrawDynamicThings_Patch1 (Verse.DynamicDrawManager) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Map.MapUpdate_Patch1 (Verse.Map) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.UpdatePlay_Patch7 (Verse.Game) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Root_Play.Update_Patch1 (Verse.Root_Play)
Okay now it's spamming the logs with the same error constantly and not just when it's finished a meal
hekmo  [developer] 29 May @ 9:52am 
Originally posted by Imagine12:
Okay now it's spamming the logs with the same error constantly and not just when it's finished a meal

Thank you for the detailed error log. I'm not able to recreate the error with Flavor Text and Food Texture Variety. Is Flavor Text updated to its current version? Check its about.xml, should be on modVersion v0.1.5.

Also check if Food Texture Variety is updated. Within its mod folder, FlavorText\1.5\Assemblies\FlavorText.dll should have been modified on or after May 5.

If it's not that, there's another mod on your modlist causing an incompatibility. Potentially whichever mod is adding the categories that begin with "FSF"
Last edited by hekmo; 29 May @ 9:58am
< >
Showing 1-15 of 35 comments
Per page: 1530 50