XCOM 2
New GTS Perks [LL]
meemorize 25 Jul, 2016 @ 4:18pm
Greyed out GTS abilities aka LW Perk Pack compatibility
This was too long to post as a comment so I put this here :) Hope you don't mind.
---

@Advent Avenger: I have the same issue with greyed out skills as Ser Lancelot (in a new campaign).

I've been digging through the source files and I think may have found the issue we are both having.

In your mod you register the perks with a soldier class name like so:


Template.Requirements.RequiredSoldierClass = 'Sharpshooter';

However in the LW Perk Pack I found this reference which looks like is remapping the soldier class names in the game (even the base classes):


[XComGame.X2SoldierClass_DefaultClasses]
;-SoldierClasses="Grenadier"
;-SoldierClasses="Specialist"
;-SoldierClasses="Ranger"
;-SoldierClasses="Sharpshooter"
+SoldierClasses="LW_Assault"
+SoldierClasses="LW_Shinobi"
+SoldierClasses="LW_Sharpshooter"
+SoldierClasses="LW_Ranger"
+SoldierClasses="LW_Gunner"
+SoldierClasses="LW_Grenadier"
+SoldierClasses="LW_Specialist"

I have never written a XCOM mod before my background as a programmer makes me think that perhaps all our games' "Specialist" class soldiers are internally (because of the LW Perk Pack) now actually "LW_Specialist" and that's why the requirements do not meet those in your mod since that one is looking at the specific class name "Specialist" + rank requirement.

Would it be possible to expose the soldier class names your mod targets in the .ini files? That way users with the LW Perk Pack enabled could set them in the ini and (hopefully) the change to your mod would be minimal.

Something like (in INI):

PSIONIC_CLASS_NAME = "PsiOperative";
SPECIALIST_CLASS_NAME = "Specialist";
(etc)

then we could remap the string to say:

SPECIALIST_CLASS_NAME = "LW_Specialist";

for our installations without affecting the default state of this mod.

Again, apologies for making some assumptions here, I've not written a mod before myself and am not sure if what i'm suggesting is an "easy fix" or quite involved. I just thought this might help the conversations I've seen on this mod page in a semi-constructive way :)
< >
Showing 1-8 of 8 comments
Juravis  [developer] 25 Jul, 2016 @ 5:30pm 
Good analysis. I'm on it.
Juravis  [developer] 25 Jul, 2016 @ 5:35pm 
Ill have a fix up by tomorrow max.
meemorize 25 Jul, 2016 @ 10:27pm 
Wow, thanks for the quick change. As per the comment I just left. Tested this and works great with LW Perk Pack once the classes are mapped correctly to the LW_{class} the LW Perk Pack adds.

Thanks again.
Ser Lancelot 26 Jul, 2016 @ 4:46am 
Thanks, meemorize for digging into this...it was totally befuddling me.

ADVENT Avenger, sorry if I stepped on any toes when I was trying to have this issue solved.
Ser Lancelot 26 Jul, 2016 @ 5:16am 
Looking like that the PsiOperative is still "PsiOperative" and not "LW_PsiOperative"?
meemorize 26 Jul, 2016 @ 3:06pm 
@Ser Lancelot, yes I believe LW Perk Pack is not modifying the PsiOperative class so it should NOT have the LW_ prefix :)
Ser Lancelot 26 Jul, 2016 @ 3:29pm 
Works great, thanks!
Ser Lancelot 28 Jul, 2016 @ 3:09pm 
ADVENT Avenger, I'd appreciate it if you would please unblock me? I cannot even report bugs or problems with your mods. Are you taking this personal in some sense? Sure, the other day I overlooked the fact that I needed to do .ini edits, but as this thread pointed out, it was an oversight on your part. Yet, I'm the one being blocked from any and all comment sections of your mods? I subscribe and use practically 95% of your mods and at this point, I cannot report bugs or problems with it.

All because I was struggling to get this mod to work, which turned out in the end, was actually not erroneous on my behalf?

You don't have to be my friend, I don't have to be your friend, but I do believe that I should be able to report bugs/problems with mods from a mod developer I've come to depend and trust.

At this point, I have not once thumbed down or gave you a bad rating on any of your other mods that I use or don't use. You are doing this block stemming all from *two* posts I made in this mod?
< >
Showing 1-8 of 8 comments
Per page: 1530 50