Yep, I managed to make it work. Honestly it was easier than I thought it would be 'cause it didn't need any localization whatsoever. Thanks for the offer nonetheless!

Ah I see! So die you figure it out? Tell me if I can help!

I kinda asked here since I mistakenly thought the original was not being maintained. Now that I looked again at the last update there, I now know I should've asked there instead. My bad.

The mod doing it was made by me actually. I created it since I just wanted to play the game with both mods on and didn't want to wait.

Are you maybe mistaking this mod with the original more maritime mod? This is only an extendion to the original mod with some tweaks.

However, there is a mod for this: https://steamhost.cn/steamcommunity_com/sharedfiles/filedetails/?id=3322762447&searchtext=Set-Ma%27at

What's missing iss the Industrial District adjacency bonus. Set-Ma'at is an unique Industrial District for Egypt on that mod.

Does it crash or what are you missing?

Could you add compatibility with Sukritact's Egypt Rework Set-Ma'at?

v6.0 (2024-06-07)
- Most Great Merchants now do not require a Commercial Hub for activation.
- Most Great Admirals are now activated at Arsenal .

Seems like we need to slightly tweak the query to work perfectly?

Tested and affected Great Merchant abilities are all activating now and without a Commercial Hub. The Campus and Industrial Zone Merchants are also activating elsewhere but their abilities still increase tourism of those districts in your empire, so they work but are unintentionally removed from district activation too. Works with both Great Merchants from Monopoly++ as well.

It might be worth mentioning in the description that Great Admirals still require either a coastal city or a Harbor in order to recruit; that appears to be hardcoded and not changeable to Arsenal.

Uploaded a new version. Again, couldn't really test it.

Oh dear. I only tested changes in DB, since I have No Time for Tests atm. Gonna look into it this evening.

One other quirk of your update is that Great Merchants Jamsetji Tata and Masaru Ibuka no longer need a Campus or Industrial Zone respectively when they should remain untouched.

Tested the update and while the Merchants can activate elsewhere, the abilities don't actually trigger since the AttachmentTargetType in GreatPersonIndividualActionModifiers hasn't been changed from GREAT_PERSON_ACTION_ATTACHMENT_TARGET_DISTRICT_IN_TILE. Using Ibn Khaldun from Babylon DLC as an example, GREAT_PERSON_ACTION_ATTACHMENT_TARGET_CITY should be used instead. I also tested GREAT_PERSON_ACTION_ATTACHMENT_TARGET_PLAYER but that one didn't work for the 4 Luxury creating Merchants, only TARGET_CITY works.

v5 (2024-05-02)
- Most Great Merchants now do not require a Commercial Hub for activation-
- Most Great Admirals are now activated at Arsenal .

The subselect did just that. It excluded all great merchants with effects affecting buildings or districts that have to be activated at commercial hub. That is geovanni only, but affects great merchants from other mods the same way.

Sounds good. Just remember that Geovanni needs to be exempted since his ability specifically needs to activate on a Commercial Hub. Same with modded Raymond Rubicam. I'm sure you can write it much better since I'm still new to SQL.

The pasted SQL was partly wrong, but should only serve as a concept. Will implement it correctly!

Oh true! Will do! Good call!

I'd be happy to look into mod compatibility if anyone has suggestions, I already checked most major mods; Equally Great Merchants, JNR's Ancient Paragons, Nyguita's More Great People, Great Pirates, and Ea Nasir. Didn't check Dags even more great people mod since it seems outdated and overlaps somewhat with others.

I was going to add a check for Great Person class type so that the changes also don't affect JNR's Great Explorers or anything else but I see you just did that. Cheers.

Thank you for this!
I am hesitant about this, since we can't ensure other great merchants added by other mods won't break. A explicit whitelist for well-known Great Merchants and Admirals should be viable.
This is a great idea! I will note that.
Though, I am very busy these days, it will take me some time.

I tested each Great Merchant after changing them and they all seem to work (ability triggers gold, trade routes, envoys, etc) except for Geovanni de Medici; removing the district requirement broke his ability to build a Market/Bank when there is no Commercial Hub so I left him alone. The abilities attach to the player instead of the district with the change.

Feel free to test for yourself though, I didn't go any deeper than using the Cheat mod for gold, recruiting all Merchants and triggering their ability on other tiles to see if the instant parts work. For example, I didn't check if bonus trade route yields are actually increased, and I just realized I forgot to check if Mary Katherine Goddard still increased Diplomatic Visibility. Anyways, it's a start if you want to include it.

Oh you are very right about the Arsenal thing! Should defenitely do that. About removing the district requirements. Not sure if that affects the outcome of some effects.

Regarding the activation of Great Merchants at Commercial Hubs...while the activator can't be set to two districts, it is possible to remove the Commercial Hub district requirement from the appropriate Great Merchants (Geovanni de Medici builds a Market/Bank so he shouldn't be changed but the rest are all fine). Also, Admirals should activate on Arsenals instead of Harbors.

I'll open a discussion with some code.

How does the game handle unique commercial hubs? somehow fudge the harbour & harbour uniques as "commercial hub uniques".
Either way, thank you for trying, great mod nonetheless.

@[PIGZ]MrTango: Sorry but it is not possible to modify it in a way that GreatMerchants can be activated at both districts, Harbor and CommercialHub.

Plz could great merchants be activate-able in the harbour & unique equivs.

This actually is a great Idea! But I think you are mistaking this Mod with the original More Maritime mod. This one only adds some minor adjustments to GPP and stuff.

love this mod and had an idea; varangian harold has no unique district or building would be cool to get a unique arsenal for him

Yeah, that's what I figured out, too. It can be achieved with some lua and UI coding. However, some of those GPPs directly modify commercial Hub buildings. Note worth the effort imho.

Yeah, i'm looking into it too, and it seems fixing this would be close to impossible. Too bad, I really liked the idea

This is a helpful feedback! Gonna look into it. However, I am not sure if this is easy to come by.

I was playing a naval map with lot of harbors, and not even one commercial hub... guess what? you can't activate great merchants in harbors :(

This mod actually only converts Admiral GPPs to Merchant GPPs. If another mod removes the admiral GPPs before this mod kicks in it wont have any effect. Gonna PM you to figure this out! :)

Thank you for being so generous.

Some of the mods I use that may affect districts are:
JNR's District Expansion
Specialist Progression

If it wasn't for the impact of these mods, I can't think of other reasons

I can help to find the issue! Can be a load order problem then.

uhh...a lot...
I think this is just my problem.
thx.

Hm never got that report before. What mods do you use in combination?

Hi! I love this mod.
But in my game, the Harbor district and its buildings do not yield Great Merchant Points.
Oh, the Arsenal district and its buildings works perfectly.
Maybe you can check it out?

Oh yeah, thank you CypRyan!

There is a comment on the original mod page that explains how to avhieve this by editing the mod code. Does that work for you?

I wish that Arsenal would not cancel Encampment and vice-versa

v2: Fix GPP of harbor project.

Thank you for the info. Gonna fix that soon!

Not sure if intentional, but the harbour shipping project still gives great admiral points on completion.

Maybe I expressed misleadingly. Only when installed in combination with Better Coastal Cities and Water Tiles mod there are balancing changes.
Both mods add additional food bonuses to water tiles on their own. That would lead to insance amount of food from coastal tiles.

Nice one! Was wanting that change for a long time!
Although don't understand why make bonus food from waterbreak and harbor not stack, if these 2 districts are just meant to be created together.

Is there a mod/option to just have great admiral => merchant on the harbor?

nice

@Rough: The food Bonus of Harbor and Waterbreaks do not stack.

what does it modify in Better Coastal Tiles?