I LOVE YU MODDER

Thanks for the bug reports everyone, for 1.5 and 1.6 im gnona start working on my mods sometime soon to get them compatible.

Incompatible with Way Better Romance . Pawns that have their work interrupted by an interaction from that mod freeze in place indefinitely and both of them will just stand there until they starve or pass out.

Throws a NullReference exception here:
at Job_Satisfaction.JobSatisfactionUtility.GetTraitMultiplier (Verse.Pawn pawn)
at Job_Satisfaction.JobSatisfactionUtility.CalculateThresholds (Verse.Pawn pawn)
at Job_Satisfaction.GameComponent_WorkTracker.ApplyMoodBoosts (Verse.Pawn pawn)
at Job_Satisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix (Verse.AI.Pawn_JobTracker __instance, Verse.AI.JobCondition condition, System.Boolean startNewJob, System.Boolean canReturnToPool)

Hi! I encountered an error when a psychic ritual raid started (from the Horax Cultist raid, summoning a Fleshbeast). The game throws a NullReferenceException coming from Job_Satisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix.

System.NullReferenceException: Object reference not set to an instance of an object
at Job_Satisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix (Pawn_JobTracker __instance, ...)

It happens the moment the raid message appears.

Let me know if you need the full log or load order. Thanks for your awesome mod!

btw, the death pall resurrection error occurs whenever something starts to ressurect, and the debug log says

Exception in JobSatisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix: System.NullReferenceException: Object reference not set to an instance of an object

Couple issues:
1: Quest guests who are unable to work still have fulfillment, which is very bad if it's something like an imperial staying for 2 weeks as it makes keeping them happy much harder.

2: I've been looking into this and it seems like it has some issues with anomaly, specifically the death pall event. It keeps giving me an error every time death pall resurrect something, also i've been experiencing a major bug where sometimes all instance recognition gets completely screwed up and all characters remain idle and unable to do anything, even drafted move gets disabled, and this occurs during death pall and the only solution is to exit out of and re-open rimworld. I am not 100% sure that it traces back to this mod, but this is the only mod I've been getting errors with on anomaly so maybe you could look into that.

@Renegaiden

I am experiencing the exact same error. Whenever a Mechanoid does any Job where it involves creating something (e.g. making a shirt, etc.), it gets an error when the job if completed.

I love the idea of celebrating finished projects together with your pawns

This is def not safe to remove mid playthrough, it will brick your save

@pig in a pumpkin yeah shouldnt be an issue

is there a way to remove this mod from an active playthrough?

@Renegaiden Just wanted to say, I am also experiencing this issue.

Like, the mechs actually track their satisfaction value or whatever, so I assume it's something to do with the mod trying to apply moodlets which... mechs can't get by virtue of not being humanlike. I ain't a programmer, I can't read C#, but that's the educated guess I've got here.

Red errors whenever a Biotech mechanoid finishes a task and prompts the mod to add a work value to it. Actual humanlike pawns have their thresholds listed in the debug log (which by the way, that gets spammy *fast*), but mechanoids just yield the "adding x work" and "total work now x".

"Exception in JobSatisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix: System.NullReferenceException: Object reference not set to an instance of an object"

@Kalmorph that may be fixed now as i was trying to call thoughtdefs that didnt exist.

2 logs showing an error as "Failed to find RimWorld.ThoughtDef named JobSatisfaction_Burnout_Medium. There are 1470 defs of this type loaded." and "JobSatisfaction: ThoughtDef 'JobSatisfaction_Burnout_Medium' not found!"

Logs: https://gist.github.com/HugsLibRecordKeeper/e866cef80549988f0a6e5d8efa85436e

@Guderian no problem, i do hope it was not related to my mod but as far as im aware a null reference exception cant cause such an issue since it only means the next part of my code where the exception is relevant wont run, not any in game code.

Dear @Lewkah0

Not sure if the bug reported is related to the mod or not. I noticed that only the constructer and constructoid mech are standing, limited the area allowed for them until I found that they are trying to build a wall lamp and for some reason couldn’t. Perhaps the reported error is not very related the issue of standing. I resolved it by removing the lamp. Thank you again for your amazing mods!

@Rovalen im saying my mod shouldnt be causing that, if @Guderian is using no other mods then its my mod but ive had that same error and it does not cause pawns to stand still.

@Lewkah0 my brother in christ, pawns standing still is a big error

@Guderian that is not a big error

Hello Lewkah0, I am getting errors from this mod. Pawns are standing still. I think maybe an interaction with TD enahncement pack's end current job gizmo?

Exception in JobSatisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix: System.NullReferenceException: Object reference not set to an instance of an object
[Ref F29C5898]


https://gist.github.com/HugsLibRecordKeeper/48dafd65b4798842a12ca40d91ec0f3e

Also major props for making this mod. I'm a useless gamer who ridiculously complains about the quality of something free even though I couldn't create something even a fraction of how complex this is.

@Lewkah0, I'm sorry, I reread my comment and it sounded a little harsh. Please don't change it on my account as I'm just one guy.

I think you're absolutely right that this mechanic DOES need a downside because its basically just making the game easier for you by rewarding a normal activity that is done day in and day out. Maybe the numbers need to be played with.

I also think that I might have just felt that way because I expected a mod called Job Satisfaction would be focused solely on creating satisfaction on completion of jobs. Maybe that's just me tho.

@TheLordEternal ill fix when i have time

(sorry for the comment spam btw)
Seems it could be because it's only got "JobSatisfaction_Burnout" defined in the ThoughtDef file, with no _Small, _Medium, _Large, or _Huge versions unlike the others, but the game still tries to use them like it does.
I'm not much of a coder tho, so can't say for sure.

(not posting a log because it seems to me to be just a misnaming thing, as i can't seem to find anything named 'JobSatisfaction_Burnout_Large' in the mod's ThoughtDef file.)

Just a a heads-up, i'm getting a error in my log that it failed to find a ThoughtDef named "JobSatisfaction_Burnout_Large", think it might be from this mod.
Not a huge issue, but might good to know about in any case.
Nice mod btw, i like it.

think I have encountered a bug
Link to log:
https://gist.github.com/HugsLibRecordKeeper/0bc24f56fb358fdedf3510024cac4f19
see discussion for error message

apologies, did some further investigation and determined that this mod isn't the cause. the player.log file just cuts off right before the game crashes.

@cerhio ill make it turned off by default

@pee ness that error is a minor error which is simply that i forgot a null check somewhere, do u have the full error?

I keep getting error messages saying something isn't found. Also the burnout thing is annoying. I feel like you can't get burned out from trying to survive otherwise you'd have mass suicides around the globe from people who bust their ass to make a few dollars just to feed their kids.

anyone else getting a crash while using this mod? getting a
Exception in JobSatisfaction.Pawn_JobTracker_EndCurrentJob_Patch.Prefix: System.NullReferenceException: Object reference not set to an instance of an object

@suxapь made it not so ass now.

@suxapь it's a placeholder mechanic for now, you can turn it off in mod settings

burnout is ass, infinite -10 mood debuf

@Pipey9 u can always add my discord, i might make a server specific for it but for now dms are fine.

its Lylerlurden

Is there somewhere to post possible bug/mod conflicts? Dont wana clog up the comment feed with error reports.

@Lewkah0
Dude I feel that. I had to do a complete code rewrite of one of my mods to fix some errors. Posted it and fuckin prayed lmao.

If the performance is good ill keep all 3 forever

The ideas behind these 3 mods are so fucking good. Not even like 'how did no one think of that', more like 'how is that not base game'

patch is out.. please work

Im cooking up a big patch that fixes the mod, currently the balance is completely off which im overhauling right now.

@Meyar I'm testing it right now, it barely works at the moment. And it absolutely did not work on its own the last time you commented

Based on some of the previous comments, it might not have been a mod conflict after all. I'll test.

@Oldnewone uh, does steam allow pastebins? If so here you go. Toss this into an .xml and load it into rimpy: https://pastebin.com/Kk889AcY . I tried putting the readable format into pastebin but it's flagging it as offensive, which, go off I guess. Maybe this'll work. https://pastecode.io/s/gd5tgxy4
@Kotel 64 gigs and bad choices.

Also I've been skimming through the latest assembly, and I see that your WorkTracker's WorldComponentTick() clears the job tracker with ResetAllWork() and only then tries to get data out of it, which is likely not intended.

@Lewkah0 Unpopular opinion: hard worker/lazy mood buff multipliers should be reversed (or have a toggle for it), because simple things are harder to lazy people, and hard workers tend to underappreciate their accomplishments

@Nauyaca it seems to suggest that the Burnout Thoughtdef doesnt exist which was the case before my update but should be fixed now, are u sure the mod is updated?

alo, these errors are being spammed, sometimes when starting/finishing jobs and seemingly at random, they still happen after disabling the burnout feature too: https://pastebin.com/Fe6BAFKG