https://gist.github.com/0410f9ce66dec186ceb3a2a85d115d2c

Thank you kindly good sir, will look into it

PerfectlyGenericItem is not ingestible.
Verse.Log:Error(String, Boolean)
RimWorld.Pawn_DrugPolicyTracker:AllowedToTakeToInventory(ThingDef)
RimWorld.JobGiver_MoveDrugsToInventory:GetPriority(Pawn)
Verse.AI.ThinkNode_PrioritySorter:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Tagger:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Subtree:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Conditional:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams)
Verse.AI.Pawn_JobTracker:DetermineNextJob(ThinkTreeDef&)
Verse.AI.Pawn_JobTracker:TryFindAndStartJob()
Verse.AI.Pawn_JobTracker:Verse.AI.Pawn_JobTracker.EndCurrentJob_Patch0(Pawn_JobTracker, JobCondition, Boolean, Boolean)
Verse.AI.Pawn_JobTracker:JobTrackerTick()
Verse.Pawn:Tick()
Verse.TickList:Tick()
Verse.TickManager:Verse.TickManager.DoSingleTick_Patch1(TickManager)
Verse.TickManager:TickManagerUpdate()
Verse.Game:Verse.Game.UpdatePlay_Patch2(Game)
Verse.Root_Play:Update()

Hope this is what you wanted.

I have no experience, but from context clues, I would assume its a conflict error with another mod that changes food.
Would post Huglib logs, but it's getting an error when I try to upload.

Not exactly a bug, but is there anyway to prevent quest rewards from being made of Perfectly Generic material?

Don't know if this would be a bug per say, but sometimes I've noticed that walls in generated scenarios will be made up of generic materials (a mod wasn't removed it just makes them out of the material)

^ I've noticed this as well.

Hey! I don't know if it is very specifically this mod affecting it - it may just be getting mentioned in the log, but the new auto-slaughter under the Animals tab feature comes up empty (I have like 30 chickens and alpacas, so less micromanagement of them is a must LOL) and I get this in console:


From an avid mod-adder and deleter-er, thanks for the awesome mod :D

Hmm thats interesting, will try and get to testing that today if i can

Settings for the mod dont seem to work

@Killa
can you be a little more specific? does the menu not open? or does the setting itself just not do anything?

Hello. I have a couple of bug reports. First is that this mod replaces a random (first?) ingredient of meals with PGI on save load, every time w/o failure. Second, it appears not to be edible or some such, breaking the game when a pawn tries to ingest an item with such ingredient, or if somehow it doesn't break at that point (tends to be fairly random), when the item in question actually is about to be consumed, conferring no nutrition or other effects. And last, there is the original bug report with debug logs I made on Mlie's Discord server, at that point I has been thinking it was his updated mod that caused this behavior: https://discord.com/channels/680705672911913016/693732045100154910/878544577173274715.

@ZzZombo
the way this mod functions is it patches the method in the vanilla backcompatability system that gets called when a def is missing, then replaces it with the PGI def - the only reason it would change the ones in meals is if those defs would be being passed through the backcompatability system in the vanilla game.
testing this end and unable to reproduce - can you repo it with just this mod loaded? if not i would wager its some sort of conflict.

so if theres a missing def, vanilla passes it to its backcompatability check - to check if its something in vanilla thats changed between versions - i patch this method, only if it fails to find a matching def does PGI kick in.

Sadly since the original def is missing - its impossible to know what its supposed to be and by the time it reaches the method i patch theres no context - it doesnt know that its a missing item from a meal - the vanilla system i hook into is hardcoded to only pass the name of the def, its ment as a static thing, to replace A with B between game versions, it was not intended to dynamically catch and replace missing defs, which is what this is an attempt at doing to some small degree

im afraid i dont have access to that link(whats what discord said when i tried to click it), so i dunno what your refering to their

Sorry, this is the log then: https://gist.github.com/e0b1a160184fa497f572f42f7653edbf. Regardless of whether this aspect of the mod is working properly, meals should still be edible, right? And, honestly, I see no point in actually adding this as replacement for missing ingredients, at least with the option to remove PGIs from the game such ingredients (not whole meals!) shouldn't stay just as well.

EDIT: sorry, didn't see the lower half of the post as I didn't scroll that far. I suppose it's possible after patching is done to check meals for PGI in them, right? And then you can act accordingly.

@ZzZombo
as i said, the method patched to make this mod work has no context - it Doesnt know if its an ingredient or not - All it gets to go on is the DefName, the DefType(HediffDef, ThingDef, etc).
im afraid that as far as im aware theres nothing i can do about it, its a limitation

that looks very much like an extra null check or two YC.RealDining.Patch.FoodAbout.Patch_BestFoodInInventory.Postfix would fix the issue
but would need to be done on their end

Originally posted by ZzZombo:

I suppose it's possible after patching is done to check meals for PGI in them, right? And then you can act accordingly.

hmm, you mean like patching on load to remove it from any meals? yeah i Think so, but if your not removing defs from your game and the issue is happening Every load, thats another problem entirely, since those defs Shouldnt be missing - if that makes sense? unless im miss understanding?